Sign upLogin

stellar/xdrgen

View on GitHub
Star

Showing 134 of 134 total issues

Method decode_member has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

      def decode_member(value, member, out)
        case member.declaration
        when AST::Declarations::Void
          return
        end
Severity: Minor
Found in lib/xdrgen/generators/csharp.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method decode_member has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

      def decode_member(value, member, out)
        case member.declaration
        when AST::Declarations::Void ;
          return
        end
Severity: Minor
Found in lib/xdrgen/generators/java.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method switch_for has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

      def switch_for(out, union, ident)
        out.puts "switch #{reference union.discriminant.type}(#{ident}) {"

        union.normal_arms.each do |arm|
          arm.cases.each do |c|
Severity: Minor
Found in lib/xdrgen/generators/go.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method encode_member has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

      def encode_member(value, member, out)
        case member.declaration
        when AST::Declarations::Void
          return
        end
Severity: Minor
Found in lib/xdrgen/generators/csharp.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method decode_innervalue_member has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

      def decode_innervalue_member(value, member, out)
        case member.declaration
        when AST::Declarations::Void
          return
        end
Severity: Minor
Found in lib/xdrgen/generators/csharp.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method encode_member has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

      def encode_member(member, out)
        case member.declaration
          when AST::Declarations::Void
            return
        end
Severity: Minor
Found in lib/xdrgen/generators/java.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method encode_innervalue_member has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

      def encode_innervalue_member(value, member, out)
        case member.declaration
        when AST::Declarations::Void
          return
        end
Severity: Minor
Found in lib/xdrgen/generators/csharp.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method render_struct has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def render_struct(struct, out)
        out.puts "public #{name struct} () {}"
        struct.members.each do |m|
          out.puts <<-EOS.strip_heredoc
                public #{decl_string(m.declaration)} #{m.name.camelize} {get; set;}
Severity: Minor
Found in lib/xdrgen/generators/csharp.rb - About 1 hr to fix

    Method render_definition has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def render_definition(defn, constants_container)
        imports = Set[]
        add_imports_for_definition(defn, imports)

        case defn
    Severity: Minor
    Found in lib/xdrgen/generators/java.rb - About 1 hr to fix

      Method decode_type has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            def decode_type(decl)
        case decl.type
        when AST::Typespecs::Int ;
          "stream.readInt()"
        when AST::Typespecs::UnsignedInt ;
      Severity: Minor
      Found in lib/xdrgen/generators/java.rb - About 1 hr to fix

        Method encode_type has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              def encode_type(type, value)
        case type
        when AST::Typespecs::Int ;
          "stream.writeInt(#{value})"
        when AST::Typespecs::UnsignedInt ;
        Severity: Minor
        Found in lib/xdrgen/generators/java.rb - About 1 hr to fix

          Method encode_type has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                def encode_type(type, value)
        case type
        when AST::Typespecs::Int
          "stream.WriteInt(#{value})"
        when AST::Typespecs::UnsignedInt
          Severity: Minor
          Found in lib/xdrgen/generators/csharp.rb - About 1 hr to fix

            Method type_string has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                  def type_string(type)
        case type
        when AST::Typespecs::Int
          'int'
        when AST::Typespecs::UnsignedInt
            Severity: Minor
            Found in lib/xdrgen/generators/csharp.rb - About 1 hr to fix

              Method decode_type has 26 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                    def decode_type(type)
        case type
        when AST::Typespecs::Int
          'stream.ReadInt()'
        when AST::Typespecs::UnsignedInt
              Severity: Minor
              Found in lib/xdrgen/generators/csharp.rb - About 1 hr to fix

                Method render_typedef_decode_from_interface has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                Open

                      def render_typedef_decode_from_interface(out, typedef)
        name = name(typedef)
        type = typedef.declaration.type
        out.puts "// DecodeFrom decodes this value using the Decoder."
        out.puts "func (s *#{name}) DecodeFrom(d *xdr.Decoder, maxDepth uint) (int, error) {"
                Severity: Minor
                Found in lib/xdrgen/generators/go.rb - About 55 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method render_typedef has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                Open

                      def render_typedef(out, typedef)
        # Typedefs that wrap a pointer type are not well supported in Go because
        # Go does not allow pointer types to have methods. This prevents us from
        # defining the EncodeTo method on these types which is very inconvenient
        # for the render functions that generate structs that contain these
                Severity: Minor
                Found in lib/xdrgen/generators/go.rb - About 55 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                          when AST::Definitions::Struct ;
            name = name ndefn
            out.puts "@Data"
            out.puts "@NoArgsConstructor"
            out.puts "@AllArgsConstructor"
                Severity: Minor
                Found in lib/xdrgen/generators/java.rb and 1 other location - About 50 mins to fix
                lib/xdrgen/generators/java.rb on lines 121..132

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 42.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                          when AST::Definitions::Union ;
            name = name ndefn
            out.puts "@Data"
            out.puts "@NoArgsConstructor"
            out.puts "@AllArgsConstructor"
                Severity: Minor
                Found in lib/xdrgen/generators/java.rb and 1 other location - About 50 mins to fix
                lib/xdrgen/generators/java.rb on lines 102..113

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 42.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Method definition_blocks has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                      def definition_blocks
        children.each_with_object([]) do |child, result|
          next unless child.is_a?(Definitions::Base)

          current_group = result.last
                Severity: Minor
                Found in lib/xdrgen/ast/concerns/has_definitions.rb - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method decode_member has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                      def decode_member(member, out)
        case member.declaration
        when AST::Declarations::Void;
          out.puts "return"
        end
                Severity: Minor
                Found in lib/xdrgen/generators/python.rb - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Severity
                Category
                Status
                Source
                Language