Sign upLogin

stevekaplan123/carpe_diem

View on GitHub
Star

Showing 58 of 58 total issues

Function prototype has a Cognitive Complexity of 67 (exceeds 5 allowed). Consider refactoring.
Open

Searcher.prototype = new function() {
  // search is performed in chunks of 1000 for non-blocking user input
  var CHUNK_SIZE = 1000;
  // do not try to find more than 100 results
  var MAX_RESULTS = 100;
Severity: Minor
Found in doc/app/js/searcher.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function prototype has 160 lines of code (exceeds 25 allowed). Consider refactoring.
Open

Searcher.prototype = new function() {
  // search is performed in chunks of 1000 for non-blocking user input
  var CHUNK_SIZE = 1000;
  // do not try to find more than 100 results
  var MAX_RESULTS = 100;
Severity: Major
Found in doc/app/js/searcher.js - About 6 hrs to fix

    Method copy_data has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
    Open

        def copy_data( sql, coder=nil )
        res = exec( sql )

        case res.result_status
        when PGRES_COPY_IN
    Severity: Minor
    Found in th-pg-config=/path/to/pg_config/gems/pg-0.18.1/lib/pg/connection.rb - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function prototype has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
    Open

    Search.prototype = $.extend({}, Navigation, new function() {
  var suid = 1;

  this.init = function() {
    var _this = this;
    Severity: Minor
    Found in doc/app/js/search.js - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function prototype has 82 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    Search.prototype = $.extend({}, Navigation, new function() {
  var suid = 1;

  this.init = function() {
    var _this = this;
    Severity: Major
    Found in doc/app/js/search.js - About 3 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          for (var i=1, l = regexps.length; i < l; i++) {
      result.title = result.title.replace(regexps[i], highlighters[i]);
      result.namespace = result.namespace.replace(regexps[i], highlighters[i]);
    };
      Severity: Major
      Found in doc/app/js/searcher.js and 1 other location - About 3 hrs to fix
      doc/app/js/searcher.js on lines 139..142

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 96.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          for (var i=0, l = regexps.length; i < l; i++) {
      result.title = result.title.replace(regexps[i], highlighters[i]);
      result.namespace = result.namespace.replace(regexps[i], highlighters[i]);
    };
      Severity: Major
      Found in doc/app/js/searcher.js and 1 other location - About 3 hrs to fix
      doc/app/js/searcher.js on lines 161..164

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 96.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Method filterByRecommendations has 71 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def filterByRecommendations(events, user_id)
      events_attended = []
      tags_list = []
      tag_count = [0,0,0,0,0,0,0,0,0]
      recommended_events = []
      Severity: Major
      Found in app/services/filter.rb - About 2 hrs to fix

        Method report has 65 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        def report( opts )
    db = PG.connect(
        :dbname   => opts.database,
        :host     => opts.host,
        :port     => opts.port,
        Severity: Major
        Found in th-pg-config=/path/to/pg_config/gems/pg-0.18.1/sample/disk_usage_report.rb - About 2 hrs to fix

          Method parse_args has 64 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          def parse_args( args )
    options          = OpenStruct.new
    options.database = Etc.getpwuid( Process.uid ).name
    options.host     = '127.0.0.1'
    options.port     = 5432
          Severity: Major
          Found in th-pg-config=/path/to/pg_config/gems/pg-0.18.1/sample/warehouse_partitions.rb - About 2 hrs to fix

            Method parse_args has 53 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            def parse_args( args )
    options          = OpenStruct.new
    options.database = Etc.getpwuid( Process.uid ).name
    options.host     = '127.0.0.1'
    options.port     = 5432
            Severity: Major
            Found in th-pg-config=/path/to/pg_config/gems/pg-0.18.1/sample/pg_statistics.rb - About 2 hrs to fix

              Method copy_data has 50 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  def copy_data( sql, coder=nil )
        res = exec( sql )

        case res.result_status
        when PGRES_COPY_IN
              Severity: Minor
              Found in th-pg-config=/path/to/pg_config/gems/pg-0.18.1/lib/pg/connection.rb - About 2 hrs to fix

                Method relations has 50 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    def relations
        return @relations if @relations
        relations = {}

        query =  %q{
                Severity: Minor
                Found in th-pg-config=/path/to/pg_config/gems/pg-0.18.1/sample/warehouse_partitions.rb - About 2 hrs to fix

                  Method parse_args has 49 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  def parse_args( args )
    options          = OpenStruct.new
    options.database = Etc.getpwuid( Process.uid ).name
    options.host     = '127.0.0.1'
    options.port     = 5432
                  Severity: Minor
                  Found in th-pg-config=/path/to/pg_config/gems/pg-0.18.1/sample/disk_usage_report.rb - About 1 hr to fix

                    Method parse_args has 47 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                    def parse_args( args )
    options          = OpenStruct.new
    options.database = 'postgres'
    options.port     = 5432
    options.user     = Etc.getpwuid( Process.uid ).name
                    Severity: Minor
                    Found in th-pg-config=/path/to/pg_config/gems/pg-0.18.1/sample/replication_monitor.rb - About 1 hr to fix

                      Identical blocks of code found in 3 locations. Consider refactoring.
                      Open

                          for (var i=1, l = regexps.length; i < l; i++) {
      if (!index.match(regexps[i]) && !longIndex.match(regexps[i]))
        return false;
    };
                      Severity: Major
                      Found in doc/app/js/searcher.js and 2 other locations - About 1 hr to fix
                      doc/app/js/searcher.js on lines 89..92
                      doc/app/js/searcher.js on lines 128..131

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 71.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Identical blocks of code found in 3 locations. Consider refactoring.
                      Open

                          for (var i=1, l = regexps.length; i < l; i++) {
      if (!index.match(regexps[i]) && !longIndex.match(regexps[i]))
        return false;
    };
                      Severity: Major
                      Found in doc/app/js/searcher.js and 2 other locations - About 1 hr to fix
                      doc/app/js/searcher.js on lines 89..92
                      doc/app/js/searcher.js on lines 115..118

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 71.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Identical blocks of code found in 3 locations. Consider refactoring.
                      Open

                          for (var i=1, l = regexps.length; i < l; i++) {
      if (!index.match(regexps[i]) && !longIndex.match(regexps[i]))
        return false;
    };
                      Severity: Major
                      Found in doc/app/js/searcher.js and 2 other locations - About 1 hr to fix
                      doc/app/js/searcher.js on lines 115..118
                      doc/app/js/searcher.js on lines 128..131

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 71.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Method initialize has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
                      Open

                      def initialize(user_id, location, near_me, other, time, tag, recommend)
  @events = Event.all
  if recommend == "true" 
        @events = filterByRecommendations(@events, user_id)
        @events = Filter.addAttendancestoEvents(@events)
                      Severity: Minor
                      Found in app/services/filter.rb - About 1 hr to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method filterByOther has 42 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                      def filterByOther(events, user_id, other)
    friend_events = []
    my_friends = []
    @users_friendships = Friendship.where(user_id: user_id)
    @users_friendships.each do |friendship|
                      Severity: Minor
                      Found in app/services/filter.rb - About 1 hr to fix
                        Severity
                        Category
                        Status
                        Source
                        Language