Sign upLogin

stevekaplan123/carpe_diem

View on GitHub
Star

Showing 58 of 58 total issues

Method parse_connect_args has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    def self::parse_connect_args( *args )
        return '' if args.empty?

        # This will be swapped soon for code that makes options like those required for
        # PQconnectdbParams()/PQconnectStartParams(). For now, stick to an options string for
Severity: Minor
Found in th-pg-config=/path/to/pg_config/gems/pg-0.18.1/lib/pg/connection.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function performSearch has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  function performSearch(data, regexps, queries, highlighters, state) {
    var searchIndex = data.searchIndex;
    var longSearchIndex = data.longSearchIndex;
    var info = data.info;
    var result = [];
Severity: Minor
Found in doc/app/js/searcher.js - About 1 hr to fix

    Method copy_file has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

            def copy_file( wal, path, label, compress=false )
            dest_file = path + wal.basename
            FileUtils::cp wal, dest_file
            if compress
                system *[ 'gzip', '-f', dest_file ]
    Severity: Minor
    Found in th-pg-config=/path/to/pg_config/gems/pg-0.18.1/sample/wal_shipper.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method dispatch has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            def dispatch
            # Synchronous mode.
            #
            unless @async
                self.log "Performing a synchronous dispatch."
    Severity: Minor
    Found in th-pg-config=/path/to/pg_config/gems/pg-0.18.1/sample/wal_shipper.rb - About 1 hr to fix

      Method migrate has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def migrate
        if @relations.empty?
            $stderr.puts 'No tables were found for warehousing.'
            return
        end
      Severity: Minor
      Found in th-pg-config=/path/to/pg_config/gems/pg-0.18.1/sample/warehouse_partitions.rb - About 1 hr to fix

        Method run has 34 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            def run
        run_count = 0

        loop do
            current_stat = self.get_stats
        Severity: Minor
        Found in th-pg-config=/path/to/pg_config/gems/pg-0.18.1/sample/pg_statistics.rb - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                case 40: //Event.KEY_DOWN:
        if (e.keyCode == 40 || e.ctrlKey) {
          if (this.moveDown()) e.preventDefault();
          this.startMoveTimeout(true);
        }
          Severity: Major
          Found in doc/app/js/navigation.js and 1 other location - About 1 hr to fix
          doc/app/js/navigation.js on lines 46..51

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 62.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                case 38: //Event.KEY_UP:
        if (e.keyCode == 38 || e.ctrlKey) {
          if (this.moveUp()) e.preventDefault();
          this.startMoveTimeout(false);
        }
          Severity: Major
          Found in doc/app/js/navigation.js and 1 other location - About 1 hr to fix
          doc/app/js/navigation.js on lines 55..60

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 62.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Method filterByRecommendations has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

            def filterByRecommendations(events, user_id)
      events_attended = []
      tags_list = []
      tag_count = [0,0,0,0,0,0,0,0,0]
      recommended_events = []
          Severity: Minor
          Found in app/services/filter.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method initialize has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  def initialize(result, coders_by_name, format, arraycoder)
            coder_map = {}

            _ranges, nodes = result.partition { |row| row['typinput'] == 'range_in' }
            leaves, nodes = nodes.partition { |row| row['typelem'].to_i == 0 }
          Severity: Minor
          Found in th-pg-config=/path/to/pg_config/gems/pg-0.18.1/lib/pg/basic_type_mapping.rb - About 1 hr to fix

            Method ship_rsync_ssh has 28 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    def ship_rsync_ssh( dest )
            if dest.host.nil?
                self.log "Destination %p missing required 'host' key.  WAL is queued." % [ dest.host ]
                return
            end
            Severity: Minor
            Found in th-pg-config=/path/to/pg_config/gems/pg-0.18.1/sample/wal_shipper.rb - About 1 hr to fix

              Method ship_file has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

                      def ship_file( dest )
            if dest.path.nil?
                self.log "Destination %p missing required 'path' key.  WAL is queued." % [ dest ]
                return
            end
              Severity: Minor
              Found in th-pg-config=/path/to/pg_config/gems/pg-0.18.1/sample/wal_shipper.rb - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method migrate has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

                  def migrate
        if @relations.empty?
            $stderr.puts 'No tables were found for warehousing.'
            return
        end
              Severity: Minor
              Found in th-pg-config=/path/to/pg_config/gems/pg-0.18.1/sample/warehouse_partitions.rb - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method run has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

                  def run
        run_count = 0

        loop do
            current_stat = self.get_stats
              Severity: Minor
              Found in th-pg-config=/path/to/pg_config/gems/pg-0.18.1/sample/pg_statistics.rb - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method filterByOther has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

              def filterByOther(events, user_id, other)
    friend_events = []
    my_friends = []
    @users_friendships = Friendship.where(user_id: user_id)
    @users_friendships.each do |friendship|
              Severity: Minor
              Found in app/services/filter.rb - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method ship_rsync_ssh has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

                      def ship_rsync_ssh( dest )
            if dest.host.nil?
                self.log "Destination %p missing required 'host' key.  WAL is queued." % [ dest.host ]
                return
            end
              Severity: Minor
              Found in th-pg-config=/path/to/pg_config/gems/pg-0.18.1/sample/wal_shipper.rb - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function onkeydown has 27 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                this.onkeydown = function(e) {
    if (!this.navigationActive) return;
    switch(e.keyCode) {
      case 37: //Event.KEY_LEFT:
        if (this.moveLeft()) e.preventDefault();
              Severity: Minor
              Found in doc/app/js/navigation.js - About 1 hr to fix

                Method update has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  def update
    @tags = Tag.all
    time_occurrence_datetime = EventsService.create_time(params)
    new_tags_array = params[:tag_ids]
    tag_string = EventsService.get_tag_string(new_tags_array)
                Severity: Minor
                Found in app/controllers/events_controller.rb - About 1 hr to fix

                  Method create has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    def create
    @tags = Tag.all
    @event = Event.new(event_params)
    @event.time_occurrence = EventsService.create_time(params)
    tag_array = params[:tag_ids]
                  Severity: Minor
                  Found in app/controllers/events_controller.rb - About 1 hr to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                      def create
    @friendship = Friendship.new(friendship_params)

    respond_to do |format|
      if @friendship.save
                    Severity: Minor
                    Found in app/controllers/friendships_controller.rb and 1 other location - About 1 hr to fix
                    app/controllers/attendances_controller.rb on lines 27..36

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 47.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Severity
                    Category
                    Status
                    Source
                    Language