Sign upLogin

stretchr/objx

View on GitHub
Star
conversions.go

Summary

Maintainability
A
1 hr
Test Coverage
B
88%

Method Map.parseURLValues has a Cognitive Complexity of 53 (exceeds 20 allowed). Consider refactoring.
Wontfix

func (m Map) parseURLValues(queryMap Map, vals url.Values, key string) {
    useSliceIndex := false
    if urlValuesSliceKeySuffix == "[i]" {
        useSliceIndex = true
    }
Severity: Minor
Found in conversions.go - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method Map.parseURLValues has 70 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (m Map) parseURLValues(queryMap Map, vals url.Values, key string) {
    useSliceIndex := false
    if urlValuesSliceKeySuffix == "[i]" {
        useSliceIndex = true
    }
Severity: Minor
Found in conversions.go - About 1 hr to fix

exported const URLValuesSliceKeySuffixEmpty should have comment (or a comment on this block) or be unexported
Open

    URLValuesSliceKeySuffixEmpty = ""
Severity: Minor
Found in conversions.go by golint

error strings should not be capitalized or end with punctuation or a newline
Open

    return errors.New("objx: Invalid URLValuesSliceKeySuffix provided.")
Severity: Minor
Found in conversions.go by golint

There are no issues that match your filters.

Category
Status