Sign upLogin

studhub-epfl/studhub-app

View on GitHub
Star
app/src/main/java/com/studhub/app/MeetingPointPickerActivity.kt

Summary

Maintainability
D
2 days
Test Coverage
D
67%

File MeetingPointPickerActivity.kt has 336 lines of code (exceeds 250 allowed). Consider refactoring.
Open

package com.studhub.app

import android.Manifest
import android.app.Activity
import android.content.Context
Severity: Minor
Found in app/src/main/java/com/studhub/app/MeetingPointPickerActivity.kt - About 4 hrs to fix

    Method setupSearchBar has 67 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private fun setupSearchBar() {

        // Initialize the Places SDK
        if (!Places.isInitialized()) {
            Places.initialize(applicationContext, MAPS_API_KEY)
    Severity: Major
    Found in app/src/main/java/com/studhub/app/MeetingPointPickerActivity.kt - About 2 hrs to fix

      Class MeetingPointPickerActivity has 21 methods (exceeds 20 allowed). Consider refactoring.
      Open

      class MeetingPointPickerActivity : AppCompatActivity(), OnMapReadyCallback, CoroutineScope {

    private lateinit var mapView: MapView
    private var confirmButton: Button? = null
    private lateinit var searchView: AutoCompleteTextView
      Severity: Minor
      Found in app/src/main/java/com/studhub/app/MeetingPointPickerActivity.kt - About 2 hrs to fix

        Method setupSearchBar has a Cognitive Complexity of 27 (exceeds 20 allowed). Consider refactoring.
        Open

            private fun setupSearchBar() {

        // Initialize the Places SDK
        if (!Places.isInitialized()) {
            Places.initialize(applicationContext, MAPS_API_KEY)
        Severity: Minor
        Found in app/src/main/java/com/studhub/app/MeetingPointPickerActivity.kt - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method setupMap has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private fun setupMap() {
        if (ActivityCompat.checkSelfPermission(this, Manifest.permission.ACCESS_FINE_LOCATION)
            == PackageManager.PERMISSION_GRANTED
        ) {
            googleMap.isMyLocationEnabled = true
        Severity: Minor
        Found in app/src/main/java/com/studhub/app/MeetingPointPickerActivity.kt - About 1 hr to fix

          Method searchLocation has 28 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private fun searchLocation(locationName: String) {
        idlingResourceSearchLocation.increment()
        launch {
            try {
                withTimeout(5000) { // Set a 5-second timeout for the Geocoder request
          Severity: Minor
          Found in app/src/main/java/com/studhub/app/MeetingPointPickerActivity.kt - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        layoutParams = RelativeLayout.LayoutParams(
                RelativeLayout.LayoutParams.MATCH_PARENT,
                RelativeLayout.LayoutParams.WRAP_CONTENT
            ).apply {
                addRule(RelativeLayout.ALIGN_PARENT_TOP)
            Severity: Major
            Found in app/src/main/java/com/studhub/app/MeetingPointPickerActivity.kt and 1 other location - About 2 hrs to fix
            app/src/main/java/com/studhub/app/MeetingPointPickerActivity.kt on lines 179..187

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 166.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                            layoutParams = RelativeLayout.LayoutParams(
                    RelativeLayout.LayoutParams.WRAP_CONTENT,
                    RelativeLayout.LayoutParams.WRAP_CONTENT
                ).apply {
                    addRule(RelativeLayout.ALIGN_PARENT_BOTTOM)
            Severity: Major
            Found in app/src/main/java/com/studhub/app/MeetingPointPickerActivity.kt and 1 other location - About 2 hrs to fix
            app/src/main/java/com/studhub/app/MeetingPointPickerActivity.kt on lines 88..96

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 166.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status