Sign upLogin

studhub-epfl/studhub-app

View on GitHub
Star

Showing 96 of 254 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    override suspend fun getListings(): Flow<ApiResponse<List<Listing>>> = flow {
        emit(ApiResponse.Loading)

        if (!networkStatus.isConnected) {
            emit(ApiResponse.NO_INTERNET_CONNECTION)
Severity: Major
Found in app/src/main/java/com/studhub/app/data/repository/ListingRepositoryImpl.kt and 1 other location - About 6 hrs to fix
app/src/main/java/com/studhub/app/data/repository/CategoryRepositoryImpl.kt on lines 30..57

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 410.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    override suspend fun getCategories(): Flow<ApiResponse<List<Category>>> = flow {
        emit(ApiResponse.Loading)

        if (!networkStatus.isConnected) {
            emit(ApiResponse.NO_INTERNET_CONNECTION)
Severity: Major
Found in app/src/main/java/com/studhub/app/data/repository/CategoryRepositoryImpl.kt and 1 other location - About 6 hrs to fix
app/src/main/java/com/studhub/app/data/repository/ListingRepositoryImpl.kt on lines 95..122

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 410.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method UserRatingScreen has a Cognitive Complexity of 56 (exceeds 20 allowed). Consider refactoring.
Open

/**
 * Ratings screen for a user with [targetUserId]
 */
@Composable
fun UserRatingScreen(
Severity: Minor
Found in app/src/main/java/com/studhub/app/presentation/ratings/UserRatingScreen.kt - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method CreateListingScreen has a Cognitive Complexity of 53 (exceeds 20 allowed). Consider refactoring.
Open

@OptIn(ExperimentalMaterial3Api::class)
@Composable
fun CreateListingScreen(
    viewModel: CreateListingViewModel = hiltViewModel(),
    navigateToListing: (id: String) -> Unit,
Severity: Minor
Found in app/src/main/java/com/studhub/app/presentation/listing/add/CreateListingScreen.kt - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File MeetingPointPickerActivity.kt has 336 lines of code (exceeds 250 allowed). Consider refactoring.
Open

package com.studhub.app

import android.Manifest
import android.app.Activity
import android.content.Context
Severity: Minor
Found in app/src/main/java/com/studhub/app/MeetingPointPickerActivity.kt - About 4 hrs to fix

    Method UserRatingScreen has 99 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    /**
 * Ratings screen for a user with [targetUserId]
 */
@Composable
fun UserRatingScreen(
    Severity: Major
    Found in app/src/main/java/com/studhub/app/presentation/ratings/UserRatingScreen.kt - About 3 hrs to fix

      Method handleSubmitRating has a Cognitive Complexity of 41 (exceeds 20 allowed). Consider refactoring.
      Open

      fun handleSubmitRating(
    viewModel: IUserRatingViewModel,
    targetUserId: String,
    currentUser: State<ApiResponse<User>>,
    thumbUp: Boolean,
      Severity: Minor
      Found in app/src/main/java/com/studhub/app/presentation/ratings/components/handleSubmitRating.kt - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      ) {
    IconToggleButton(
        checked = isFavorite,
        onCheckedChange = {
            onFavoriteClicked()
      Severity: Major
      Found in app/src/main/java/com/studhub/app/presentation/listing/details/components/FavoriteButton.kt and 1 other location - About 3 hrs to fix
      app/src/main/java/com/studhub/app/presentation/listing/details/components/BlockButton.kt on lines 20..39

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 230.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      ) {
    IconToggleButton(
        checked = isBlocked,
        onCheckedChange = {
            onBlockClicked()
      Severity: Major
      Found in app/src/main/java/com/studhub/app/presentation/listing/details/components/BlockButton.kt and 1 other location - About 3 hrs to fix
      app/src/main/java/com/studhub/app/presentation/listing/details/components/FavoriteButton.kt on lines 21..40

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 230.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Method RatingDialog has a Cognitive Complexity of 38 (exceeds 20 allowed). Consider refactoring.
      Open

      @Composable
fun RatingDialog(
    showDialog: Boolean,
    setShowDialog: () -> Unit,
    onSubmit: (Boolean, String) -> Unit,
      Severity: Minor
      Found in app/src/main/java/com/studhub/app/presentation/ratings/components/RatingDialog.kt - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method CreateListingScreen has 76 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      @OptIn(ExperimentalMaterial3Api::class)
@Composable
fun CreateListingScreen(
    viewModel: CreateListingViewModel = hiltViewModel(),
    navigateToListing: (id: String) -> Unit,
      Severity: Major
      Found in app/src/main/java/com/studhub/app/presentation/listing/add/CreateListingScreen.kt - About 3 hrs to fix

        Method setupSearchBar has 67 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private fun setupSearchBar() {

        // Initialize the Places SDK
        if (!Places.isInitialized()) {
            Places.initialize(applicationContext, MAPS_API_KEY)
        Severity: Major
        Found in app/src/main/java/com/studhub/app/MeetingPointPickerActivity.kt - About 2 hrs to fix

          Method Details has a Cognitive Complexity of 33 (exceeds 20 allowed). Consider refactoring.
          Open

          /**
 * Main composable for the detailed listing screen. It contains nearly all the elements to be displayed.
 *
 * @param onMeetingPointClick handler for when the user clicks the meeting point button
 * @param listing the listing we're displaying details about
          Severity: Minor
          Found in app/src/main/java/com/studhub/app/presentation/listing/details/components/Details.kt - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method Details has 59 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          /**
 * Main composable for the detailed listing screen. It contains nearly all the elements to be displayed.
 *
 * @param onMeetingPointClick handler for when the user clicks the meeting point button
 * @param listing the listing we're displaying details about
          Severity: Major
          Found in app/src/main/java/com/studhub/app/presentation/listing/details/components/Details.kt - About 2 hrs to fix

            File ListingRepositoryImpl.kt has 263 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            package com.studhub.app.data.repository

import android.util.Log
import com.google.android.gms.common.api.Api
import com.google.firebase.database.FirebaseDatabase
            Severity: Minor
            Found in app/src/main/java/com/studhub/app/data/repository/ListingRepositoryImpl.kt - About 2 hrs to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                          layoutParams = RelativeLayout.LayoutParams(
                RelativeLayout.LayoutParams.MATCH_PARENT,
                RelativeLayout.LayoutParams.WRAP_CONTENT
            ).apply {
                addRule(RelativeLayout.ALIGN_PARENT_TOP)
              Severity: Major
              Found in app/src/main/java/com/studhub/app/MeetingPointPickerActivity.kt and 1 other location - About 2 hrs to fix
              app/src/main/java/com/studhub/app/MeetingPointPickerActivity.kt on lines 179..187

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 166.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                              layoutParams = RelativeLayout.LayoutParams(
                    RelativeLayout.LayoutParams.WRAP_CONTENT,
                    RelativeLayout.LayoutParams.WRAP_CONTENT
                ).apply {
                    addRule(RelativeLayout.ALIGN_PARENT_BOTTOM)
              Severity: Major
              Found in app/src/main/java/com/studhub/app/MeetingPointPickerActivity.kt and 1 other location - About 2 hrs to fix
              app/src/main/java/com/studhub/app/MeetingPointPickerActivity.kt on lines 88..96

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 166.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Method ListingForm has 55 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              /**
 * The form to create a listing
 * Params are all the mutable state passed from the parent to be used in the different parts of the
 * form itself.
 * @param onSubmit is the handler of the form submission
              Severity: Major
              Found in app/src/main/java/com/studhub/app/presentation/listing/add/components/ListingForm.kt - About 2 hrs to fix

                Class MeetingPointPickerActivity has 21 methods (exceeds 20 allowed). Consider refactoring.
                Open

                class MeetingPointPickerActivity : AppCompatActivity(), OnMapReadyCallback, CoroutineScope {

    private lateinit var mapView: MapView
    private var confirmButton: Button? = null
    private lateinit var searchView: AutoCompleteTextView
                Severity: Minor
                Found in app/src/main/java/com/studhub/app/MeetingPointPickerActivity.kt - About 2 hrs to fix

                  Method ListingCard has 50 lines of code (exceeds 25 allowed). Consider refactoring.
                  Confirmed

                  @OptIn(ExperimentalMaterial3Api::class)
@Composable
fun ListingCard(listing: Listing, onClick: () -> Unit) {
    Card(
        onClick = onClick,
                  Severity: Minor
                  Found in app/src/main/java/com/studhub/app/presentation/listing/browse/components/ListingCard.kt - About 2 hrs to fix
                    Severity
                    Category
                    Status
                    Source
                    Language