Sign upLogin

studhub-epfl/studhub-app

View on GitHub
Star
app/src/main/java/com/studhub/app/data/local/LocalDataSource.kt

Summary

Maintainability
A
0 mins
Test Coverage
A
93%

Class LocalDataSource has 21 methods (exceeds 20 allowed). Consider refactoring.
Invalid

class LocalDataSource @Inject constructor(
    private val localDatabase: LocalAppDatabase
) {
    private val userDao = localDatabase.userDao()
    private val conversationDao = localDatabase.conversationDao()
Severity: Minor
Found in app/src/main/java/com/studhub/app/data/local/LocalDataSource.kt - About 2 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Invalid

        suspend fun getUnsentMessagesOfUser(userId: String): List<Message> {
        return unsentMessageDao.getUnsentMessagesOfUser(userId).map {
            Message(
                senderId = it.senderId,
                conversationId = it.conversationId,
    Severity: Major
    Found in app/src/main/java/com/studhub/app/data/local/LocalDataSource.kt and 1 other location - About 2 hrs to fix
    app/src/main/java/com/studhub/app/data/local/LocalDataSource.kt on lines 75..85

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 167.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Invalid

        suspend fun getUnsentMessagesOfConversation(conversationId: String): List<Message> {
        return unsentMessageDao.getUnsentMessages(conversationId).map {
            Message(
                senderId = it.senderId,
                conversationId = it.conversationId,
    Severity: Major
    Found in app/src/main/java/com/studhub/app/data/local/LocalDataSource.kt and 1 other location - About 2 hrs to fix
    app/src/main/java/com/studhub/app/data/local/LocalDataSource.kt on lines 87..97

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 167.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Invalid

            return Listing(
            id = listing.id,
            sellerId = listing.sellerId,
            name = listing.name,
            description = listing.description,
    Severity: Major
    Found in app/src/main/java/com/studhub/app/data/local/LocalDataSource.kt and 1 other location - About 1 hr to fix
    app/src/main/java/com/studhub/app/data/local/LocalDataSource.kt on lines 120..129

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 142.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Invalid

                Listing(
                id = it.id,
                sellerId = it.sellerId,
                name = it.name,
                description = it.description,
    Severity: Major
    Found in app/src/main/java/com/studhub/app/data/local/LocalDataSource.kt and 1 other location - About 1 hr to fix
    app/src/main/java/com/studhub/app/data/local/LocalDataSource.kt on lines 136..145

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 142.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Invalid

        suspend fun getFavListings(userId: String): List<Listing> {
        return userFavListingsDao.getUserFavorites(userId)
    }
    Severity: Minor
    Found in app/src/main/java/com/studhub/app/data/local/LocalDataSource.kt and 2 other locations - About 30 mins to fix
    app/src/main/java/com/studhub/app/data/local/LocalDataSource.kt on lines 38..40
    app/src/main/java/com/studhub/app/data/local/LocalDataSource.kt on lines 50..52

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 61.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Invalid

        suspend fun getMessages(conversationId: String): List<Message> {
        return messageDao.getMessages(conversationId)
    }
    Severity: Minor
    Found in app/src/main/java/com/studhub/app/data/local/LocalDataSource.kt and 2 other locations - About 30 mins to fix
    app/src/main/java/com/studhub/app/data/local/LocalDataSource.kt on lines 38..40
    app/src/main/java/com/studhub/app/data/local/LocalDataSource.kt on lines 152..154

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 61.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Invalid

        suspend fun getConversations(userId: String): List<Conversation> {
        return conversationDao.getConversations(userId)
    }
    Severity: Minor
    Found in app/src/main/java/com/studhub/app/data/local/LocalDataSource.kt and 2 other locations - About 30 mins to fix
    app/src/main/java/com/studhub/app/data/local/LocalDataSource.kt on lines 50..52
    app/src/main/java/com/studhub/app/data/local/LocalDataSource.kt on lines 152..154

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 61.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status