Sign upLogin

studhub-epfl/studhub-app

View on GitHub
Star
app/src/main/java/com/studhub/app/data/repository/ConversationRepositoryImpl.kt

Summary

Maintainability
A
0 mins
Test Coverage
F
58%

Method createConversation has a Cognitive Complexity of 68 (exceeds 20 allowed). Consider refactoring.
Invalid

    override suspend fun createConversation(conversation: Conversation): Flow<ApiResponse<Conversation>> =
        flow {
            emit(ApiResponse.Loading)

            if (!networkStatus.isConnected) {
Severity: Minor
Found in app/src/main/java/com/studhub/app/data/repository/ConversationRepositoryImpl.kt - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getUserConversations has a Cognitive Complexity of 26 (exceeds 20 allowed). Consider refactoring.
Invalid

    override suspend fun getUserConversations(user: User): Flow<ApiResponse<List<Conversation>>> =
        callbackFlow {
            trySend(ApiResponse.Loading)

            if (!networkStatus.isConnected) {
Severity: Minor
Found in app/src/main/java/com/studhub/app/data/repository/ConversationRepositoryImpl.kt - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Invalid

                return@flow
Severity: Major
Found in app/src/main/java/com/studhub/app/data/repository/ConversationRepositoryImpl.kt - About 30 mins to fix

    Similar blocks of code found in 9 locations. Consider refactoring.
    Invalid

                if (query.isSuccessful) {
                emit(ApiResponse.Success(conversationToPush))
            } else {
                val errorMessage = query.exception?.message.orEmpty()
                emit(ApiResponse.Failure(errorMessage.ifEmpty { "Firebase error" }))
    Severity: Major
    Found in app/src/main/java/com/studhub/app/data/repository/ConversationRepositoryImpl.kt and 8 other locations - About 1 hr to fix
    app/src/main/java/com/studhub/app/data/repository/ListingRepositoryImpl.kt on lines 275..280
    app/src/main/java/com/studhub/app/data/repository/ListingRepositoryImpl.kt on lines 326..331
    app/src/main/java/com/studhub/app/data/repository/ReportRepositoryImpl.kt on lines 30..35
    app/src/main/java/com/studhub/app/data/repository/UserRepositoryImpl.kt on lines 48..53
    app/src/main/java/com/studhub/app/data/repository/UserRepositoryImpl.kt on lines 289..294
    app/src/main/java/com/studhub/app/data/repository/UserRepositoryImpl.kt on lines 326..331
    app/src/main/java/com/studhub/app/data/repository/UserRepositoryImpl.kt on lines 383..388
    app/src/main/java/com/studhub/app/data/repository/UserRepositoryImpl.kt on lines 401..406

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 121.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Invalid

    class ConversationRepositoryImpl @Inject constructor(
    private val remoteDb: FirebaseDatabase,
    private val localDb: LocalDataSource,
    private val networkStatus: NetworkStatus
) : ConversationRepository {
    Severity: Major
    Found in app/src/main/java/com/studhub/app/data/repository/ConversationRepositoryImpl.kt and 5 other locations - About 35 mins to fix
    app/src/main/java/com/studhub/app/data/repository/CategoryRepositoryImpl.kt on lines 19..23
    app/src/main/java/com/studhub/app/data/repository/ListingRepositoryImpl.kt on lines 26..30
    app/src/main/java/com/studhub/app/data/repository/UserRepositoryImpl.kt on lines 24..28
    app/src/main/java/com/studhub/app/domain/usecase/listing/GetListingsBySearch.kt on lines 20..24
    app/src/main/java/com/studhub/app/presentation/listing/browse/BrowseViewModel.kt on lines 18..22

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 63.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Invalid

        private suspend fun getCachedConversations(userId: String): List<Conversation> {
        return localDb.getConversations(userId)
    }
    Severity: Minor
    Found in app/src/main/java/com/studhub/app/data/repository/ConversationRepositoryImpl.kt and 1 other location - About 30 mins to fix
    app/src/main/java/com/studhub/app/data/repository/UserRepositoryImpl.kt on lines 458..460

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 62.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status