Sign upLogin

studhub-epfl/studhub-app

View on GitHub
Star
app/src/main/java/com/studhub/app/data/repository/ListingRepositoryImpl.kt

Summary

Maintainability
D
1 day
Test Coverage
C
75%

Method getListingsBySearch has a Cognitive Complexity of 58 (exceeds 20 allowed). Consider refactoring.
Invalid

    override suspend fun getListingsBySearch(
        keyword: String,
        minPrice: String,
        maxPrice: String,
        chosenCategories: List<Category>,
Severity: Minor
Found in app/src/main/java/com/studhub/app/data/repository/ListingRepositoryImpl.kt - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File ListingRepositoryImpl.kt has 263 lines of code (exceeds 250 allowed). Consider refactoring.
Open

package com.studhub.app.data.repository

import android.util.Log
import com.google.android.gms.common.api.Api
import com.google.firebase.database.FirebaseDatabase
Severity: Minor
Found in app/src/main/java/com/studhub/app/data/repository/ListingRepositoryImpl.kt - About 2 hrs to fix

    Consider simplifying this complex logical expression.
    Open

                    } else if (listing != null
                    && chosenCategories.isNotEmpty()
                    && (blockedUsers[listing.seller.id] != true)
                    && (listing.name.contains(keyword, true)
                            || listing.description.contains(keyword, true)
    Severity: Critical
    Found in app/src/main/java/com/studhub/app/data/repository/ListingRepositoryImpl.kt - About 1 hr to fix

      Method getUserListings has a Cognitive Complexity of 25 (exceeds 20 allowed). Consider refactoring.
      Invalid

          override suspend fun getUserListings(user: User): Flow<ApiResponse<List<Listing>>> = flow {
        emit(ApiResponse.Loading)

        if (!networkStatus.isConnected) {
            emit(ApiResponse.NO_INTERNET_CONNECTION)
      Severity: Minor
      Found in app/src/main/java/com/studhub/app/data/repository/ListingRepositoryImpl.kt - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Consider simplifying this complex logical expression.
      Open

                      if (listing != null
                    && chosenCategories.isEmpty()
                    && (blockedUsers[listing.seller.id] != true)
                    && (listing.name.contains(keyword, true)
                            || listing.description.contains(keyword, true))
      Severity: Major
      Found in app/src/main/java/com/studhub/app/data/repository/ListingRepositoryImpl.kt - About 1 hr to fix

        Method getListing has a Cognitive Complexity of 24 (exceeds 20 allowed). Consider refactoring.
        Invalid

            override suspend fun getListing(listingId: String): Flow<ApiResponse<Listing>> = flow {
        emit(ApiResponse.Loading)

        // first check if the listing was saved as a draft in the cache
        val draft: Listing? = localDb.getDraftListing(listingId)
        Severity: Minor
        Found in app/src/main/java/com/studhub/app/data/repository/ListingRepositoryImpl.kt - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method getListingsBySearch has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                keyword: String,
        minPrice: String,
        maxPrice: String,
        chosenCategories: List<Category>,
        blockedUsers: Map<String, Boolean>
        Severity: Minor
        Found in app/src/main/java/com/studhub/app/data/repository/ListingRepositoryImpl.kt - About 35 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              override suspend fun getListings(): Flow<ApiResponse<List<Listing>>> = flow {
        emit(ApiResponse.Loading)

        if (!networkStatus.isConnected) {
            emit(ApiResponse.NO_INTERNET_CONNECTION)
          Severity: Major
          Found in app/src/main/java/com/studhub/app/data/repository/ListingRepositoryImpl.kt and 1 other location - About 6 hrs to fix
          app/src/main/java/com/studhub/app/data/repository/CategoryRepositoryImpl.kt on lines 30..57

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 410.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Invalid

                  if (query.isSuccessful) {
            val retrievedListing: Listing? = query.result.getValue(Listing::class.java)
            if (retrievedListing == null) {
                emit(ApiResponse.Failure("Listing does not exist"))
            } else {
          Severity: Major
          Found in app/src/main/java/com/studhub/app/data/repository/ListingRepositoryImpl.kt and 1 other location - About 3 hrs to fix
          app/src/main/java/com/studhub/app/data/repository/CategoryRepositoryImpl.kt on lines 72..82

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 220.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Invalid

              override suspend fun saveDraftListing(listing: Listing): Flow<ApiResponse<Listing>> = flow {
        emit(ApiResponse.Loading)

        try {
            val savedDraft = localDb.saveDraftListing(listing)
          Severity: Major
          Found in app/src/main/java/com/studhub/app/data/repository/ListingRepositoryImpl.kt and 2 other locations - About 2 hrs to fix
          app/src/main/java/com/studhub/app/data/repository/ListingRepositoryImpl.kt on lines 83..93
          app/src/main/java/com/studhub/app/data/repository/ListingRepositoryImpl.kt on lines 186..196

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 166.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Invalid

              override suspend fun getDraftListing(listingId: String): Flow<ApiResponse<Listing?>> = flow {
        emit(ApiResponse.Loading)

        try {
            val draftListing = localDb.getDraftListing(listingId)
          Severity: Major
          Found in app/src/main/java/com/studhub/app/data/repository/ListingRepositoryImpl.kt and 2 other locations - About 2 hrs to fix
          app/src/main/java/com/studhub/app/data/repository/ListingRepositoryImpl.kt on lines 71..81
          app/src/main/java/com/studhub/app/data/repository/ListingRepositoryImpl.kt on lines 186..196

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 166.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Invalid

              override suspend fun getUserDraftListings(user: User): Flow<ApiResponse<List<Listing>>> = flow {
        emit(ApiResponse.Loading)

        try {
            val drafts = localDb.getDraftListings(user)
          Severity: Major
          Found in app/src/main/java/com/studhub/app/data/repository/ListingRepositoryImpl.kt and 2 other locations - About 2 hrs to fix
          app/src/main/java/com/studhub/app/data/repository/ListingRepositoryImpl.kt on lines 71..81
          app/src/main/java/com/studhub/app/data/repository/ListingRepositoryImpl.kt on lines 83..93

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 166.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 9 locations. Consider refactoring.
          Invalid

                  if (query.isSuccessful) {
            emit(ApiResponse.Success(biddingListing))
        } else {
            val errorMessage = query.exception?.message.orEmpty()
            emit(ApiResponse.Failure(errorMessage.ifEmpty { "Firebase error" }))
          Severity: Major
          Found in app/src/main/java/com/studhub/app/data/repository/ListingRepositoryImpl.kt and 8 other locations - About 1 hr to fix
          app/src/main/java/com/studhub/app/data/repository/ConversationRepositoryImpl.kt on lines 109..114
          app/src/main/java/com/studhub/app/data/repository/ListingRepositoryImpl.kt on lines 275..280
          app/src/main/java/com/studhub/app/data/repository/ReportRepositoryImpl.kt on lines 30..35
          app/src/main/java/com/studhub/app/data/repository/UserRepositoryImpl.kt on lines 48..53
          app/src/main/java/com/studhub/app/data/repository/UserRepositoryImpl.kt on lines 289..294
          app/src/main/java/com/studhub/app/data/repository/UserRepositoryImpl.kt on lines 326..331
          app/src/main/java/com/studhub/app/data/repository/UserRepositoryImpl.kt on lines 383..388
          app/src/main/java/com/studhub/app/data/repository/UserRepositoryImpl.kt on lines 401..406

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 121.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 9 locations. Consider refactoring.
          Invalid

                  if (query.isSuccessful) {
            emit(ApiResponse.Success(listingToPush))
        } else {
            val errorMessage = query.exception?.message.orEmpty()
            emit(ApiResponse.Failure(errorMessage.ifEmpty { "Firebase error" }))
          Severity: Major
          Found in app/src/main/java/com/studhub/app/data/repository/ListingRepositoryImpl.kt and 8 other locations - About 1 hr to fix
          app/src/main/java/com/studhub/app/data/repository/ConversationRepositoryImpl.kt on lines 109..114
          app/src/main/java/com/studhub/app/data/repository/ListingRepositoryImpl.kt on lines 326..331
          app/src/main/java/com/studhub/app/data/repository/ReportRepositoryImpl.kt on lines 30..35
          app/src/main/java/com/studhub/app/data/repository/UserRepositoryImpl.kt on lines 48..53
          app/src/main/java/com/studhub/app/data/repository/UserRepositoryImpl.kt on lines 289..294
          app/src/main/java/com/studhub/app/data/repository/UserRepositoryImpl.kt on lines 326..331
          app/src/main/java/com/studhub/app/data/repository/UserRepositoryImpl.kt on lines 383..388
          app/src/main/java/com/studhub/app/data/repository/UserRepositoryImpl.kt on lines 401..406

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 121.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 3 locations. Consider refactoring.
          Invalid

                  if (query.isSuccessful) {
            emit(ApiResponse.Success(true))
        } else {
            val errorMessage = query.exception?.message.orEmpty()
            emit(ApiResponse.Failure(errorMessage.ifEmpty { "Firebase error" }))
          Severity: Major
          Found in app/src/main/java/com/studhub/app/data/repository/ListingRepositoryImpl.kt and 2 other locations - About 1 hr to fix
          app/src/main/java/com/studhub/app/data/repository/ReportRepositoryImpl.kt on lines 70..75
          app/src/main/java/com/studhub/app/data/repository/UserRepositoryImpl.kt on lines 418..423

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 121.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              override suspend fun getListingsBySearch(
        keyword: String,
        minPrice: String,
        maxPrice: String,
        chosenCategories: List<Category>,
          Severity: Major
          Found in app/src/main/java/com/studhub/app/data/repository/ListingRepositoryImpl.kt and 1 other location - About 1 hr to fix
          app/src/main/java/com/studhub/app/domain/repository/ListingRepository.kt on lines 63..69

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 92.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 6 locations. Consider refactoring.
          Invalid

          class ListingRepositoryImpl @Inject constructor(
    private val remoteDb: FirebaseDatabase,
    private val localDb: LocalDataSource,
    private val networkStatus: NetworkStatus
) : ListingRepository {
          Severity: Major
          Found in app/src/main/java/com/studhub/app/data/repository/ListingRepositoryImpl.kt and 5 other locations - About 35 mins to fix
          app/src/main/java/com/studhub/app/data/repository/CategoryRepositoryImpl.kt on lines 19..23
          app/src/main/java/com/studhub/app/data/repository/ConversationRepositoryImpl.kt on lines 28..32
          app/src/main/java/com/studhub/app/data/repository/UserRepositoryImpl.kt on lines 24..28
          app/src/main/java/com/studhub/app/domain/usecase/listing/GetListingsBySearch.kt on lines 20..24
          app/src/main/java/com/studhub/app/presentation/listing/browse/BrowseViewModel.kt on lines 18..22

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 63.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                          if (listing != null
                    && chosenCategories.isEmpty()
                    && (blockedUsers[listing.seller.id] != true)
          Severity: Minor
          Found in app/src/main/java/com/studhub/app/data/repository/ListingRepositoryImpl.kt and 1 other location - About 30 mins to fix
          app/src/main/java/com/studhub/app/data/repository/ListingRepositoryImpl.kt on lines 232..234

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 62.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                          } else if (listing != null
                    && chosenCategories.isNotEmpty()
                    && (blockedUsers[listing.seller.id] != true)
          Severity: Minor
          Found in app/src/main/java/com/studhub/app/data/repository/ListingRepositoryImpl.kt and 1 other location - About 30 mins to fix
          app/src/main/java/com/studhub/app/data/repository/ListingRepositoryImpl.kt on lines 223..225

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 62.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                              && (listing.name.contains(keyword, true)
                            || listing.description.contains(keyword, true))
          Severity: Minor
          Found in app/src/main/java/com/studhub/app/data/repository/ListingRepositoryImpl.kt and 1 other location - About 30 mins to fix
          app/src/main/java/com/studhub/app/data/repository/ListingRepositoryImpl.kt on lines 235..236

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 61.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                              && (listing.name.contains(keyword, true)
                            || listing.description.contains(keyword, true)
          Severity: Minor
          Found in app/src/main/java/com/studhub/app/data/repository/ListingRepositoryImpl.kt and 1 other location - About 30 mins to fix
          app/src/main/java/com/studhub/app/data/repository/ListingRepositoryImpl.kt on lines 226..227

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 61.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status