Sign upLogin

studhub-epfl/studhub-app

View on GitHub
Star
app/src/main/java/com/studhub/app/presentation/listing/add/CreateListingViewModel.kt

Summary

Maintainability
A
4 hrs
Test Coverage
A
93%

Method createListing has 9 arguments (exceeds 4 allowed). Consider refactoring.
Confirmed

        title: String,
        description: String,
        categories: List<Category>,
        price: Float,
        meetingPoint: MeetingPoint?,
Severity: Major
Found in app/src/main/java/com/studhub/app/presentation/listing/add/CreateListingViewModel.kt - About 1 hr to fix

    Method saveDraft has 9 arguments (exceeds 4 allowed). Consider refactoring.
    Confirmed

            title: String,
        description: String,
        categories: List<Category>,
        price: Float,
        meetingPoint: MeetingPoint?,
    Severity: Major
    Found in app/src/main/java/com/studhub/app/presentation/listing/add/CreateListingViewModel.kt - About 1 hr to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Invalid

          fun saveDraft(
        title: String,
        description: String,
        categories: List<Category>,
        price: Float,
      Severity: Major
      Found in app/src/main/java/com/studhub/app/presentation/listing/add/CreateListingViewModel.kt and 1 other location - About 2 hrs to fix
      app/src/main/java/com/studhub/app/presentation/listing/add/CreateListingViewModel.kt on lines 70..80

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 162.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Invalid

          fun createListing(
        title: String,
        description: String,
        categories: List<Category>,
        price: Float,
      Severity: Major
      Found in app/src/main/java/com/studhub/app/presentation/listing/add/CreateListingViewModel.kt and 1 other location - About 2 hrs to fix
      app/src/main/java/com/studhub/app/presentation/listing/add/CreateListingViewModel.kt on lines 108..118

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 162.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Invalid

              viewModelScope.launch {
            _createListing(listing).collect {
                when (it) {
                    is ApiResponse.Success -> {
                        callback(it.data.id)
      Severity: Major
      Found in app/src/main/java/com/studhub/app/presentation/listing/add/CreateListingViewModel.kt and 1 other location - About 1 hr to fix
      app/src/main/java/com/studhub/app/presentation/listing/add/CreateListingViewModel.kt on lines 132..144

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 135.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Invalid

              viewModelScope.launch {
            saveDraftListing(listing).collect {
                when (it) {
                    is ApiResponse.Success -> {
                        callback(it.data.id)
      Severity: Major
      Found in app/src/main/java/com/studhub/app/presentation/listing/add/CreateListingViewModel.kt and 1 other location - About 1 hr to fix
      app/src/main/java/com/studhub/app/presentation/listing/add/CreateListingViewModel.kt on lines 93..105

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 135.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          private fun fetchCategories() {
        viewModelScope.launch {
            getCategories().collect {
                when (it) {
                    is ApiResponse.Success -> _categories.value = it.data
      Severity: Major
      Found in app/src/main/java/com/studhub/app/presentation/listing/add/CreateListingViewModel.kt and 1 other location - About 1 hr to fix
      app/src/main/java/com/studhub/app/presentation/listing/browse/BrowseViewModel.kt on lines 33..44

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 134.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Invalid

      class CreateListingViewModel @Inject constructor(
    private val _createListing: CreateListing,
    private val saveDraftListing: SaveDraftListing,
    private val getDraftListing: GetDraftListing,
    private val getCategories: GetCategories
      Severity: Minor
      Found in app/src/main/java/com/studhub/app/presentation/listing/add/CreateListingViewModel.kt and 1 other location - About 50 mins to fix
      app/src/main/java/com/studhub/app/data/repository/AuthRepositoryImpl.kt on lines 23..28

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 78.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status