Sign upLogin

studhub-epfl/studhub-app

View on GitHub
Star

Showing 96 of 254 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

package com.studhub.app.domain.usecase.listing

import com.studhub.app.core.utils.ApiResponse
import com.studhub.app.domain.model.Listing
import com.studhub.app.domain.repository.ListingRepository
Severity: Major
Found in app/src/main/java/com/studhub/app/domain/usecase/listing/UpdateListingToBidding.kt and 1 other location - About 2 hrs to fix
app/src/main/java/com/studhub/app/domain/usecase/user/UpdateRating.kt on lines 1..14

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 149.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

package com.studhub.app.domain.usecase.user

import com.studhub.app.core.utils.ApiResponse
import com.studhub.app.domain.model.Rating
import com.studhub.app.domain.repository.UserRepository
Severity: Major
Found in app/src/main/java/com/studhub/app/domain/usecase/user/UpdateRating.kt and 1 other location - About 2 hrs to fix
app/src/main/java/com/studhub/app/domain/usecase/listing/UpdateListingToBidding.kt on lines 1..31

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 149.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method BrowseScreenListings has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

/**
 * Main content of the screen where all the listings are displayed as well as the search fields
 *
 * @param viewModel takes a BrowseViewModel to be used to interact with the database
 * @param navController needs to be given to allow navigation when clicking a specific listing
Severity: Minor
Found in app/src/main/java/com/studhub/app/presentation/listing/browse/BrowseScreen.kt - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    package com.studhub.app.domain.usecase.user

import com.studhub.app.core.utils.ApiResponse
import com.studhub.app.domain.model.Listing
import com.studhub.app.domain.repository.AuthRepository
    Severity: Major
    Found in app/src/main/java/com/studhub/app/domain/usecase/user/GetFavoriteListings.kt and 1 other location - About 1 hr to fix
    app/src/main/java/com/studhub/app/domain/usecase/user/GetBlockedUsers.kt on lines 1..28

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 137.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    package com.studhub.app.domain.usecase.user

import com.studhub.app.core.utils.ApiResponse
import com.studhub.app.domain.model.User
import com.studhub.app.domain.repository.AuthRepository
    Severity: Major
    Found in app/src/main/java/com/studhub/app/domain/usecase/user/GetBlockedUsers.kt and 1 other location - About 1 hr to fix
    app/src/main/java/com/studhub/app/domain/usecase/user/GetFavoriteListings.kt on lines 1..28

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 137.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        private fun fetchCategories() {
        viewModelScope.launch {
            getCategories().collect {
                when (it) {
                    is ApiResponse.Success -> _categories.value = it.data
    Severity: Major
    Found in app/src/main/java/com/studhub/app/presentation/listing/add/CreateListingViewModel.kt and 1 other location - About 1 hr to fix
    app/src/main/java/com/studhub/app/presentation/listing/browse/BrowseViewModel.kt on lines 33..44

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 134.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        private fun fetchCategories() {
        viewModelScope.launch {
            getCategories().collect {
                when (it) {
                    is ApiResponse.Success -> _categories.value = it.data
    Severity: Major
    Found in app/src/main/java/com/studhub/app/presentation/listing/browse/BrowseViewModel.kt and 1 other location - About 1 hr to fix
    app/src/main/java/com/studhub/app/presentation/listing/add/CreateListingViewModel.kt on lines 44..55

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 134.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

    package com.studhub.app.domain.usecase.user

import com.studhub.app.core.utils.ApiResponse
import com.studhub.app.domain.model.Rating
import com.studhub.app.domain.repository.UserRepository
    Severity: Major
    Found in app/src/main/java/com/studhub/app/domain/usecase/user/AddRating.kt and 2 other locations - About 1 hr to fix
    app/src/main/java/com/studhub/app/domain/usecase/listing/UpdateListing.kt on lines 1..32
    app/src/main/java/com/studhub/app/domain/usecase/user/DeleteRating.kt on lines 1..13

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 132.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

    package com.studhub.app.domain.usecase.user

import com.studhub.app.core.utils.ApiResponse
import com.studhub.app.domain.repository.UserRepository
import kotlinx.coroutines.flow.Flow
    Severity: Major
    Found in app/src/main/java/com/studhub/app/domain/usecase/user/DeleteRating.kt and 2 other locations - About 1 hr to fix
    app/src/main/java/com/studhub/app/domain/usecase/listing/UpdateListing.kt on lines 1..32
    app/src/main/java/com/studhub/app/domain/usecase/user/AddRating.kt on lines 1..14

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 132.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    package com.studhub.app.domain.usecase.user

import com.studhub.app.core.utils.ApiResponse
import com.studhub.app.domain.model.Rating
import com.studhub.app.domain.repository.UserRepository
    Severity: Major
    Found in app/src/main/java/com/studhub/app/domain/usecase/user/GetUserRatings.kt and 1 other location - About 1 hr to fix
    app/src/main/java/com/studhub/app/domain/usecase/conversation/GetConversationMessages.kt on lines 1..24

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 128.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    package com.studhub.app.domain.usecase.conversation

import com.studhub.app.core.utils.ApiResponse
import com.studhub.app.domain.model.Conversation
import com.studhub.app.domain.model.Message
    Severity: Major
    Found in app/src/main/java/com/studhub/app/domain/usecase/conversation/GetConversationMessages.kt and 1 other location - About 1 hr to fix
    app/src/main/java/com/studhub/app/domain/usecase/user/GetUserRatings.kt on lines 1..14

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 128.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method UserHeader has 40 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    @Composable
fun UserHeader(
    targetUser: State<ApiResponse<User>>,
    thumbsUpCount: Int,
    thumbsDownCount: Int,
    Severity: Minor
    Found in app/src/main/java/com/studhub/app/presentation/ratings/components/UserHeader.kt - About 1 hr to fix

      Method SignInContent has a Cognitive Complexity of 28 (exceeds 20 allowed). Consider refactoring.
      Open

      @Composable
@ExperimentalComposeUiApi
fun SignInContent(
    padding: PaddingValues,
    signIn: (email: String, password: String) -> Unit,
      Severity: Minor
      Found in app/src/main/java/com/studhub/app/presentation/auth/components/SignInContent.kt - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method BrowseScreenListings has a Cognitive Complexity of 28 (exceeds 20 allowed). Consider refactoring.
      Open

      /**
 * Main content of the screen where all the listings are displayed as well as the search fields
 *
 * @param viewModel takes a BrowseViewModel to be used to interact with the database
 * @param navController needs to be given to allow navigation when clicking a specific listing
      Severity: Minor
      Found in app/src/main/java/com/studhub/app/presentation/listing/browse/BrowseScreen.kt - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method RatingDialog has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      @Composable
fun RatingDialog(
    showDialog: Boolean,
    setShowDialog: () -> Unit,
    onSubmit: (Boolean, String) -> Unit,
      Severity: Minor
      Found in app/src/main/java/com/studhub/app/presentation/ratings/components/RatingDialog.kt - About 1 hr to fix

        Method handleSubmitRating has 38 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        fun handleSubmitRating(
    viewModel: IUserRatingViewModel,
    targetUserId: String,
    currentUser: State<ApiResponse<User>>,
    thumbUp: Boolean,
        Severity: Minor
        Found in app/src/main/java/com/studhub/app/presentation/ratings/components/handleSubmitRating.kt - About 1 hr to fix

          Method EditProfileForm has 37 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          @Composable
fun EditProfileForm(
    firstName: MutableState<String>,
    lastName: MutableState<String>,
    userName: MutableState<String>,
          Severity: Minor
          Found in app/src/main/java/com/studhub/app/presentation/profile/components/EditProfileForm.kt - About 1 hr to fix

            Method onBlockedClicked has a Cognitive Complexity of 27 (exceeds 20 allowed). Consider refactoring.
            Open

                override fun onBlockedClicked() {
        when (currentListing) {
            is ApiResponse.Success -> {
                val listing = (currentListing as ApiResponse.Success<Listing>).data
                viewModelScope.launch {
            Severity: Minor
            Found in app/src/main/java/com/studhub/app/presentation/listing/details/DetailedListingViewModel.kt - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method setupSearchBar has a Cognitive Complexity of 27 (exceeds 20 allowed). Consider refactoring.
            Open

                private fun setupSearchBar() {

        // Initialize the Places SDK
        if (!Places.isInitialized()) {
            Places.initialize(applicationContext, MAPS_API_KEY)
            Severity: Minor
            Found in app/src/main/java/com/studhub/app/MeetingPointPickerActivity.kt - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method invoke has 35 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                /**
     * Retrieves all listings matching the given [keyword] from the [repository]
     *
     * @param [keyword] the value to compare to the listings
     * @param [minPrice] the minimum Price in order to retrieve listings
            Severity: Minor
            Found in app/src/main/java/com/studhub/app/domain/usecase/listing/GetListingsBySearch.kt - About 1 hr to fix
              Severity
              Category
              Status
              Source
              Language