Sign upLogin

studioespresso/craft-seo-fields

View on GitHub
Star

Showing 1,008 of 1,021 total issues

Avoid using undefined variables such as '$variables' which will lead to PHP notices.
Open

        $variables['filename'] = $filePath;
Severity: Minor
Found in src/controllers/RedirectsController.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Avoid using undefined variables such as '$variables' which will lead to PHP notices.
Open

        $variables['headers'] = $headers;
Severity: Minor
Found in src/controllers/RedirectsController.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Avoid using undefined variables such as '$variables' which will lead to PHP notices.
Open

        $variables['sites'] = $this->getSitesMenu();
Severity: Minor
Found in src/controllers/RedirectsController.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Avoid using undefined variables such as '$variables' which will lead to PHP notices.
Open

        $variables['headers'] = $headers;
Severity: Minor
Found in src/controllers/RedirectsController.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Avoid using undefined variables such as '$variables' which will lead to PHP notices.
Open

            $variables['filename'] = $filePath;
Severity: Minor
Found in src/controllers/RedirectsController.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Avoid using undefined variables such as '$variables' which will lead to PHP notices.
Open

        $this->renderTemplate('seo-fields/_redirect/_import', $variables);
Severity: Minor
Found in src/controllers/RedirectsController.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Avoid using undefined variables such as '$variables' which will lead to PHP notices.
Open

            $variables['headers'] = $headers;
Severity: Minor
Found in src/controllers/RedirectsController.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Method getAlternate has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getAlternate($element = null)
    {
        if (!$element) {
            return false;
        }
Severity: Minor
Found in src/models/SeoFieldModel.php - About 1 hr to fix

    Method shouldRenderBySiteId has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function shouldRenderBySiteId(Site $site)
    {
        $data = SeoFields::$plugin->defaultsService->getRecordForSiteId($site->id);
        $sitemapSettings = Json::decode($data->sitemap);
        if (!$sitemapSettings) {
    Severity: Minor
    Found in src/services/SitemapService.php - About 1 hr to fix

      Function getSitesMenu has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          private function getSitesMenu()
    {
        $sites = [
            0 => Craft::t('seo-fields', 'All Sites'),
        ];
      Severity: Minor
      Found in src/controllers/RedirectsController.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method init has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function init()
    {
        parent::init();
        self::$plugin = $this;
      Severity: Minor
      Found in src/SeoFields.php - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    foreach ($afterEvents as $event) {
                Event::on(Elements::class, $event, function(ElementEvent $event) {
                    $shouldCheckSlug = true;
                    if (ElementHelper::isDraftOrRevision($event->element)) {
                        $shouldCheckSlug = false;
        Severity: Major
        Found in src/SeoFields.php and 1 other location - About 1 hr to fix
        src/SeoFields.php on lines 401..412

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 102.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    foreach ($beforeEvents as $event) {
                Event::on(Elements::class, $event, function(ElementEvent $event) {
                    $shouldCheckSlug = true;
                    if (ElementHelper::isDraftOrRevision($event->element)) {
                        $shouldCheckSlug = false;
        Severity: Major
        Found in src/SeoFields.php and 1 other location - About 1 hr to fix
        src/SeoFields.php on lines 414..425

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 102.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Method migrate has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function migrate($oldHandle = 'seo', $newHandle = 'newSeo', $siteId = null, $titleSeperator = null)
    {
        $this->titleSeperator = $titleSeperator;
        $query = Entry::find();
        $sites = [];
        Severity: Minor
        Found in src/services/migrate/Ether.php - About 1 hr to fix

          Function import has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              public function import($data, $settings)
    {
        App::maxPowerCaptain();
        $patternCol = $settings['patternCol'];
        $redirectCol = $settings['redirectCol'];
          Severity: Minor
          Found in src/services/RedirectService.php - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function getSeoFromContent has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              public function getSeoFromContent($context, $handle)
    {
        $meta = null;
        $element = null;
          Severity: Minor
          Found in src/services/RenderService.php - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid variables with short names like $to. Configured minimum length is 3.
          Open

                  $to = intval($page) === intval($lastPage) ? $total : ($page * $limit);
          Severity: Minor
          Found in src/controllers/CpApiController.php by phpmd

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

          Source https://phpmd.org/rules/naming.html#shortvariable

          The class m191114_201532_addRedirectsTable is not named in CamelCase.
          Open

          class m191114_201532_addRedirectsTable extends Migration
{
    /**
     * @inheritdoc
     */
          Severity: Minor
          Found in src/migrations/m191114_201532_addRedirectsTable.php by phpmd

          CamelCaseClassName

          Since: 0.2

          It is considered best practice to use the CamelCase notation to name classes.

          Example

          class class_name {
}

          Source

          Avoid variables with short names like $id. Configured minimum length is 3.
          Open

                  $id = $this->request->getBodyParam('id');
          Severity: Minor
          Found in src/controllers/NotFoundController.php by phpmd

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

          Source https://phpmd.org/rules/naming.html#shortvariable

          The class m231211_191728_addSchemaCol is not named in CamelCase.
          Open

          class m231211_191728_addSchemaCol extends Migration
{
    /**
     * @inheritdoc
     */
          Severity: Minor
          Found in src/migrations/m231211_191728_addSchemaCol.php by phpmd

          CamelCaseClassName

          Since: 0.2

          It is considered best practice to use the CamelCase notation to name classes.

          Example

          class class_name {
}

          Source

          Severity
          Category
          Status
          Source
          Language