substantial/updeep

View on GitHub

Showing 29 of 29 total issues

Function curry4 has a Cognitive Complexity of 49 (exceeds 5 allowed). Consider refactoring.
Open

export function curry4(fn) {
  return function curried(a, b, c, d, ...args) {
    const [e, f] = args
    const n = countArguments(arguments, 4)

Severity: Minor
Found in lib/util/curry.js - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    if (n === 3) {
      if (a === _) {
        if (b === _) return curry3((a, b, d, e, f) => fn(a, b, c, d, e, f))
        return curry2((a, d, e, f) => fn(a, b, c, d, e, f))
      }
Severity: Major
Found in lib/util/curry.js and 1 other location - About 4 hrs to fix
lib/util/curry.js on lines 89..96

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 123.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      if (a === _) {
        if (b === _) {
          if (c === _) return curry3((a, b, c, e, f) => fn(a, b, c, d, e, f))
          return curry2((a, b, e, f) => fn(a, b, c, d, e, f))
        }
Severity: Major
Found in lib/util/curry.js and 1 other location - About 4 hrs to fix
lib/util/curry.js on lines 105..112

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 123.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function curry3 has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

export function curry3(fn) {
  return function curried(a, b, c, ...args) {
    const [d, e] = args
    const n = countArguments(arguments, 3)

Severity: Minor
Found in lib/util/curry.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function curry4 has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function curry4(fn) {
  return function curried(a, b, c, d, ...args) {
    const [e, f] = args
    const n = countArguments(arguments, 4)

Severity: Minor
Found in lib/util/curry.js - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    function omit(predicate, collection) {
      const result = _omit(collection, predicate)
    
      const changed = collection == null || size(result) !== size(collection)
      if (changed) {
    Severity: Major
    Found in lib/omit.js and 1 other location - About 1 hr to fix
    lib/omitBy.js on lines 5..14

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 66.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    function omitBy(predicate, collection) {
      const result = _omitBy(collection, predicate)
    
      const changed = collection == null || size(result) !== size(collection)
      if (changed) {
    Severity: Major
    Found in lib/omitBy.js and 1 other location - About 1 hr to fix
    lib/omit.js on lines 5..14

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 66.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function curried has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      return function curried(a, b, c, d, ...args) {
        const [e, f] = args
        const n = countArguments(arguments, 4)
    
        if (d === _ || e === _ || f === _) {
    Severity: Minor
    Found in lib/util/curry.js - About 1 hr to fix

      Function curry2 has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

      export function curry2(fn) {
        return function curried(a, b, ...args) {
          const [c, d] = args
          const n = countArguments(arguments, 2)
      
      
      Severity: Minor
      Found in lib/util/curry.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            if (a === _) {
              if (b === _) return curry2((a, b, d, e) => fn(a, b, c, d, e))
              return curry1((a, d, e) => fn(a, b, c, d, e))
            }
      Severity: Major
      Found in lib/util/curry.js and 1 other location - About 1 hr to fix
      lib/util/curry.js on lines 66..69

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 55.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          if (n === 2) {
            if (a === _) return curry2((a, c, d, e) => fn(a, b, c, d, e))
            return curry1((c, d, e) => fn(a, b, c, d, e))
          }
      Severity: Major
      Found in lib/util/curry.js and 1 other location - About 1 hr to fix
      lib/util/curry.js on lines 58..61

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 55.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Avoid too many return statements within this function.
      Open

            return fn(a, b, c, d, e, f)
      Severity: Major
      Found in lib/util/curry.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

            return curried
        Severity: Major
        Found in lib/util/curry.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

              if (n === 1) return curry2((b, c, d, e) => fn(a, b, c, d, e))
          Severity: Major
          Found in lib/util/curry.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                return curried
            Severity: Major
            Found in lib/util/curry.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                    if (a === _) return curry2((a, c, d, e) => fn(a, b, c, d, e))
              Severity: Major
              Found in lib/util/curry.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                        if (b === _) return curry3((a, b, d, e, f) => fn(a, b, c, d, e, f))
                Severity: Major
                Found in lib/util/curry.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                        return curry1((d, e, f) => fn(a, b, c, d, e, f))
                  Severity: Major
                  Found in lib/util/curry.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                        if (n === 1) return curry3((b, c, d, e, f) => fn(a, b, c, d, e, f))
                    Severity: Major
                    Found in lib/util/curry.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                            return curry1((c, d, e) => fn(a, b, c, d, e))
                      Severity: Major
                      Found in lib/util/curry.js - About 30 mins to fix
                        Severity
                        Category
                        Status
                        Source
                        Language