Sign upLogin

suoto/hdl_checker

View on GitHub
Star
hdl_checker/diagnostics.py

Summary

Maintainability
C
1 day
Test Coverage

File diagnostics.py has 321 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# This file is part of HDL Checker.
#
# Copyright (c) 2015 - 2019 suoto (Andre Souto)
#
# HDL Checker is free software: you can redistribute it and/or modify
Severity: Minor
Found in hdl_checker/diagnostics.py - About 3 hrs to fix

    Function __init__ has 13 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def __init__(  # pylint: disable=too-many-arguments
    Severity: Major
    Found in hdl_checker/diagnostics.py - About 1 hr to fix

      Function __init__ has 8 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def __init__(  # pylint: disable=too-many-arguments
      Severity: Major
      Found in hdl_checker/diagnostics.py - About 1 hr to fix

        Function __init__ has 7 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def __init__(  # pylint: disable=too-many-arguments
        Severity: Major
        Found in hdl_checker/diagnostics.py - About 50 mins to fix

          Function __init__ has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def __init__(  # pylint: disable=too-many-arguments
          Severity: Minor
          Found in hdl_checker/diagnostics.py - About 45 mins to fix

            Function __init__ has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                def __init__(  # pylint: disable=too-many-arguments
            Severity: Minor
            Found in hdl_checker/diagnostics.py - About 45 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  @property
    def column_number(self):
        "Diagnostics column_number"
        if self._column is not None:
            return int(self._column)
              Severity: Minor
              Found in hdl_checker/diagnostics.py and 1 other location - About 55 mins to fix
              hdl_checker/diagnostics.py on lines 181..186

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 37.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  @property
    def line_number(self):
        "Diagnostics line number"
        if self._line_number is not None:
            return int(self._line_number)
              Severity: Minor
              Found in hdl_checker/diagnostics.py and 1 other location - About 55 mins to fix
              hdl_checker/diagnostics.py on lines 188..193

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 37.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status