superdesk/superdesk-client-core

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        it('can delete', inject((api, $httpBackend) => {
            var user = {_links: {self: {href: USER_PATH}}},
                then = jasmine.createSpy('then');

            $httpBackend.expectDELETE(USER_URL).respond(204);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

export function addInternalWebsocketEventListener<T extends keyof IInternalWebsocketMessages>(
    event: T,
    handler: (message: IInternalWebsocketMessages[T]) => void,
): () => void {
    const eventName = getInternalWebsocketMessageEventName(event);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        this.removeFromFirstHighlight = function(group, item) {
            var crtItem = this.getItem(group, item);

            crtItem.element(by.className('icon-multi-star')).click();
            var highlightList = element(by.className('highlights-list-menu'));

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        it('handles delete on deleted resource as success', inject((api, $httpBackend) => {
            var user = {_links: {self: {href: USER_PATH}}},
                then = jasmine.createSpy('then');

            $httpBackend.expectDELETE(USER_URL).respond(404);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

export function addWebsocketEventListener<T extends keyof IPublicWebsocketMessages>(
    event: T,
    handler: (message: IPublicWebsocketMessages[T]) => void,
): () => void {
    const eventName = getWebsocketMessageEventName(event);

• Read up
  Read up

Function render has 109 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    render() {
        const {items, markupV2} = this.props;
        const itemToOpenAfterSending: IArticle['_id'] | null = (() => {
            if (items.length !== 1) {
                return null;

File assetFilterPanel.tsx has 348 lines of code (exceeds 250 allowed). Consider refactoring.

Open

// External Modules
import * as React from 'react';
import {noop} from 'lodash';

// Types

File spellcheck.ts has 348 lines of code (exceeds 250 allowed). Consider refactoring.

Open

import {getSpellchecker} from 'core/editor3/components/spellchecker/default-spellcheckers';
import {gettext} from 'core/utils';
import {debounce, once} from 'lodash';
import {getStores, unsetStore} from '../editor3/store';
import {setAbbreviations} from 'core/editor3/actions';

Consider simplifying this complex logical expression.

Open

        if (activeCell == null) {
            return (
                <div
                    className={cx}
                    style={{

File get-multi-actions.tsx has 347 lines of code (exceeds 250 allowed). Consider refactoring.

Open

import _, {flatMap} from 'lodash';
import {IArticle} from 'superdesk-api';
import {gettext} from 'core/utils';

import {IExtensionActivationResult} from 'superdesk-api';

Function render has 108 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    render() {
        const {filters} = this.props;

        return (
            <React.Fragment>

Function connectCrudManagerHttp has 108 lines of code (exceeds 25 allowed). Consider refactoring.

Open

export function connectCrudManagerHttp<Props, Entity extends IBaseRestApiResponse>(
    // type stoped working after react 16.8 upgrade. See if it's fixed by a future React types or TypeScript update
    WrappedComponent, // : React.ComponentType<Props & PropsToConnect>
    name: string,
    endpoint: string,

Similar blocks of code found in 4 locations. Consider refactoring.

Open

                {
                    filters.airtime_time?.lte != null && (
                        <Tag
                            text={filters.airtime_time.lte}
                            label={gettext('Airtime time to')}

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

export const unsubscribeUser = (
    savedSearch: ISavedSearch,
    userId: IUser['_id'],
    api: any,
): Promise<ISavedSearch> => {

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

                {
                    filters.airtime_date?.lte != null && (
                        <Tag
                            text={filters.airtime_date.lte}
                            label={gettext('Airtime date to')}

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

export const unsubscribeDesk = (
    savedSearch: ISavedSearch,
    deskId: IDesk['_id'],
    api: any,
): Promise<ISavedSearch> => {

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

                {
                    filters.airtime_time?.gte != null && (
                        <Tag
                            text={filters.airtime_time.gte}
                            label={gettext('Airtime time from')}

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

                {
                    filters.airtime_date?.gte != null && (
                        <Tag
                            text={filters.airtime_date.gte}
                            label={gettext('Airtime date from')}

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

    onCheckboxClick(e: React.MouseEvent<HTMLDivElement>) {
        this.stopClickPropagation(e);
        if (e.shiftKey && this.props.updateMultipleSelectedAssetIds) {
            this.props.updateMultipleSelectedAssetIds(this.props.asset);
        } else if (this.props.updateSelectedAssetIds) {

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

    onCheckboxClick(e: React.MouseEvent<HTMLDivElement>) {
        this.stopClickPropagation(e);
        if (e.shiftKey && this.props.updateMultipleSelectedAssetIds) {
            this.props.updateMultipleSelectedAssetIds(this.props.asset);
        } else if (this.props.updateSelectedAssetIds) {

• Read up
  Read up