Sign upLogin

superdesk/superdesk-client-core

View on GitHub
Star

Showing 3,654 of 3,654 total issues

Function render has 107 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        render() {
            return (
                <Modal
                    visible
                    size="large"
Severity: Major
Found in scripts/extensions/markForUser/src/get-mark-for-user-modal.tsx - About 4 hrs to fix

    Function link has 107 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            link: function(scope, elem, attrs, ngModel) {
            scope.$on('package:addItems', (event, data) => {
                var groupIndex = _.findIndex(scope.list, {id: data.group});

                if (groupIndex === -1) {
    Severity: Major
    Found in scripts/apps/packaging/directives/PackageItemsEdit.ts - About 4 hrs to fix

      Function link has 107 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              link: function(scope: IScope) {
            /**
             * Populate scope actions when dropdown is opened.
             *
             * @param {boolean} isOpen
      Severity: Major
      Found in scripts/apps/monitoring/directives/ItemActionsMenu.ts - About 4 hrs to fix

        Function link has 107 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                        link: function(scope, elem, attrs, ctrl) {
                    let body = angular.element('body');

                    scope.currentRoute = null;
                    scope.flags = ctrl.flags;
        Severity: Major
        Found in scripts/core/menu/menu.ts - About 4 hrs to fix

          File UserActivityWidget.tsx has 344 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          import React from 'react';
import {IArticle, IUser, IStage} from 'superdesk-api';
import {AuthoringWorkspaceService} from 'apps/authoring/authoring/services';
import ng from 'core/services/ng';
import {gettext} from 'core/utils';
          Severity: Minor
          Found in scripts/apps/dashboard/user-activity/components/UserActivityWidget.tsx - About 4 hrs to fix

            Function constructor has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
            Open

                constructor($scope, $injector, $location, $q, $timeout, superdesk, session, api, desks, content,
        StagesCtrl, notify, multi, search) {
        super($scope, $location, search, desks);

        const setTotalCount = super.setTotalCount.bind(this);
            Severity: Minor
            Found in scripts/apps/archive/controllers/ArchiveListController.ts - About 4 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function MetaDropdownDirective has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
            Open

            function MetaDropdownDirective($filter, metadata) {
    return {
        scope: {
            list: '=',
            disabled: '=ngDisabled',
            Severity: Minor
            Found in scripts/apps/authoring/metadata/metadata.ts - About 4 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function render has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
            Open

                render() {
        const {item} = this.props;
        let classes = this.props.view === 'photogrid' ?
            'sd-grid-item sd-grid-item--with-click' :
            'media-box media-' + item.type;
            Severity: Minor
            Found in scripts/apps/search/components/Item.tsx - About 4 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                const initProductTypes = function() {
        if (angular.isDefined(metadata.values.product_types)) {
            $scope.product_types = $filter('sortByName')(metadata.values.product_types);
        } else {
            metadata.fetchMetadataValues().then(() => {
            Severity: Major
            Found in scripts/apps/products/controllers/ProductsConfigController.ts and 1 other location - About 4 hrs to fix
            scripts/apps/products/controllers/ProductsConfigController.ts on lines 93..101

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 120.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                const initRegions = function() {
        if (angular.isDefined(metadata.values.geographical_restrictions)) {
            $scope.geoRestrictions = $filter('sortByName')(metadata.values.geographical_restrictions);
        } else {
            metadata.fetchMetadataValues().then(() => {
            Severity: Major
            Found in scripts/apps/products/controllers/ProductsConfigController.ts and 1 other location - About 4 hrs to fix
            scripts/apps/products/controllers/ProductsConfigController.ts on lines 109..117

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 120.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            export function API(apiProvider) {
    apiProvider.api('users', {
        type: 'http',
        backend: {rel: 'users'},
    });
            Severity: Major
            Found in scripts/apps/users/config.ts and 1 other location - About 4 hrs to fix
            scripts/apps/ingest/index.ts on lines 190..207

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 120.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                .config(['apiProvider', function(apiProvider) {
        apiProvider.api('fetch', {
            type: 'http',
            backend: {rel: 'fetch'},
        });
            Severity: Major
            Found in scripts/apps/ingest/index.ts and 1 other location - About 4 hrs to fix
            scripts/apps/users/config.ts on lines 15..32

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 120.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                        function extendItem(itemId, updates) {
                scope.$apply(() => {
                    scope.items._items = scope.items._items.map((item) => {
                        if (item._id === itemId) {
                            return angular.extend(item, updates);
            Severity: Major
            Found in scripts/apps/monitoring/directives/MonitoringGroup.ts and 1 other location - About 4 hrs to fix
            scripts/apps/search/directives/SearchResults.ts on lines 319..331

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 120.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                        function extendItem(itemId, updates) {
                scope.$apply(() => {
                    scope.items._items = scope.items._items.map((item) => {
                        if (item._id === itemId) {
                            return angular.extend(item, updates);
            Severity: Major
            Found in scripts/apps/search/directives/SearchResults.ts and 1 other location - About 4 hrs to fix
            scripts/apps/monitoring/directives/MonitoringGroup.ts on lines 311..323

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 120.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function render has 106 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                render() {
        if (this.props.asset?._id == null) {
            return null;
        }
            Severity: Major
            Found in scripts/extensions/sams/src/components/assets/assetPreviewPanel.tsx - About 4 hrs to fix

              Function getArticleContentProfile has 106 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              export function getArticleContentProfile<T>(
    item: IArticle,
    fieldsAdapter: IFieldsAdapter<T>,
): Promise<IContentProfileV2> {
    interface IFakeScope {
              Severity: Major
              Found in scripts/apps/authoring-react/data-layer.ts - About 4 hrs to fix

                Function startApp has 105 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                export function startApp(
    extensions: Array<IExtensionLoader>,
    customUiComponents: IConfigurableUiComponents,
    customAlgorithms: IConfigurableAlgorithms = {},
) {
                Severity: Major
                Found in scripts/index.ts - About 4 hrs to fix

                  Function render has 105 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      render() {
        const statuses = Map<string, IVocabularyItem>(
            vocabulary.getVocabulary(STATUS_VOCABULARY_ID).items.map((item) => [item.qcode, item]),
        );
                  Severity: Major
                  Found in scripts/extensions/broadcasting/src/rundowns/components/rundown-items.tsx - About 4 hrs to fix

                    Function getAnnotationsLibraryPage has 105 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                    export function getAnnotationsLibraryPage(superdesk: ISuperdesk): React.ComponentType<IProps> {
    return class AnnotationsLibraryPage extends React.Component<IProps> {
        render() {
            const {gettext} = superdesk.localization;
            const {
                    Severity: Major
                    Found in scripts/extensions/annotationsLibrary/src/annotations-library-page.tsx - About 4 hrs to fix

                      Function IngestProviderService has 105 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                      export function IngestProviderService(api, $q, preferencesService, $filter, searchProviderService) {
    var _getAllIngestProviders = function(criteria = {}, page = 1, providers = []) {
        return api.query('ingest_providers', _.extend({max_results: 200, page: page}, criteria))
            .then((result) => {
                let pg = page;
                      Severity: Major
                      Found in scripts/apps/ingest/services/IngestProviderService.ts - About 4 hrs to fix
                        Severity
                        Category
                        Status
                        Source
                        Language