Sign upLogin

superdesk/superdesk-client-core

View on GitHub
Star

Showing 3,654 of 3,654 total issues

Function render has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
Open

    render() {
        const {additionalProps} = this.props;

        if (this.props.crudManager._items == null) {
            // loading
Severity: Minor
Found in scripts/core/ui/components/ListPage/generic-list-page.tsx - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function ReloadService has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
Open

function ReloadService($window, $rootScope, session, desks, superdeskFlags) {
    var self = this;

    self.userDesks = [];
    self.result = null;
Severity: Minor
Found in scripts/core/notification/notification.ts - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function PasswordStrength has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
Open

function PasswordStrength() {
    // styles holds each of the strength labels by index along with the class
    // to be added to the indicator.
    var styles = [
        {txt: gettext('Short'), cls: 'red'},
Severity: Minor
Found in scripts/core/directives/PasswordStrengthDirective.ts - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function constructor has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
Open

    constructor() {
        this.config = element(by.className('aggregate-settings'));
        this.label = element(by.model('widget.configuration.label'));

        this.openMonitoring = function() {
Severity: Minor
Found in e2e/client/specs/helpers/monitoring.ts - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function FilterSearchController has 102 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function FilterSearchController($scope, contentFilters, notify, $filter) {
    $scope.filterCondition = null;
    $scope.operatorLookup = {};
    $scope.valueLookup = {};
    $scope.valueFieldLookup = {};
Severity: Major
Found in scripts/apps/content-filters/controllers/FilterSearchController.ts - About 4 hrs to fix

    Function renderMenu has 102 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        renderMenu() {
        const item = this.props.item;

        const createAction = (activity) => ({
            label: activity.label,
    Severity: Major
    Found in scripts/apps/search/components/actions-menu/MenuItems.tsx - About 4 hrs to fix

      File TagService.ts has 336 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      import _ from 'lodash';
import {getParameters, getExcludeFacets} from 'apps/search/constants';
import {getDateFilters, getDateRangesByKey} from '../directives/DateFilters';
import {gettext} from 'core/utils';
      Severity: Minor
      Found in scripts/apps/search/services/TagService.ts - About 4 hrs to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                this.eventListenersToRemoveBeforeUnmounting.push(
            addWebsocketEventListener(
                'resource:created',
                (event) => {
                    const {resource, _id} = event.extra;
        Severity: Major
        Found in scripts/core/with-resources.tsx and 1 other location - About 4 hrs to fix
        scripts/core/with-resources.tsx on lines 79..90

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 116.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            render() {
        const key = JSON.stringify(omit(this.props, 'children'));

        return (
            <div>
        Severity: Major
        Found in scripts/core/with-resources.tsx and 1 other location - About 4 hrs to fix
        scripts/core/with-live-query.tsx on lines 180..198

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 116.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            it('configure a saved search that contain ingest items', () => {
        setupDeskMonitoringSettings('POLITIC DESK');

        monitoring.toggleDesk(0);
        monitoring.nextStages();
        Severity: Major
        Found in e2e/client/specs/monitoring_spec.ts and 1 other location - About 4 hrs to fix
        e2e/client/specs/monitoring_spec.ts on lines 100..112

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 116.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            it('configure a saved search and show it on monitoring view', () => {
        setupDeskMonitoringSettings('POLITIC DESK');
        monitoring.toggleDesk(0);
        monitoring.nextStages();
        monitoring.toggleGlobalSearch(0);
        Severity: Major
        Found in e2e/client/specs/monitoring_spec.ts and 1 other location - About 4 hrs to fix
        e2e/client/specs/monitoring_spec.ts on lines 217..230

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 116.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            render() {
        const key = JSON.stringify(omit(this.props, 'children'));

        return (
            <div>
        Severity: Major
        Found in scripts/core/with-live-query.tsx and 1 other location - About 4 hrs to fix
        scripts/core/with-resources.tsx on lines 236..254

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 116.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                this.eventListenersToRemoveBeforeUnmounting.push(
            addWebsocketEventListener(
                'resource:deleted',
                (event) => {
                    const {resource, _id} = event.extra;
        Severity: Major
        Found in scripts/core/with-resources.tsx and 1 other location - About 4 hrs to fix
        scripts/core/with-resources.tsx on lines 48..59

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 116.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function render has 101 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                render() {
            const {gettext} = superdesk.localization;
            const {
                getGenericHttpEntityListPageComponent,
                ListItem,
        Severity: Major
        Found in scripts/extensions/annotationsLibrary/src/annotations-library-page.tsx - About 4 hrs to fix

          Function render has 101 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              render() {
        const config = this.props.config ?? {};

        return (
            <Spacer v gap="16">
          Severity: Major
          Found in scripts/apps/authoring-react/fields/editor3/config.tsx - About 4 hrs to fix

            Function ItemPreview has 101 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            export function ItemPreview(asset, storage, desks, _, familyService, privileges) {
    /**
     * @description Closes the preview panel if the currently previewed
     * item is spiked / unspiked or moved.
     * @param {Object} scope - angular scope
            Severity: Major
            Found in scripts/apps/search/directives/ItemPreview.ts - About 4 hrs to fix

              Function registerExtensions has 101 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              export function registerExtensions(
    extensionLoaders: Array<IExtensionLoader>,
    superdesk,
    modal,
    privileges,
              Severity: Major
              Found in scripts/core/register-extensions.tsx - About 4 hrs to fix

                File api-service.spec.ts has 335 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                import {appConfig} from 'appConfig';
import {ISuperdeskGlobalConfig} from 'superdesk-api';
import _ from 'lodash';

function collection(data) {
                Severity: Minor
                Found in scripts/core/api/api-service.spec.ts - About 4 hrs to fix

                  Function render has 99 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      render() {
        const Container = this.props.container;
        const {readOnly} = this.props;

        const embedObj = this.props.value ?? {embed: '', description: ''};
                  Severity: Major
                  Found in scripts/apps/authoring-react/fields/embed/editor.tsx - About 3 hrs to fix

                    Function DatepickerInnerDirective has 99 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                    function DatepickerInnerDirective($compile, $document, popupService, datetimeHelper) {
    var popupTpl = '<div sd-datepicker-wrapper ng-model="date">' +
        '<div datepicker format-day="d" starting-day="' + appConfig.startingDay + '" show-weeks="false"></div>' +
    '</div>';
                    Severity: Major
                    Found in scripts/core/ui/ui.ts - About 3 hrs to fix
                      Severity
                      Category
                      Status
                      Source
                      Language