superdesk/superdesk-client-core

Similar blocks of code found in 2 locations. Consider refactoring.

Open

                    leftPanel={(
                        this.props.filterPanelOpen === false ? (
                            <div />
                        ) : (
                            <AssetFilterPanel

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

                    {this.props.original == null ? null : (
                        <PanelContentBlock flex={true}>
                            <PanelContentBlockInner grow={true}>
                                <VersionUserDateLines item={this.props.original} />
                            </PanelContentBlockInner>

• Read up
  Read up

Consider simplifying this complex logical expression.

Open

        } else if (isPublishedOrCorrected) {
            action.kill = userPrivileges.kill && lockedByMe && !isReadOnlyState;
            action.correct = userPrivileges.correct && lockedByMe && !isReadOnlyState
                && !isBeingCorrected(currentItem) && !isCorrection(currentItem);
            action.takedown = userPrivileges.takedown && lockedByMe && !isReadOnlyState;

Function componentDidUpdate has 58 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    componentDidUpdate(prevProps: IProps, prevState: IState) {
        if (prevState.fields != null && prevState.fields !== this.state.fields) {
            const editorCopy = {...this.state.editor};
            const schemaCopy = {...this.state.schema};

Function render has 58 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    render() {
        if (this.state.defaultTheme == null) {
            return null;
        }

Function AuthoringEmbeddedDirective has 58 lines of code (exceeds 25 allowed). Consider refactoring.

Open

export function AuthoringEmbeddedDirective(api, notify, $filter) {
    return {
        template: authoringReactViewEnabled
            ? (
                '<div>' +

Function getInitialDestination has 58 lines of code (exceeds 25 allowed). Consider refactoring.

Open

export function getInitialDestination(
    items: Array<IArticle>,
    canSendToPersonal: boolean,
    availableDesks: OrderedMap<string, IDesk> = sdApi.desks.getAllDesks(),
): ISendToDestination {

Function render has 58 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    render() {
        const {scope, monitoringState} = this.props;

        const style = scope.styleProperties == null
            ? null

Function render has 58 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    render() {
        const {
            target,
            onCancel,
            title,

Function render has 58 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    render() {
        return this.state.loading === false && (
            <ToggleBox title={gettext('Target')} initiallyOpen>
                <FormLabel text={gettext('Target subscribers')} />

Function render has 58 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    render() {
        const {value, label, labelKey, searchKey, valueKey, popupContainer, readOnly, onFocus, ...props} = this.props;
        const options = this.removeValuesFromOptions();

        return (

Function render has 58 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    render() {
        const {props} = this;
        const {getId, getLabel} = props;
        const optionTemplateDefault: React.ComponentType<{item: T}> = ({item}) => (<span>{getLabel(item)}</span>);
        const OptionTemplate = this.props.optionTemplate ?? optionTemplateDefault;

Function replaceWord has 58 lines of code (exceeds 25 allowed). Consider refactoring.

Open

export const replaceWord = (state, replaceWordData: IReplaceWordData, skipOnChange = false) => {
    const {editorState, suggestingMode} = state;

    const {word, newWord} = replaceWordData;

Identical blocks of code found in 2 locations. Consider refactoring.

Open

        browser.wait(() => element(by.id('ingest-settings')).isDisplayed(), 1000).then(() => {
            expect(element(by.id('ingest-settings')).isDisplayed()).toBe(true);
        });

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

        const globalMenuHorizontalItems = flatMap(
            Object.values(extensions).map(({activationResult}) => activationResult),
            (activationResult) =>
                activationResult.contributions != null
                && activationResult.contributions.globalMenuHorizontal != null

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    const articleDisplayWidgets = flatMap(
        Object.values(extensions).map(({activationResult}) => activationResult),
        (activationResult) =>
            activationResult.contributions != null
            && activationResult.contributions.articleGridItemWidgets != null

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

        browser.wait(() => element(by.id('ingest-settings')).isDisplayed(), 1000).then(() => {
            expect(element(by.id('ingest-settings')).isDisplayed()).toBe(true);
        });

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

        const articleDisplayWidgets = flatMap(
            Object.values(extensions).map(({activationResult}) => activationResult),
            (activationResult) =>
                activationResult.contributions != null
                && activationResult.contributions.articleListItemWidgets != null

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

                                    <SimpleListItem justify="space-between">
                                        <Switch value={this.state.value2} label={{content: 'My label'}} onChange={(value) => this.setState(() => ({value2: value}))} />
                                    </SimpleListItem>

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            {
                Array.isArray(fieldsRight) === true && fieldsRight.length > 0 ? (
                    <div className="sd-grid-item__footer-block sd-grid-item__footer-block--multi-r">
                        <PhotoDeskFields
                            fieldsConfig={fieldsRight}

• Read up
  Read up