Sign upLogin

superdesk/superdesk-client-core

View on GitHub
Star

Showing 3,654 of 3,654 total issues

Function AuthoringTopbarDirective has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

export function AuthoringTopbarDirective(
    TranslationService,
    privileges,
    authoringWorkspace: AuthoringWorkspaceService,
    $q,
Severity: Minor
Found in scripts/apps/authoring/authoring/directives/AuthoringTopbarDirective.ts - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function applyStyleSuggestion has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

function applyStyleSuggestion(editorState, type, style, data) {
    const selection = editorState.getSelection();
    let newEditorState = editorState;
    let tmpEditorState;
    let currentStyle;
Severity: Minor
Found in scripts/core/editor3/reducers/suggestions.tsx - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

export const StretchBar: React.StatelessComponent<any> = ({children, className, right}) => (
    <div
        className={classNames(
            'subnav__stretch-bar',
            {'subnav__stretch-bar--right': right},
Severity: Major
Found in scripts/core/ui/components/SubNav/StretchBar.tsx and 2 other locations - About 2 hrs to fix
scripts/core/ui/components/Form/RowItem.tsx on lines 10..20
scripts/core/ui/components/SidePanel/Content.tsx on lines 10..20

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 80.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

export const Content: React.StatelessComponent<any> = ({children, className, flex}) => (
    <div
        className={classNames(
            'side-panel__content',
            {'side-panel__content--flex': flex},
Severity: Major
Found in scripts/core/ui/components/SidePanel/Content.tsx and 2 other locations - About 2 hrs to fix
scripts/core/ui/components/Form/RowItem.tsx on lines 10..20
scripts/core/ui/components/SubNav/StretchBar.tsx on lines 10..20

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 80.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

export const RowItem: React.StatelessComponent<any> = ({children, noGrow, className}) => (
    <div
        className={classNames(
            'form__row-item',
            {'form__row-item--no-grow': noGrow},
Severity: Major
Found in scripts/core/ui/components/Form/RowItem.tsx and 2 other locations - About 2 hrs to fix
scripts/core/ui/components/SidePanel/Content.tsx on lines 10..20
scripts/core/ui/components/SubNav/StretchBar.tsx on lines 10..20

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 80.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        removeFilter(fieldName: string): Promise<IRestApiResponse<Entity>> {
            let nextFilters = {...this.state.activeFilters};

            delete nextFilters[fieldName];
Severity: Major
Found in scripts/core/helpers/crud-manager-http.tsx and 1 other location - About 2 hrs to fix
scripts/core/helpers/generic-array-list-page-component.tsx on lines 110..116

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 80.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

export const getSelectedSet = createSelector<
    IApplicationState,
    Dictionary<string, ISetItem>,
    string | undefined,
    ISetItem | undefined
Severity: Major
Found in scripts/extensions/sams/src/store/sets/selectors.ts and 1 other location - About 2 hrs to fix
scripts/extensions/sams/src/store/assets/selectors.ts on lines 86..98

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 80.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        const queryString = '?' + Object.keys(query).map((key) =>
            `${key}=${isObject(query[key]) ? JSON.stringify(query[key]) : encodeURIComponent(query[key])}`).join('&');
Severity: Major
Found in scripts/core/helpers/CrudManager.tsx and 1 other location - About 2 hrs to fix
scripts/core/utils.tsx on lines 379..381

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 80.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

export const getSelectedAsset = createSelector<
    IApplicationState,
    Dictionary<string, IAssetItem>,
    string | undefined,
    IAssetItem | undefined
Severity: Major
Found in scripts/extensions/sams/src/store/assets/selectors.ts and 1 other location - About 2 hrs to fix
scripts/extensions/sams/src/store/sets/selectors.ts on lines 76..88

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 80.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    removeFilter(fieldName: string): Promise<ICrudManagerData<T>> {
        let nextFilters = {...this.state.activeFilters};

        delete nextFilters[fieldName];
Severity: Major
Found in scripts/core/helpers/generic-array-list-page-component.tsx and 1 other location - About 2 hrs to fix
scripts/core/helpers/crud-manager-http.tsx on lines 117..123

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 80.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    return '?' + Object.keys(params).map((key) =>
        `${key}=${isObject(params[key]) ? JSON.stringify(params[key]) : encodeURIComponent(params[key])}`,
    ).join('&');
Severity: Major
Found in scripts/core/utils.tsx and 1 other location - About 2 hrs to fix
scripts/core/helpers/CrudManager.tsx on lines 249..250

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 80.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function toClientFormat has 56 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function toClientFormat(response: IServerResponse): OrderedMap<string, ITagUi> {
    let tags = OrderedMap<string, ITagUi>();

    response.subject?.forEach((item) => {
        const {name, description, qcode, source, altids, aliases, original_source, parent} = item;
Severity: Major
Found in scripts/extensions/auto-tagging-widget/src/adapter.ts - About 2 hrs to fix

    Function render has 56 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        render() {
        const {show} = this.props;

        return (
            <Modal
    Severity: Major
    Found in scripts/extensions/broadcasting/src/shows/create-show-after-modal.tsx - About 2 hrs to fix

      Function render has 56 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          render() {
        const Container = this.props.container;
        const linkedItems = (this.props.value ?? []);
        const linkedItemIds = linkedItems.map(({id}) => id);
        const {readOnly} = this.props;
      Severity: Major
      Found in scripts/apps/authoring-react/fields/linked-items/editor.tsx - About 2 hrs to fix

        Function getSubjectAdapter has 56 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        export function getSubjectAdapter(): IFieldAdapter<IArticle> {
    const getItems: () => ITreeWithLookup<ISubjectCode> = memoize(() => {
        const subjectCodes = store.getState().subjectCodes;

        return ({
        Severity: Major
        Found in scripts/apps/authoring-react/field-adapters/subject.tsx - About 2 hrs to fix

          Function save has 56 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                      scope.save = function() {
                var groups = [];

                _.each(scope.getValues(), (item, index) => {
                    if (item.selected && item.type !== 'desk') {
          Severity: Major
          Found in scripts/apps/monitoring/directives/AggregateSettings.ts - About 2 hrs to fix

            Function UserListDirective has 56 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            export function UserListDirective(keyboardManager, usersService, asset, session) {
    return {
        templateUrl: asset.templateUrl('apps/users/views/user-list-item.html'),
        scope: {
            roles: '=',
            Severity: Major
            Found in scripts/apps/users/directives/UserListDirective.ts - About 2 hrs to fix

              Function InlineCommentsCtrl has 56 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              function InlineCommentsCtrl($scope, userList, metadata, content) {
    getLabelNameResolver().then((getLabelForFieldId) => {
        $scope.resolvedFilter = 'RESOLVED';

        const editors = Object.keys($scope.item[META_FIELD_NAME])
              Severity: Major
              Found in scripts/apps/authoring/track-changes/inline-comments.ts - About 2 hrs to fix

                Function SearchController has 56 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                export function SearchController($location, searchProviderService) {
    const SUPERDESK = 'local';
    const INTERNAL = ['archive', 'published', 'ingest', 'archived'];
    const DEFAULT_CONFIG = Object.assign({}, {
        ingest: true,
                Severity: Major
                Found in scripts/apps/search/controllers/SearchController.ts - About 2 hrs to fix

                  Function getQuery has 56 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                              function getQuery() {
                var metas = [];
                var pattern = /[()]/g;

                angular.forEach(scope.meta, (val, key) => {
                  Severity: Major
                  Found in scripts/apps/search/directives/SearchParameters.ts - About 2 hrs to fix
                    Severity
                    Category
                    Status
                    Source
                    Language