superdesk/superdesk-client-core

View on GitHub

Showing 3,654 of 3,654 total issues

Function header has 56 lines of code (exceeds 25 allowed). Consider refactoring.
Open

                    const header = (itemsCount: number): JSX.Element => {
                        return (
                            <div data-test-id="articles-list--toolbar">
                                <SubNav zIndex={5}>
                                    <div className="space-between">
Severity: Major
Found in scripts/core/ArticlesListByQueryWithFilters.tsx - About 2 hrs to fix

    Function render has 56 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        render() {
            return (
                <SidePanel side="right" width={360} data-test-id="item-view-edit">
                    <SidePanelHeader>
                        <SidePanelHeading>{gettext('Details')}</SidePanelHeading>

      Function TimepickerPopupDirective has 56 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function TimepickerPopupDirective($timeout) {
          return {
              templateUrl: 'scripts/core/ui/views/sd-timepicker-popup.html',
              scope: {
                  open: '=',
      Severity: Major
      Found in scripts/core/ui/ui.ts - About 2 hrs to fix

        File toolbar.tsx has 260 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        import {RichUtils, EditorState, ContentState, SelectionState, convertToRaw, EntityInstance} from 'draft-js';
        import * as entityUtils from '../components/links/entityUtils';
        import {onChange} from './editor3';
        import * as Links from '../helpers/links';
        import * as Blocks from '../helpers/blocks';
        Severity: Minor
        Found in scripts/core/editor3/reducers/toolbar.tsx - About 2 hrs to fix

          Function bind has 56 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  this.bind = function bind(label, callback, opt) {
                      var fct, elt;
                      // Initialize options object
                      let options = angular.extend({}, defaultOpt, opt);
                      let lbl = label.toLowerCase();
          Severity: Major
          Found in scripts/core/keyboard/keyboard.ts - About 2 hrs to fix

            Function link has 56 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    link: function(scope) {
                        let canvas = document.getElementById('image') as HTMLCanvasElement,
                            context = canvas.getContext('2d'),
                            baseImage = new Image(),
                            filter = {
            Severity: Major
            Found in scripts/core/upload/sdImageModify.ts - About 2 hrs to fix

              Function render has 55 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                      render() {
                          const existingTags = getExistingTags(this.props.article);
                          const resClient = toClientFormat(existingTags);
                          const data = {original: {analysis: resClient}, changes: {analysis: resClient}};
              
              
              Severity: Major
              Found in scripts/extensions/auto-tagging-widget/src/header-auto-tagging.tsx - About 2 hrs to fix

                Function save has 55 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                                $scope.save = function() {
                                    _.forEach($scope.currentFeedingService.fields, (field) => {
                                        if (field.type !== 'mapping') {
                                            return;
                                        }
                Severity: Major
                Found in scripts/apps/ingest/directives/IngestSourcesContent.ts - About 2 hrs to fix

                  Function link has 55 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                          link: function(scope) {
                              getUser()
                                  .then(getPrivileges)
                                  .then(getUserRole);
                  
                  
                  Severity: Major
                  Found in scripts/apps/users/directives/UserPrivilegesDirective.ts - About 2 hrs to fix

                    Function render has 55 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                            render() {
                                return (
                                    <Modal
                                        visible
                                        zIndex={1050}

                      Function render has 55 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          render() {
                              const {authoringWorkspace} = this.props;
                              const listClassNames = 'sd-list-item__column sd-list-item__column--grow sd-list-item__column--no-border';
                      
                              return (
                      Severity: Major
                      Found in scripts/apps/authoring/translations/translationsWidget.tsx - About 2 hrs to fix

                        Function link has 55 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                                link: (scope) => {
                                    const setup = debounce(() => {
                                        const desk = desks.getCurrentDesk();
                                        const selected = document.getElementById('selected-desk');
                        
                        
                        Severity: Major
                        Found in scripts/apps/dashboard/closed-desk/index.ts - About 2 hrs to fix

                          Function render has 55 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              render() {
                                  const activity = this.props.activity;
                          
                                  const invoke = typeof activity.dropdown === 'function' || typeof activity.dropdown === 'object';
                          
                          
                          Severity: Major
                          Found in scripts/apps/search/components/actions-menu/Item.tsx - About 2 hrs to fix

                            Function render has 55 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                render() {
                                    const {
                                        style,
                                        title,
                                        children,
                            Severity: Major
                            Found in scripts/core/ui/components/ToggleBox/index.tsx - About 2 hrs to fix

                              Function queryElastic has 55 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                              export function queryElastic(
                                  parameters: IQueryElasticParameters,
                              ) {
                                  const {endpoint, page, sort, aggregations} = parameters;
                              
                              
                              Severity: Major
                              Found in scripts/core/helpers/CrudManager.tsx - About 2 hrs to fix

                                Similar blocks of code found in 3 locations. Consider refactoring.
                                Open

                                const extension: IExtension = {
                                    activate: () => {
                                        const result: IExtensionActivationResult = {
                                            contributions: {
                                                customFieldTypes: [
                                Severity: Major
                                Found in scripts/extensions/predefinedTextField/src/extension.tsx and 2 other locations - About 2 hrs to fix
                                scripts/extensions/booleanField/src/extension.tsx on lines 23..35
                                scripts/extensions/datetimeField/src/extension.tsx on lines 37..49

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 79.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Similar blocks of code found in 3 locations. Consider refactoring.
                                Open

                                const extension: IExtension = {
                                    activate: () => {
                                        const result: IExtensionActivationResult = {
                                            contributions: {
                                                customFieldTypes: [
                                Severity: Major
                                Found in scripts/extensions/booleanField/src/extension.tsx and 2 other locations - About 2 hrs to fix
                                scripts/extensions/datetimeField/src/extension.tsx on lines 37..49
                                scripts/extensions/predefinedTextField/src/extension.tsx on lines 20..32

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 79.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Similar blocks of code found in 3 locations. Consider refactoring.
                                Open

                                const extension: IExtension = {
                                    activate: () => {
                                        const result: IExtensionActivationResult = {
                                            contributions: {
                                                customFieldTypes: [
                                Severity: Major
                                Found in scripts/extensions/datetimeField/src/extension.tsx and 2 other locations - About 2 hrs to fix
                                scripts/extensions/booleanField/src/extension.tsx on lines 23..35
                                scripts/extensions/predefinedTextField/src/extension.tsx on lines 20..32

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 79.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Similar blocks of code found in 2 locations. Consider refactoring.
                                Open

                                        this.actionOnDeskSingleView = function() {
                                            var elem = element.all(by.className('stage-header__name'));
                                            var header = elem.all(by.css('[ng-click="viewSingleGroup(group, \'desk\')"]')).first();
                                
                                            header.click();
                                Severity: Major
                                Found in e2e/client/specs/helpers/monitoring.ts and 1 other location - About 2 hrs to fix
                                e2e/client/specs/helpers/monitoring.ts on lines 240..245

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 79.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Similar blocks of code found in 2 locations. Consider refactoring.
                                Open

                                        this.actionOnStageSingleView = function() {
                                            var elem = element.all(by.className('stage-header__name'));
                                            var subheader = elem.all(by.css('[ng-click="viewSingleGroup(group, \'stage\')"]')).first();
                                
                                            subheader.click();
                                Severity: Major
                                Found in e2e/client/specs/helpers/monitoring.ts and 1 other location - About 2 hrs to fix
                                e2e/client/specs/helpers/monitoring.ts on lines 227..232

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 79.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Severity
                                Category
                                Status
                                Source
                                Language