Showing 844 of 844 total issues
Function Suggestions
has 302 lines of code (exceeds 25 allowed). Consider refactoring. Open
Symphony.Interface.Suggestions = function() {
var context;
var options;
Field
has 80 functions (exceeds 20 allowed). Consider refactoring. Open
class Field implements ArrayAccess
{
/**
* The desired result when creating a field in the section editor
* @var integer
File content.blueprintssections.php
has 666 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
/**
* @package content
*/
File content.systemauthors.php
has 646 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
/**
* @package content
*/
File class.database.php
has 643 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
/**
* @package toolkit
*/
File field.upload.php
has 630 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
/**
* @package toolkit
*/
File content.blueprintspages.php
has 614 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
/**
* @package content
*/
File class.extensionmanager.php
has 606 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
/**
* @package toolkit
*/
File backend.views.js
has 604 lines of code (exceeds 250 allowed). Consider refactoring. Open
/**
* Symphony backend views
*
* @package assets
*/
Similar blocks of code found in 2 locations. Consider refactoring. Open
} elseif (array_key_exists('delete', $_POST['action'])) {
/**
* Prior to deleting the Event file. Target file path is provided.
*
* @delegate EventPreDelete
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 296.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
} elseif (is_array($_POST['action']) && array_key_exists('delete', $_POST['action'])) {
/**
* Prior to deleting the Datasource file. Target file path is provided.
*
* @delegate DatasourcePreDelete
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 296.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Function generate
has a Cognitive Complexity of 66 (exceeds 5 allowed). Consider refactoring. Open
public function generate(array &$param_pool = null)
{
$result = new XMLElement($this->dsParamROOTELEMENT);
$this->_param_pool = $param_pool;
$requiresPagination = (!isset($this->dsParamPAGINATERESULTS) ||
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method __form
has 256 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function __form($readonly = false)
{
$formHasErrors = (is_array($this->_errors) && !empty($this->_errors));
if ($formHasErrors) {
Method __form
has 239 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function __form()
{
// Handle unknown context
if (!in_array($this->_context['action'], array('new', 'edit'))) {
Administration::instance()->errorPageNotFound();
Database
has 65 functions (exceeds 20 allowed). Consider refactoring. Open
class Database
{
/**
* Constant to indicate whether the query is a write operation.
*
Method prepareAssociationsDrawer
has 234 lines of code (exceeds 25 allowed). Consider refactoring. Open
private function prepareAssociationsDrawer($section)
{
$entry_id = (!is_null($this->_context['entry_id'])) ? $this->_context['entry_id'] : null;
$show_entries = Symphony::Configuration()->get('association_maximum_rows', 'symphony');
File field.date.php
has 555 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
/**
* @package toolkit
*/
Method __formAction
has 233 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function __formAction()
{
$fields = $_POST['fields'];
$this->_errors = array();
$providers = Symphony::ExtensionManager()->getProvidersOf(iProvider::DATASOURCE);
Method __viewEdit
has 233 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function __viewEdit()
{
$this->setPageType('form');
$fields = array("title"=>null, "handle"=>null, "parent"=>null, "params"=>null, "type"=>null, "data_sources"=>null);
$existing = $fields;
Function install
has a Cognitive Complexity of 57 (exceeds 5 allowed). Consider refactoring. Open
private function install()
{
$db = null;
$fields = $this->extendDatabaseFields(self::$POST['fields']);
$start = time();
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"