Sign upLogin

symphonycms/symphony-2

View on GitHub
Star
symphony/content/content.blueprintssections.php

Summary

Maintainability
F
1 wk
Test Coverage

Function __actionNew has a Cognitive Complexity of 160 (exceeds 5 allowed). Consider refactoring.
Open

    public function __actionNew()
    {
        if (is_array($_POST['action']) && array_key_exists('save', $_POST['action'])) {
            $canProceed = true;
            $edit = ($this->_context['action'] === "edit");
Severity: Minor
Found in symphony/content/content.blueprintssections.php - About 3 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File content.blueprintssections.php has 666 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * @package content
 */
Severity: Major
Found in symphony/content/content.blueprintssections.php - About 1 day to fix

    Method __actionNew has 174 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function __actionNew()
    {
        if (is_array($_POST['action']) && array_key_exists('save', $_POST['action'])) {
            $canProceed = true;
            $edit = ($this->_context['action'] === "edit");
    Severity: Major
    Found in symphony/content/content.blueprintssections.php - About 6 hrs to fix

      Method __viewEdit has 170 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function __viewEdit()
    {
        $section_id = $this->_context['id'];
        $section = (new SectionManager)->select()->section($section_id)->execute()->next();
      Severity: Major
      Found in symphony/content/content.blueprintssections.php - About 6 hrs to fix

        Function __viewEdit has a Cognitive Complexity of 40 (exceeds 5 allowed). Consider refactoring.
        Open

            public function __viewEdit()
    {
        $section_id = $this->_context['id'];
        $section = (new SectionManager)->select()->section($section_id)->execute()->next();
        Severity: Minor
        Found in symphony/content/content.blueprintssections.php - About 6 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method __viewNew has 116 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function __viewNew()
    {
        $this->setPageType('form');
        $this->setTitle(__('%1$s &ndash; %2$s', array(__('Sections'), __('Symphony'))));
        $this->appendSubheading(__('Untitled'));
        Severity: Major
        Found in symphony/content/content.blueprintssections.php - About 4 hrs to fix

          Function __viewNew has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
          Open

              public function __viewNew()
    {
        $this->setPageType('form');
        $this->setTitle(__('%1$s &ndash; %2$s', array(__('Sections'), __('Symphony'))));
        $this->appendSubheading(__('Untitled'));
          Severity: Minor
          Found in symphony/content/content.blueprintssections.php - About 3 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method __viewIndex has 82 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function __viewIndex()
    {
        $this->setPageType('table');
        $this->setTitle(__('%1$s &ndash; %2$s', array(__('Sections'), __('Symphony'))));
        $this->appendSubheading(__('Sections'), Widget::Anchor(__('Create New'), Administration::instance()->getCurrentPageURL().'new/', __('Create a section'), 'create button', null, array('accesskey' => 'c')));
          Severity: Major
          Found in symphony/content/content.blueprintssections.php - About 3 hrs to fix

            Function __actionIndex has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
            Open

                public function __actionIndex()
    {
        $checked = (is_array($_POST['items'])) ? array_keys($_POST['items']) : null;

        if (is_array($checked) && !empty($checked)) {
            Severity: Minor
            Found in symphony/content/content.blueprintssections.php - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function __viewIndex has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
            Open

                public function __viewIndex()
    {
        $this->setPageType('table');
        $this->setTitle(__('%1$s &ndash; %2$s', array(__('Sections'), __('Symphony'))));
        $this->appendSubheading(__('Sections'), Widget::Anchor(__('Create New'), Administration::instance()->getCurrentPageURL().'new/', __('Create a section'), 'create button', null, array('accesskey' => 'c')));
            Severity: Minor
            Found in symphony/content/content.blueprintssections.php - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function validateTimestamp has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
            Open

                protected function validateTimestamp($section_id, $checkMissing = false)
    {
        if (!isset($_POST['action']['ignore-timestamp'])) {
            if ($checkMissing && !isset($_POST['action']['timestamp'])) {
                if (isset($this->_errors) && is_array($this->_errors)) {
            Severity: Minor
            Found in symphony/content/content.blueprintssections.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method __actionIndex has 38 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function __actionIndex()
    {
        $checked = (is_array($_POST['items'])) ? array_keys($_POST['items']) : null;

        if (is_array($checked) && !empty($checked)) {
            Severity: Minor
            Found in symphony/content/content.blueprintssections.php - About 1 hr to fix

              Avoid deeply nested control flow statements.
              Open

                                      if (is_array($fields) && !empty($fields)) {
                            foreach ($fields as $position => $data) {
                                if (isset($data['id'])) {
                                    $id_list[] = (int)$data['id'];
                                }
              Severity: Major
              Found in symphony/content/content.blueprintssections.php - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                                        if (is_array($missing_cfs) && !empty($missing_cfs)) {
                            foreach ($missing_cfs as $id) {
                                FieldManager::delete($id);
                            }
                        }
                Severity: Major
                Found in symphony/content/content.blueprintssections.php - About 45 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                                          if (!empty($id_list)) {
                            $missing_cfs->where(['id' => ['not in' => $id_list]]);
                        }
                  Severity: Major
                  Found in symphony/content/content.blueprintssections.php - About 45 mins to fix

                    Avoid deeply nested control flow statements.
                    Open

                                                if ($newField) {
                                $field->set('id', false);
                            }
                    Severity: Major
                    Found in symphony/content/content.blueprintssections.php - About 45 mins to fix

                      Avoid deeply nested control flow statements.
                      Open

                                                  if ($field_id) {
                                if ($newField) {
                                    /**
                                     * After creation of a Field.
                                     *
                      Severity: Major
                      Found in symphony/content/content.blueprintssections.php - About 45 mins to fix

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                            protected function validateTimestamp($section_id, $checkMissing = false)
    {
        if (!isset($_POST['action']['ignore-timestamp'])) {
            if ($checkMissing && !isset($_POST['action']['timestamp'])) {
                if (isset($this->_errors) && is_array($this->_errors)) {
                        Severity: Major
                        Found in symphony/content/content.blueprintssections.php and 1 other location - About 6 hrs to fix
                        symphony/content/content.publish.php on lines 2140..2159

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 209.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 3 locations. Consider refactoring.
                        Open

                                if ($formHasErrors) {
            $this->pageAlert(
                __('An error occurred while processing this form. See below for details.'),
                Alert::ERROR
            );
                        Severity: Major
                        Found in symphony/content/content.blueprintssections.php and 2 other locations - About 5 hrs to fix
                        symphony/content/content.blueprintsdatasources.php on lines 36..63
                        symphony/content/content.blueprintsevents.php on lines 40..67

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 189.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Identical blocks of code found in 2 locations. Consider refactoring.
                        Open

                                if (is_array($sections) && !empty($sections)) {
            $ul = new XMLElement('ul', null, array('class' => 'tags singular', 'data-interactive' => 'data-interactive'));
            $groups = array();

            foreach ($sections as $s) {
                        Severity: Major
                        Found in symphony/content/content.blueprintssections.php and 1 other location - About 3 hrs to fix
                        symphony/content/content.blueprintssections.php on lines 250..264

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 146.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Identical blocks of code found in 2 locations. Consider refactoring.
                        Open

                                if (is_array($sections) && !empty($sections)) {
            $ul = new XMLElement('ul', null, array('class' => 'tags singular', 'data-interactive' => 'data-interactive'));
            $groups = array();

            foreach ($sections as $s) {
                        Severity: Major
                        Found in symphony/content/content.blueprintssections.php and 1 other location - About 3 hrs to fix
                        symphony/content/content.blueprintssections.php on lines 469..483

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 146.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Identical blocks of code found in 2 locations. Consider refactoring.
                        Open

                                foreach ($types as $type) {
            $defaults = array();

            $type->findDefaults($defaults);
            $type->setArray($defaults);
                        Severity: Major
                        Found in symphony/content/content.blueprintssections.php and 1 other location - About 2 hrs to fix
                        symphony/content/content.blueprintssections.php on lines 309..323

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 126.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Identical blocks of code found in 2 locations. Consider refactoring.
                        Open

                                foreach ($types as $type) {
            $defaults = array();

            $type->findDefaults($defaults);
            $type->setArray($defaults);
                        Severity: Major
                        Found in symphony/content/content.blueprintssections.php and 1 other location - About 2 hrs to fix
                        symphony/content/content.blueprintssections.php on lines 525..540

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 126.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        There are no issues that match your filters.

                        Category
                        Status