Sign upLogin

symphonycms/symphony-2

View on GitHub
Star
symphony/content/content.systemauthors.php

Summary

Maintainability
F
1 wk
Test Coverage

Function __actionEdit has a Cognitive Complexity of 96 (exceeds 5 allowed). Consider refactoring.
Open

    public function __actionEdit()
    {
        if (!$author_id = $this->_context['id']) {
            redirect(SYMPHONY_URL . '/system/authors/');
        }
Severity: Minor
Found in symphony/content/content.systemauthors.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File content.systemauthors.php has 646 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 * @package content
 */
Severity: Major
Found in symphony/content/content.systemauthors.php - About 1 day to fix

    Method __form has 239 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function __form()
    {
        // Handle unknown context
        if (!in_array($this->_context['action'], array('new', 'edit'))) {
            Administration::instance()->errorPageNotFound();
    Severity: Major
    Found in symphony/content/content.systemauthors.php - About 1 day to fix

      Function __form has a Cognitive Complexity of 48 (exceeds 5 allowed). Consider refactoring.
      Open

          public function __form()
    {
        // Handle unknown context
        if (!in_array($this->_context['action'], array('new', 'edit'))) {
            Administration::instance()->errorPageNotFound();
      Severity: Minor
      Found in symphony/content/content.systemauthors.php - About 7 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method __actionEdit has 174 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function __actionEdit()
    {
        if (!$author_id = $this->_context['id']) {
            redirect(SYMPHONY_URL . '/system/authors/');
        }
      Severity: Major
      Found in symphony/content/content.systemauthors.php - About 6 hrs to fix

        Function __viewIndex has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
        Open

            public function __viewIndex()
    {
        $this->setPageType('table');
        $this->setTitle(__('%1$s &ndash; %2$s', array(__('Authors'), __('Symphony'))));
        Severity: Minor
        Found in symphony/content/content.systemauthors.php - About 5 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method __viewIndex has 117 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function __viewIndex()
    {
        $this->setPageType('table');
        $this->setTitle(__('%1$s &ndash; %2$s', array(__('Authors'), __('Symphony'))));
        Severity: Major
        Found in symphony/content/content.systemauthors.php - About 4 hrs to fix

          Function __actionNew has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
          Open

              public function __actionNew()
    {
        if (is_array($_POST['action']) && array_key_exists('save', $_POST['action'])) {
            $fields = $_POST['fields'];
            $canCreate = Symphony::Author()->isDeveloper() || Symphony::Author()->isManager();
          Severity: Minor
          Found in symphony/content/content.systemauthors.php - About 3 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method __actionNew has 63 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function __actionNew()
    {
        if (is_array($_POST['action']) && array_key_exists('save', $_POST['action'])) {
            $fields = $_POST['fields'];
            $canCreate = Symphony::Author()->isDeveloper() || Symphony::Author()->isManager();
          Severity: Major
          Found in symphony/content/content.systemauthors.php - About 2 hrs to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                public function parseContext(array &$context, array $parts)
    {
        // Order is important!
        $params = array_fill_keys(array('action', 'id', 'flag'), null);
            Severity: Major
            Found in symphony/content/content.systemauthors.php and 1 other location - About 4 hrs to fix
            symphony/content/content.blueprintspages.php on lines 25..37

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 174.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                            if (!$isOwner) {
                    $entered_password = $fields['confirm-change-password'];

                    if (!isset($fields['confirm-change-password']) || empty($fields['confirm-change-password'])) {
                        $this->_errors['confirm-change-password'] = __('Please provide your own password to make changes to this author.');
            Severity: Major
            Found in symphony/content/content.systemauthors.php and 1 other location - About 1 hr to fix
            symphony/content/content.systemauthors.php on lines 976..984

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 112.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                        if (!$isOwner) {
                $entered_password = $fields['confirm-change-password'];

                if (!isset($fields['confirm-change-password']) || empty($fields['confirm-change-password'])) {
                    $this->_errors['confirm-change-password'] = __('Please provide your own password to make changes to this author.');
            Severity: Major
            Found in symphony/content/content.systemauthors.php and 1 other location - About 1 hr to fix
            symphony/content/content.systemauthors.php on lines 880..888

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 112.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status