Sign upLogin

symphonycms/symphony-2

View on GitHub
Star
symphony/lib/toolkit/class.database.php

Summary

Maintainability
F
4 days
Test Coverage

File class.database.php has 643 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 * @package toolkit
 */
Severity: Major
Found in symphony/lib/toolkit/class.database.php - About 1 day to fix

    Database has 65 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class Database
{
    /**
     * Constant to indicate whether the query is a write operation.
     *
    Severity: Major
    Found in symphony/lib/toolkit/class.database.php - About 1 day to fix

      Method query has 59 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function query($query, $type = "OBJECT")
    {
        General::ensureType([
            'query' => ['var' => $query, 'type' => 'string'],
            'type' => ['var' => $type, 'type' => 'string'],
      Severity: Major
      Found in symphony/lib/toolkit/class.database.php - About 2 hrs to fix

        Consider simplifying this complex logical expression.
        Open

                if (
            strpos($query, '\'--') !== false || strpos($query, '\';--') !== false ||
            strpos($query, '\' --') !== false || strpos($query, '\'/*') !== false
        ) {
            throw (new DatabaseStatementException('Query contains SQL injection.'))->sql($query);
        Severity: Critical
        Found in symphony/lib/toolkit/class.database.php - About 2 hrs to fix

          Function query has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
          Open

              public function query($query, $type = "OBJECT")
    {
        General::ensureType([
            'query' => ['var' => $query, 'type' => 'string'],
            'type' => ['var' => $type, 'type' => 'string'],
          Severity: Minor
          Found in symphony/lib/toolkit/class.database.php - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method execute has 37 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function execute(DatabaseStatement $stm)
    {
        $this->autoConnect();

        if ($this->isLoggingEnabled()) {
          Severity: Minor
          Found in symphony/lib/toolkit/class.database.php - About 1 hr to fix

            Method throwDatabaseError has 33 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                private function throwDatabaseError(Exception $ex = null)
    {
        if (isset($ex) && $ex) {
            $msg = $ex->getMessage();
            $errornum = (int)$ex->getCode();
            Severity: Minor
            Found in symphony/lib/toolkit/class.database.php - About 1 hr to fix

              Function validateSQLQuery has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

                  final public function validateSQLQuery($query, $strict = true)
    {
        if (
            strpos($query, '\'--') !== false || strpos($query, '\';--') !== false ||
            strpos($query, '\' --') !== false || strpos($query, '\'/*') !== false
              Severity: Minor
              Found in symphony/lib/toolkit/class.database.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function execute has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function execute(DatabaseStatement $stm)
    {
        $this->autoConnect();

        if ($this->isLoggingEnabled()) {
              Severity: Minor
              Found in symphony/lib/toolkit/class.database.php - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Avoid too many return statements within this method.
              Open

                      return PDO::PARAM_STR;
              Severity: Major
              Found in symphony/lib/toolkit/class.database.php - About 30 mins to fix

                Function fetch has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function fetch($query = null, $index_by_column = null)
    {
        if (!is_null($query)) {
            $this->query($query, "ASSOC");
        } elseif (is_null($this->_lastResult)) {
                Severity: Minor
                Found in symphony/lib/toolkit/class.database.php - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function quoteFields has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function quoteFields(array &$array)
    {
        foreach ($array as $key => $val) {
            // Handle arrays with more than 1 level
            if (is_array($val)) {
                Severity: Minor
                Found in symphony/lib/toolkit/class.database.php - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    public function insert($table, ...$oldParams)
    {
        // Compat layer
        if (is_array($table)) {
            if (isset($oldParams[0]) && isset($oldParams[1])) {
                Severity: Minor
                Found in symphony/lib/toolkit/class.database.php and 1 other location - About 50 mins to fix
                symphony/lib/toolkit/class.database.php on lines 679..689

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 97.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    public function update($table, ...$oldParams)
    {
        // Compat layer
        if (is_array($table)) {
            if (isset($oldParams[0]) && isset($oldParams[1])) {
                Severity: Minor
                Found in symphony/lib/toolkit/class.database.php and 1 other location - About 50 mins to fix
                symphony/lib/toolkit/class.database.php on lines 641..651

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 97.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status