Sign upLogin

symphonycms/symphony-2

View on GitHub
Star
symphony/lib/toolkit/class.resourcespage.php

Summary

Maintainability
F
4 days
Test Coverage

Function __actionIndex has a Cognitive Complexity of 77 (exceeds 5 allowed). Consider refactoring.
Open

    public function __actionIndex($resource_type)
    {
        $manager = ResourceManager::getManagerFromType($resource_type);
        $resource_name = str_replace('Manager', '', $manager);
        $delegate_path = strtolower($resource_name);
Severity: Minor
Found in symphony/lib/toolkit/class.resourcespage.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method __viewIndex has 159 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function __viewIndex($resource_type)
    {
        $manager = ResourceManager::getManagerFromType($resource_type);
        $friendly_resource = ($resource_type === ResourceManager::RESOURCE_TYPE_EVENT) ? __('Event') : __('DataSource');
        $context = Administration::instance()->getPageCallback();
Severity: Major
Found in symphony/lib/toolkit/class.resourcespage.php - About 6 hrs to fix

    Function __viewIndex has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
    Open

        public function __viewIndex($resource_type)
    {
        $manager = ResourceManager::getManagerFromType($resource_type);
        $friendly_resource = ($resource_type === ResourceManager::RESOURCE_TYPE_EVENT) ? __('Event') : __('DataSource');
        $context = Administration::instance()->getPageCallback();
    Severity: Minor
    Found in symphony/lib/toolkit/class.resourcespage.php - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method __actionIndex has 84 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function __actionIndex($resource_type)
    {
        $manager = ResourceManager::getManagerFromType($resource_type);
        $resource_name = str_replace('Manager', '', $manager);
        $delegate_path = strtolower($resource_name);
    Severity: Major
    Found in symphony/lib/toolkit/class.resourcespage.php - About 3 hrs to fix

      File class.resourcespage.php has 302 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      <?php

/**
 * @package toolkit
 */
      Severity: Minor
      Found in symphony/lib/toolkit/class.resourcespage.php - About 3 hrs to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                            if (isset($r['author']['website'])) {
                        $author = Widget::Anchor($r['author']['name'], General::validateURL($r['author']['website']));
                    } elseif (isset($r['author']['email'])) {
                        $author = Widget::Anchor($r['author']['name'], 'mailto:' . $r['author']['email']);
                    }
        Severity: Major
        Found in symphony/lib/toolkit/class.resourcespage.php and 1 other location - About 1 hr to fix
        symphony/content/content.blueprintsdatasources.php on lines 1034..1038

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 106.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            protected function getTemplate($name)
    {
        $format = '%s/%s.tpl';

        if (file_exists($template = sprintf($format, WORKSPACE . '/template', $name))) {
        Severity: Minor
        Found in symphony/lib/toolkit/class.resourcespage.php and 1 other location - About 50 mins to fix
        symphony/lib/toolkit/class.pagemanager.php on lines 130..141

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 97.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status