Sign upLogin

symphonycms/symphony-2

View on GitHub
Star
symphony/lib/toolkit/email-gateways/email.smtp.php

Summary

Maintainability
C
1 day
Test Coverage

Method send has 67 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function send()
    {
        $this->validate();

        $settings = array();
Severity: Major
Found in symphony/lib/toolkit/email-gateways/email.smtp.php - About 2 hrs to fix

    Method getPreferencesPane has 67 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function getPreferencesPane()
    {
        parent::getPreferencesPane();
        $group = new XMLElement('fieldset');
        $group->setAttribute('class', 'settings condensed pickable');
    Severity: Major
    Found in symphony/lib/toolkit/email-gateways/email.smtp.php - About 2 hrs to fix

      File email.smtp.php has 259 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      <?php
/**
 * @package email-gateways
 */
      Severity: Minor
      Found in symphony/lib/toolkit/email-gateways/email.smtp.php - About 2 hrs to fix

        Function send has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

            public function send()
    {
        $this->validate();

        $settings = array();
        Severity: Minor
        Found in symphony/lib/toolkit/email-gateways/email.smtp.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status