Sign upLogin

symphonycms/symphony-2

View on GitHub
Star
symphony/lib/toolkit/fields/field.author.php

Summary

Maintainability
F
3 days
Test Coverage

File field.author.php has 473 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 * @package toolkit
 */
Severity: Minor
Found in symphony/lib/toolkit/fields/field.author.php - About 7 hrs to fix

    Method buildDSRetrievalSQL has 100 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function buildDSRetrievalSQL($data, &$joins, &$where, $andOperation = false)
    {
        if (Symphony::Log()) {
            Symphony::Log()->pushDeprecateWarningToLog(
                get_called_class() . '::buildDSRetrievalSQL()',
    Severity: Major
    Found in symphony/lib/toolkit/fields/field.author.php - About 4 hrs to fix

      FieldAuthor has 28 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class FieldAuthor extends Field implements ExportableField
{
    public function __construct()
    {
        parent::__construct();
      Severity: Minor
      Found in symphony/lib/toolkit/fields/field.author.php - About 3 hrs to fix

        Function buildDSRetrievalSQL has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
        Open

            public function buildDSRetrievalSQL($data, &$joins, &$where, $andOperation = false)
    {
        if (Symphony::Log()) {
            Symphony::Log()->pushDeprecateWarningToLog(
                get_called_class() . '::buildDSRetrievalSQL()',
        Severity: Minor
        Found in symphony/lib/toolkit/fields/field.author.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function displayPublishPanel has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
        Open

            public function displayPublishPanel(XMLElement &$wrapper, $data = null, $flagWithError = null, $fieldnamePrefix = null, $fieldnamePostfix = null, $entry_id = null)
    {
        $value = isset($data['author_id']) ? $data['author_id'] : null;

        if ($this->get('default_to_current_user') === 'yes' && empty($data) && empty($_POST)) {
        Severity: Minor
        Found in symphony/lib/toolkit/fields/field.author.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method displayPublishPanel has 46 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function displayPublishPanel(XMLElement &$wrapper, $data = null, $flagWithError = null, $fieldnamePrefix = null, $fieldnamePostfix = null, $entry_id = null)
    {
        $value = isset($data['author_id']) ? $data['author_id'] : null;

        if ($this->get('default_to_current_user') === 'yes' && empty($data) && empty($_POST)) {
        Severity: Minor
        Found in symphony/lib/toolkit/fields/field.author.php - About 1 hr to fix

          Function prepareExportValue has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
          Open

              public function prepareExportValue($data, $mode, $entry_id = null)
    {
        $modes = (object)$this->getExportModes();

        // Make sure we have an array to work with:
          Severity: Minor
          Found in symphony/lib/toolkit/fields/field.author.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method prepareExportValue has 28 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function prepareExportValue($data, $mode, $entry_id = null)
    {
        $modes = (object)$this->getExportModes();

        // Make sure we have an array to work with:
          Severity: Minor
          Found in symphony/lib/toolkit/fields/field.author.php - About 1 hr to fix

            Function groupRecords has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                public function groupRecords($records)
    {
        if (!is_array($records) || empty($records)) {
            return;
        }
            Severity: Minor
            Found in symphony/lib/toolkit/fields/field.author.php - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method displayPublishPanel has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                public function displayPublishPanel(XMLElement &$wrapper, $data = null, $flagWithError = null, $fieldnamePrefix = null, $fieldnamePostfix = null, $entry_id = null)
            Severity: Minor
            Found in symphony/lib/toolkit/fields/field.author.php - About 45 mins to fix

              Method processRawFieldData has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  public function processRawFieldData($data, &$status, &$message = null, $simulate = false, $entry_id = null)
              Severity: Minor
              Found in symphony/lib/toolkit/fields/field.author.php - About 35 mins to fix

                Method appendFormattedElement has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    public function appendFormattedElement(XMLElement &$wrapper, $data, $encode = false, $mode = null, $entry_id = null)
                Severity: Minor
                Found in symphony/lib/toolkit/fields/field.author.php - About 35 mins to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      public function buildSortingSQL(&$joins, &$where, &$sort, $order = 'ASC')
    {
        if (Symphony::Log()) {
            Symphony::Log()->pushDeprecateWarningToLog(
                get_called_class() . '::buildSortingSQL()',
                  Severity: Major
                  Found in symphony/lib/toolkit/fields/field.author.php and 1 other location - About 1 hr to fix
                  symphony/lib/toolkit/class.field.php on lines 1724..1738

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 114.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status