Sign upLogin

symphonycms/symphony-2

View on GitHub
Star
symphony/lib/toolkit/fields/field.upload.php

Summary

Maintainability
F
6 days
Test Coverage

File field.upload.php has 630 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 * @package toolkit
 */
Severity: Major
Found in symphony/lib/toolkit/fields/field.upload.php - About 1 day to fix

    Function processRawFieldData has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
    Open

        public function processRawFieldData($data, &$status, &$message = null, $simulate = false, $entry_id = null)
    {
        $status = self::__OK__;

        // No file given, save empty data:
    Severity: Minor
    Found in symphony/lib/toolkit/fields/field.upload.php - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method processRawFieldData has 101 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function processRawFieldData($data, &$status, &$message = null, $simulate = false, $entry_id = null)
    {
        $status = self::__OK__;

        // No file given, save empty data:
    Severity: Major
    Found in symphony/lib/toolkit/fields/field.upload.php - About 4 hrs to fix

      FieldUpload has 29 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class FieldUpload extends Field implements ExportableField, ImportableField
{
    protected static $imageMimeTypes = array(
        'image/gif',
        'image/jpg',
      Severity: Minor
      Found in symphony/lib/toolkit/fields/field.upload.php - About 3 hrs to fix

        Function checkPostFieldData has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
        Open

            public function checkPostFieldData($data, &$message, $entry_id = null)
    {
        /**
         * For information about PHPs upload error constants see:
         * @link http://php.net/manual/en/features.file-upload.errors.php
        Severity: Minor
        Found in symphony/lib/toolkit/fields/field.upload.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method checkPostFieldData has 59 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function checkPostFieldData($data, &$message, $entry_id = null)
    {
        /**
         * For information about PHPs upload error constants see:
         * @link http://php.net/manual/en/features.file-upload.errors.php
        Severity: Major
        Found in symphony/lib/toolkit/fields/field.upload.php - About 2 hrs to fix

          Method buildDSRetrievalSQL has 52 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function buildDSRetrievalSQL($data, &$joins, &$where, $andOperation = false)
    {
        if (Symphony::Log()) {
            Symphony::Log()->pushDeprecateWarningToLog(
                get_called_class() . '::buildDSRetrievalSQL()',
          Severity: Major
          Found in symphony/lib/toolkit/fields/field.upload.php - About 2 hrs to fix

            Function buildDSRetrievalSQL has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
            Open

                public function buildDSRetrievalSQL($data, &$joins, &$where, $andOperation = false)
    {
        if (Symphony::Log()) {
            Symphony::Log()->pushDeprecateWarningToLog(
                get_called_class() . '::buildDSRetrievalSQL()',
            Severity: Minor
            Found in symphony/lib/toolkit/fields/field.upload.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method fetchFilterableOperators has 41 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function fetchFilterableOperators()
    {
        return array(
            array(
                'title' => 'is',
            Severity: Minor
            Found in symphony/lib/toolkit/fields/field.upload.php - About 1 hr to fix

              Method displayPublishPanel has 34 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function displayPublishPanel(XMLElement &$wrapper, $data = null, $flagWithError = null, $fieldnamePrefix = null, $fieldnamePostfix = null, $entry_id = null)
    {
        if (is_dir(DOCROOT . $this->get('destination') . '/') === false) {
            $flagWithError = __('The destination directory, %s, does not exist.', array(
                '<code>' . $this->get('destination') . '</code>'
              Severity: Minor
              Found in symphony/lib/toolkit/fields/field.upload.php - About 1 hr to fix

                Method createTable has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function createTable()
    {
        return Symphony::Database()
            ->create('tbl_entries_data_' . General::intval($this->get('id')))
            ->ifNotExists()
                Severity: Minor
                Found in symphony/lib/toolkit/fields/field.upload.php - About 1 hr to fix

                  Function displayPublishPanel has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function displayPublishPanel(XMLElement &$wrapper, $data = null, $flagWithError = null, $fieldnamePrefix = null, $fieldnamePostfix = null, $entry_id = null)
    {
        if (is_dir(DOCROOT . $this->get('destination') . '/') === false) {
            $flagWithError = __('The destination directory, %s, does not exist.', array(
                '<code>' . $this->get('destination') . '</code>'
                  Severity: Minor
                  Found in symphony/lib/toolkit/fields/field.upload.php - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method displaySettingsPanel has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function displaySettingsPanel(XMLElement &$wrapper, $errors = null)
    {
        parent::displaySettingsPanel($wrapper, $errors);

        // Destination Folder
                  Severity: Minor
                  Found in symphony/lib/toolkit/fields/field.upload.php - About 1 hr to fix

                    Function displaySettingsPanel has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function displaySettingsPanel(XMLElement &$wrapper, $errors = null)
    {
        parent::displaySettingsPanel($wrapper, $errors);

        // Destination Folder
                    Severity: Minor
                    Found in symphony/lib/toolkit/fields/field.upload.php - About 55 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method displayPublishPanel has 6 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        public function displayPublishPanel(XMLElement &$wrapper, $data = null, $flagWithError = null, $fieldnamePrefix = null, $fieldnamePostfix = null, $entry_id = null)
                    Severity: Minor
                    Found in symphony/lib/toolkit/fields/field.upload.php - About 45 mins to fix

                      Method appendFormattedElement has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                          public function appendFormattedElement(XMLElement &$wrapper, $data, $encode = false, $mode = null, $entry_id = null)
                      Severity: Minor
                      Found in symphony/lib/toolkit/fields/field.upload.php - About 35 mins to fix

                        Method processRawFieldData has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                            public function processRawFieldData($data, &$status, &$message = null, $simulate = false, $entry_id = null)
                        Severity: Minor
                        Found in symphony/lib/toolkit/fields/field.upload.php - About 35 mins to fix

                          Function prepareExportValue has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                          Open

                              public function prepareExportValue($data, $mode, $entry_id = null)
    {
        $modes = (object)$this->getExportModes();

        $filepath = $this->getFilePath($data['file']);
                          Severity: Minor
                          Found in symphony/lib/toolkit/fields/field.upload.php - About 35 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function validateFilename has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                          Open

                              public function validateFilename($file, &$message)
    {
        if ($this->get('validator') != null) {
            $rule = $this->get('validator');
                          Severity: Minor
                          Found in symphony/lib/toolkit/fields/field.upload.php - About 35 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Avoid too many return statements within this method.
                          Open

                                      return self::__ERROR__;
                          Severity: Major
                          Found in symphony/lib/toolkit/fields/field.upload.php - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                        return self::__ERROR_CUSTOM__;
                            Severity: Major
                            Found in symphony/lib/toolkit/fields/field.upload.php - About 30 mins to fix

                              Avoid too many return statements within this method.
                              Open

                                      return array(
            'file' =>       basename($file),
            'size' =>       $data['size'],
            'mimetype' =>   $data['type'],
            'meta' =>       serialize(static::getMetaInfo($file, $data['type']))
                              Severity: Major
                              Found in symphony/lib/toolkit/fields/field.upload.php - About 30 mins to fix

                                Avoid too many return statements within this method.
                                Open

                                        return $this->validateFilename($data['name'], $message);
                                Severity: Major
                                Found in symphony/lib/toolkit/fields/field.upload.php - About 30 mins to fix

                                  Avoid too many return statements within this method.
                                  Open

                                              return false;
                                  Severity: Major
                                  Found in symphony/lib/toolkit/fields/field.upload.php - About 30 mins to fix

                                    Avoid too many return statements within this method.
                                    Open

                                                return self::__ERROR__;
                                    Severity: Major
                                    Found in symphony/lib/toolkit/fields/field.upload.php - About 30 mins to fix

                                      Similar blocks of code found in 4 locations. Consider refactoring.
                                      Open

                                          public function buildSortingSQL(&$joins, &$where, &$sort, $order = 'ASC')
    {
        if (Symphony::Log()) {
            Symphony::Log()->pushDeprecateWarningToLog(
                get_called_class() . '::buildSortingSQL()',
                                      Severity: Major
                                      Found in symphony/lib/toolkit/fields/field.upload.php and 3 other locations - About 1 hr to fix
                                      symphony/lib/toolkit/fields/field.checkbox.php on lines 439..462
                                      symphony/lib/toolkit/fields/field.date.php on lines 817..840
                                      symphony/lib/toolkit/fields/field.input.php on lines 378..401

                                      Duplicated Code

                                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                      Tuning

                                      This issue has a mass of 108.

                                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                      Refactorings

                                      Further Reading

                                      Identical blocks of code found in 3 locations. Consider refactoring.
                                      Open

                                          public function prepareImportValue($data, $mode, $entry_id = null)
    {
        $message = $status = null;
        $modes = (object)$this->getImportModes();
                                      Severity: Major
                                      Found in symphony/lib/toolkit/fields/field.upload.php and 2 other locations - About 1 hr to fix
                                      symphony/lib/toolkit/fields/field.input.php on lines 242..254
                                      symphony/lib/toolkit/fields/field.textarea.php on lines 302..314

                                      Duplicated Code

                                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                      Tuning

                                      This issue has a mass of 101.

                                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                      Refactorings

                                      Further Reading

                                      There are no issues that match your filters.

                                      Category
                                      Status