Sign upLogin

symphonycms/symphony-2

View on GitHub
Star
symphony/lib/toolkit/trait.databasewheredefinition.php

Summary

Maintainability
D
2 days
Test Coverage

Function buildSingleWhereClauseFromArray has a Cognitive Complexity of 90 (exceeds 5 allowed). Consider refactoring.
Open

    final public function buildSingleWhereClauseFromArray($k, $c)
    {
        $op = '=';
        if (is_object($c)) {
            if (!($c instanceof DatabaseSubQuery)) {
Severity: Minor
Found in symphony/lib/toolkit/trait.databasewheredefinition.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method buildSingleWhereClauseFromArray has 145 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    final public function buildSingleWhereClauseFromArray($k, $c)
    {
        $op = '=';
        if (is_object($c)) {
            if (!($c instanceof DatabaseSubQuery)) {
Severity: Major
Found in symphony/lib/toolkit/trait.databasewheredefinition.php - About 5 hrs to fix

    Avoid too many return statements within this method.
    Open

                    return "MATCH ($tk) AGAINST ($pk IN BOOLEAN MODE)";
    Severity: Major
    Found in symphony/lib/toolkit/trait.databasewheredefinition.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                      return $this->buildWhereClauseFromArray($c);
      Severity: Major
      Found in symphony/lib/toolkit/trait.databasewheredefinition.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                        return $this->buildWhereClauseFromArray($conditions);
        Severity: Major
        Found in symphony/lib/toolkit/trait.databasewheredefinition.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                  return "$tk $op $k";
          Severity: Major
          Found in symphony/lib/toolkit/trait.databasewheredefinition.php - About 30 mins to fix

            There are no issues that match your filters.

            Category
            Status