Sign upLogin

synapsecns/sanguine

View on GitHub
Star
ethergo/submitter/db/txdb/store.go

Summary

Maintainability
B
4 hrs
Test Coverage

Method Store.PutTXS has 8 return statements (exceeds 4 allowed).
Open

func (s Store) PutTXS(ctx context.Context, txs ...db.TX) error {
    // TODO: consider warning.
    if len(txs) == 0 {
        return nil
    }
Severity: Major
Found in ethergo/submitter/db/txdb/store.go - About 50 mins to fix

    Method Store.GetNonceAttemptsByStatus has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    func (s *Store) GetNonceAttemptsByStatus(ctx context.Context, fromAddress common.Address, chainID *big.Int, nonce uint64, matchStatuses ...db.Status) (txs []db.TX, err error) {
    Severity: Minor
    Found in ethergo/submitter/db/txdb/store.go - About 35 mins to fix

      Method Store.GetTXS has 5 return statements (exceeds 4 allowed).
      Open

      func (s *Store) GetTXS(ctx context.Context, fromAddress common.Address, chainID *big.Int, options ...db.Option) (txs []db.TX, err error) {
    var dbTXs []ETHTX

    madeOptions := db.ParseOptions(options...)
    inArgs := statusToArgs(madeOptions.Statuses()...)
      Severity: Major
      Found in ethergo/submitter/db/txdb/store.go - About 35 mins to fix

        Method Store.GetAllTXAttemptByStatus has 5 return statements (exceeds 4 allowed).
        Open

        func (s *Store) GetAllTXAttemptByStatus(ctx context.Context, fromAddress common.Address, chainID *big.Int, options ...db.Option) (txs []db.TX, err error) {
    var dbTXs []ETHTX

    madeOptions := db.ParseOptions(options...)
    inArgs := statusToArgs(madeOptions.Statuses()...)
        Severity: Major
        Found in ethergo/submitter/db/txdb/store.go - About 35 mins to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              subQuery := s.DB().Model(&ETHTX{}).
        Select(fmt.Sprintf("MAX(%s) as %s, %s, %s", idFieldName, idFieldName, nonceFieldName, chainIDFieldName)).
        Where(query).
        Where(fmt.Sprintf("%s IN ?", statusFieldName), inArgs).
        Group(fmt.Sprintf("%s, %s", nonceFieldName, chainIDFieldName)).
          Severity: Minor
          Found in ethergo/submitter/db/txdb/store.go and 1 other location - About 50 mins to fix
          ethergo/submitter/db/txdb/store.go on lines 140..146

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 118.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              subQuery := s.DB().Model(&ETHTX{}).
        Select(fmt.Sprintf("MAX(%s) as %s, %s, %s", idFieldName, idFieldName, nonceFieldName, chainIDFieldName)).
        Where(query).
        Where(fmt.Sprintf("%s IN ?", statusFieldName), inArgs).
        Group(fmt.Sprintf("%s, %s", nonceFieldName, chainIDFieldName)).
          Severity: Minor
          Found in ethergo/submitter/db/txdb/store.go and 1 other location - About 50 mins to fix
          ethergo/submitter/db/txdb/store.go on lines 198..204

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 118.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status