synapsecns/sanguine

View on GitHub
services/explorer/api/resolver_test.go

Summary

Maintainability
F
3 days
Test Coverage

File resolver_test.go has 659 lines of code (exceeds 500 allowed). Consider refactoring.
Open

package api_test

import (
    gosql "database/sql"
    "fmt"
Severity: Minor
Found in services/explorer/api/resolver_test.go - About 5 hrs to fix

    Method APISuite.TestGetBridgeTransactions has 113 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (g APISuite) TestGetBridgeTransactions() {
        chainID := g.chainIDs[0]
        destinationChainID := g.chainIDs[1]
        contractAddr := common.BigToAddress(big.NewInt(gofakeit.Int64())).String()
        tokenAddress := common.BigToAddress(big.NewInt(gofakeit.Int64())).String()
    Severity: Major
    Found in services/explorer/api/resolver_test.go - About 3 hrs to fix

      Method APISuite.TestGetCountByTokenAddress has a Cognitive Complexity of 38 (exceeds 20 allowed). Consider refactoring.
      Open

      func (g APISuite) TestGetCountByTokenAddress() {
          chainID := g.chainIDs[0]
          destinationChainID := g.chainIDs[1]
          tokenAddressA := common.BigToAddress(big.NewInt(gofakeit.Int64()))
          tokenAddressB := common.BigToAddress(big.NewInt(gofakeit.Int64()))
      Severity: Minor
      Found in services/explorer/api/resolver_test.go - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method APISuite.TestAmountStatistic has 99 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func (g APISuite) TestAmountStatistic() {
          chainID := g.chainIDs[0]
          destinationChainIDA := g.chainIDs[1]
          destinationChainIDB := g.chainIDs[2]
          address := common.BigToAddress(big.NewInt(gofakeit.Int64()))
      Severity: Major
      Found in services/explorer/api/resolver_test.go - About 2 hrs to fix

        Method APISuite.TestGetCountByTokenAddress has 97 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        func (g APISuite) TestGetCountByTokenAddress() {
            chainID := g.chainIDs[0]
            destinationChainID := g.chainIDs[1]
            tokenAddressA := common.BigToAddress(big.NewInt(gofakeit.Int64()))
            tokenAddressB := common.BigToAddress(big.NewInt(gofakeit.Int64()))
        Severity: Major
        Found in services/explorer/api/resolver_test.go - About 2 hrs to fix

          Method APISuite.TestGetCountByChainID has 86 lines of code (exceeds 50 allowed). Consider refactoring.
          Open

          func (g APISuite) TestGetCountByChainID() {
              chainID := g.chainIDs[0]
              chainID2 := g.chainIDs[1]
              chainID3 := g.chainIDs[2]
              address := common.BigToAddress(big.NewInt(gofakeit.Int64()))
          Severity: Major
          Found in services/explorer/api/resolver_test.go - About 2 hrs to fix

            Method APISuite.TestAddressRanking has 78 lines of code (exceeds 50 allowed). Consider refactoring.
            Open

            func (g APISuite) TestAddressRanking() {
                var chainID uint32
                chainIDs := []uint32{g.chainIDs[0], g.chainIDs[1], g.chainIDs[2]}
                destinationChainIDA := g.chainIDs[3]
                destinationChainIDB := g.chainIDs[4]
            Severity: Major
            Found in services/explorer/api/resolver_test.go - About 2 hrs to fix

              Method APISuite.TestDailyStatisticsByChain has 71 lines of code (exceeds 50 allowed). Consider refactoring.
              Open

              func (g APISuite) TestDailyStatisticsByChain() {
                  chainID := g.chainIDs[0]
                  destinationChainIDA := g.chainIDs[1]
                  destinationChainIDB := g.chainIDs[2]
                  address := common.BigToAddress(big.NewInt(gofakeit.Int64()))
              Severity: Minor
              Found in services/explorer/api/resolver_test.go - About 1 hr to fix

                Method APISuite.TestLeaderboard has 57 lines of code (exceeds 50 allowed). Consider refactoring.
                Open

                func (g APISuite) TestLeaderboard() {
                    chainID := g.chainIDs[0]
                    address := common.BigToAddress(big.NewInt(gofakeit.Int64()))
                    var addressNS gosql.NullString
                    addressNS.String = address.String()
                Severity: Minor
                Found in services/explorer/api/resolver_test.go - About 1 hr to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      for _, res := range resultOut.Response {
                          switch *res.ChainID {
                          case int(chainID):
                              Equal(g.T(), 1, *res.Count)
                              reached++
                  Severity: Minor
                  Found in services/explorer/api/resolver_test.go and 1 other location - About 50 mins to fix
                  services/explorer/api/resolver_test.go on lines 211..223

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 122.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      for _, res := range resultIn.Response {
                          switch *res.ChainID {
                          case int(chainID):
                              Equal(g.T(), 1, *res.Count)
                              reached++
                  Severity: Minor
                  Found in services/explorer/api/resolver_test.go and 1 other location - About 50 mins to fix
                  services/explorer/api/resolver_test.go on lines 189..201

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 122.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Open

                          if *res.ChainID == int(chainID) {
                              if *res.TokenAddress == tokenAddressA.String() {
                                  Equal(g.T(), 5, *res.Count)
                                  reached++
                              }
                  Severity: Major
                  Found in services/explorer/api/resolver_test.go and 2 other locations - About 40 mins to fix
                  services/explorer/api/resolver_test.go on lines 291..300
                  services/explorer/api/resolver_test.go on lines 321..330

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 112.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Open

                          if *res.ChainID == int(destinationChainID) {
                              if *res.TokenAddress == tokenAddressA.String() {
                                  Equal(g.T(), 5, *res.Count)
                                  reached++
                              }
                  Severity: Major
                  Found in services/explorer/api/resolver_test.go and 2 other locations - About 40 mins to fix
                  services/explorer/api/resolver_test.go on lines 281..290
                  services/explorer/api/resolver_test.go on lines 321..330

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 112.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Open

                          if *res.ChainID == int(chainID) {
                              if *res.TokenAddress == tokenAddressA.String() {
                                  Equal(g.T(), 5, *res.Count)
                                  reached++
                              }
                  Severity: Major
                  Found in services/explorer/api/resolver_test.go and 2 other locations - About 40 mins to fix
                  services/explorer/api/resolver_test.go on lines 281..290
                  services/explorer/api/resolver_test.go on lines 291..300

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 112.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status