Sign upLogin

synapsecns/sanguine

View on GitHub
Star
services/omnirpc/modules/confirmedtofinalized/finalizedproxy.go

Summary

Maintainability
C
7 hrs
Test Coverage

Method finalizedProxyImpl.ProxyRequest has 7 return statements (exceeds 4 allowed).
Open

func (r *finalizedProxyImpl) ProxyRequest(c *gin.Context) (err error) {
    ctx, span := r.handler.Tracer().Start(c, "ProxyRequest",
        trace.WithAttributes(attribute.String("endpoint", r.proxyURL)),
    )
Severity: Major
Found in services/omnirpc/modules/confirmedtofinalized/finalizedproxy.go - About 45 mins to fix

    Method finalizedProxyImpl.checkShouldRequest has 6 return statements (exceeds 4 allowed).
    Open

    func (r *finalizedProxyImpl) checkShouldRequest(parentCtx context.Context, req rpc.Request) bool {
    // only apply to sendRawTransaction
    // ignore if maxSubmitAhead is 0
    if client.RPCMethod(req.Method) != client.SendRawTransactionMethod && r.maxSubmitAhead > 0 {
        return true
    Severity: Major
    Found in services/omnirpc/modules/confirmedtofinalized/finalizedproxy.go - About 40 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      func (r *finalizedProxyImpl) Run(ctx context.Context) error {
    router := ginhelper.NewWithExperimentalLogger(ctx, r.handler.ExperimentalLogger())
    router.Use(r.handler.Gin()...)

    router.POST("/", func(c *gin.Context) {
      Severity: Major
      Found in services/omnirpc/modules/confirmedtofinalized/finalizedproxy.go and 1 other location - About 5 hrs to fix
      services/omnirpc/modules/receiptsbackup/receiptsbackup.go on lines 67..96

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 372.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

          resp, err := req.
        SetContext(ctx).
        SetRequestURI(r.proxyURL).
        SetBody(body).
        SetHeaderBytes(omniHTTP.XRequestID, requestID).
      Severity: Major
      Found in services/omnirpc/modules/confirmedtofinalized/finalizedproxy.go and 4 other locations - About 40 mins to fix
      services/omnirpc/modules/harmonyproxy/harmonyproxy.go on lines 148..156
      services/omnirpc/modules/receiptsbackup/receiptsbackup.go on lines 162..170
      services/omnirpc/modules/receiptsbackup/receiptsbackup.go on lines 173..181
      services/omnirpc/modules/receiptsbackup/receiptsbackup.go on lines 188..196

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 110.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status