talho/openphin

Function onKeyDown has 34 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    onKeyDown : function(e){
        var s = this.selNode || this.lastSelNode;
        // undesirable, but required
        var sm = this;
        if(!s){

Function expandPath has 34 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    expandPath : function(path, attr, callback){
        if(Ext.isEmpty(path)){
            if(callback){
                callback(false, undefined);
            }

Function selectPath has 34 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    selectPath : function(path, attr, callback){
        if(Ext.isEmpty(path)){
            if(callback){
                callback(false, undefined);
            }

Function initEditor has 34 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    initEditor : function(){
        //Destroying the component during/before initEditor can cause issues.
        try{
            var dbody = this.getEditorBody(),
                ss = this.el.getStyles('font-size', 'font-family', 'background-image', 'background-repeat', 'background-color', 'color'),

Function getErrors has 34 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    getErrors: function(value) {
        var errors = Ext.form.TextField.superclass.getErrors.apply(this, arguments);
        
        value = Ext.isDefined(value) ? value : this.processValue(this.getRawValue());        
        

Function Layer has 34 lines of code (exceeds 25 allowed). Consider refactoring.

Open

Ext.Layer = function(config, existingEl){
    config = config || {};
    var dh = Ext.DomHelper,
        cp = config.parentEl, pel = cp ? Ext.getDom(cp) : document.body;
        

Function onLayout has 34 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    onLayout : function(ct, target) {
        //render the Toolbar <table> HTML if it's not already present
        if (!this.leftTr) {
            var align = ct.buttonAlign == 'center' ? 'center' : 'left';

Function open has 34 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        open: function(image, sel, group) {
            group = group || false;
            this.setViewSize();
            els.overlay.fadeIn({
                duration: this.overlayDuration,

Function SplitBar has 34 lines of code (exceeds 25 allowed). Consider refactoring.

Open

Ext.SplitBar = function(dragElement, resizingElement, orientation, placement, existingProxy){

    /** @private */
    this.el = Ext.get(dragElement, true);
    this.el.dom.unselectable = "on";

Function step has 34 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    step: function(gotoEnd){
        var t = (new Date()).getTime();

        if ( gotoEnd || t > this.options.duration + this.startTime ) {
            this.now = this.end;

Function showEditWindow has 34 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  showEditWindow: function(){
    var htmleditor = new Talho.ux.PhinHtmlEditor({
      linksInNewWindow: true,
      name: 'htmlportlet',
      region: 'center',

Function initComponent has 34 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  initComponent: function() {
    this.rss_store = new Ext.data.JsonStore({
      url: '/rss_feed.json',
      baseParams: {
        'urls[]': this.urls,

Function load has 34 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    load: function( url, params, callback ) {
        if ( jQuery.isFunction( url ) )
            return this.bind("load", url);

        var off = url.indexOf(" ");

Function showEditWindow has 34 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  showEditWindow: function(){
    var htmleditor = new Ext.form.HtmlEditor({
      linksInNewWindow: true,
      name: 'htmlportlet',
      region: 'center',

Function parseStringItem has 34 lines of code (exceeds 25 allowed). Consider refactoring.

Open

function parseStringItem( string , context , thread ) {

    var done,
        func,
        data = {},

Method handle_org_requests has 34 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  def handle_org_requests(req_json, current_user)
    return [ false, [ "Permission denied" ] ] unless editable_by?(current_user)
    rq_list = ActiveSupport::JSON.decode(req_json)
    result = "success"
    rq_errors = []

Function getStore has 34 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    getStore: function(){
        if(!this.store){
            var writer = new Ext.data.JsonWriter({
                encode: false,
                createRecord: function(record){

Method import has 34 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  def import
    invitees = []
    csvfile = params[:invitation][:csvfile]
    newfile = File.join(Rails.root.to_s,'tmp',csvfile.original_filename)
    File.open(newfile,'wb') do |file|

Method update has 34 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  def update
    if (params[:topic] && params[:topic][:comment_attributes] && params[:topic][:comment_attributes][:comment_id])    
      parent_topic = Topic.find(params[:topic][:comment_attributes][:comment_id])
      while not parent_topic.comment_id.nil?
        parent_topic = Topic.find(parent_topic.comment_id)

Identical blocks of code found in 2 locations. Consider refactoring.

Open

            b = {x: xy[0], y: xy[1], 0: xy[0], 1: xy[1], width: dom.offsetWidth, height: dom.offsetHeight};

• Read up
  Read up