talho/openphin

Identical blocks of code found in 2 locations. Consider refactoring.

Open

            b = {x: xy[0], y: xy[1], 0: xy[0], 1: xy[1], width: dom.offsetWidth, height: dom.offsetHeight};

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

            _queue.push({
                url: url,
                script: script,
                callback: o.callback || function(){},
                scope: o.scope || window,

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

      _queue.push({
        url : url,
        script : script,
        callback : o.callback ||
        function() {

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

jQuery.each( "ajaxStart,ajaxStop,ajaxComplete,ajaxError,ajaxSuccess,ajaxSend".split(","), function(i,o){
    jQuery.fn[o] = function(f){
        return this.bind(o, f);
    };
});

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

jQuery.each( "ajaxStart,ajaxStop,ajaxComplete,ajaxError,ajaxSuccess,ajaxSend".split(","), function(i,o){
    jQuery.fn[o] = function(f){
        return this.bind(o, f);
    };
});

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    css: function( key, value ) {
        // ignore negative width and height values
        if ( (key == 'width' || key == 'height') && parseFloat(value) < 0 )
            value = undefined;
        return this.attr( key, value, "curCSS" );

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            'up' : function(e){
                if(e.ctrlKey){
                    this.showNextYear();
                }else{
                    this.update(this.activeDate.add('d', -7));

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            'left' : function(e){
                if(e.ctrlKey){
                    this.showPrevMonth();
                }else{
                    this.update(this.activeDate.add('d', -1));

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  disableEditCurrent: function(){
    var btns = ['save', 'delete', 'preview_button', 'editview_button', 'column_button', 'add_portlet', 'permissions'];
    Ext.each(btns, function(btn){
      this.getComponent(btn).disable();
    }, this);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  enableEditCurrent: function(){
    var btns = ['save', 'delete', 'preview_button', 'editview_button', 'column_button', 'add_portlet', 'permissions'];
    Ext.each(btns, function(btn){
      this.getComponent(btn).enable();
    }, this);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    css: function( key, value ) {
        // ignore negative width and height values
        if ( (key == 'width' || key == 'height') && parseFloat(value) < 0 )
            value = undefined;
        return this.attr( key, value, "curCSS" );

• Read up
  Read up

Consider simplifying this complex logical expression.

Open

            if ( match[1] == "nth" ) {
                // parse equations like 'even', 'odd', '5', '2n', '3n+2', '4n-1', '-n+6'
                var test = /(-?)(\d*)n((?:\+|-)?\d*)/.exec(
                    match[2] == "even" && "2n" || match[2] == "odd" && "2n+1" ||
                    !/\D/.test( match[2] ) && "0n+" + match[2] || match[2]);

Consider simplifying this complex logical expression.

Open

            if (ua.w3 && !(ua.wk && ua.wk < 312) && swfUrlStr && replaceElemIdStr && widthStr && heightStr && swfVersionStr) {
                setVisibility(replaceElemIdStr, false);
                addDomLoadEvent(function() {
                    widthStr += ""; // auto-convert to string
                    heightStr += "";

Consider simplifying this complex logical expression.

Open

            if(me.fireEvent(BEFOREREQUEST, me, o)){
                if (o.el) {
                    if(!Ext.isEmpty(o.indicatorText)){
                        me.indicatorText = '<div class="loading-indicator">'+o.indicatorText+"</div>";
                    }

Consider simplifying this complex logical expression.

Open

                if((Ext.isString(item.hideField) && record.get(item.hideField)) || (Ext.isString(item.showField) && !record.get(item.showField)) )
                    v += '<img src="' + Ext.BLANK_IMAGE_URL + '" class="x-action-col-icon"' +
                        ' width="' + ((item.width) ?  item.width : me.widthScope) + '"' +
                        ' height="0"' + ' />';
                else{

Consider simplifying this complex logical expression.

Open

                    if ( m[1] == "#" && elem && elem.getElementById && !jQuery.isXMLDoc(elem) ) {
                        // Optimization for HTML document case
                        var oid = elem.getElementById(m[2]);
                        
                        // Do a quick check for the existence of the actual ID attribute

Function beforeaction has 33 lines of code (exceeds 25 allowed). Consider refactoring.

Open

                            'beforeaction': function(form, action){
                                if(action.type == 'submit')
                                {
                                    action.options.params = action.options.params || {};

Function updateVersionDisplay has 33 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  updateVersionDisplay: function(versionData){
    this.selectionStore.loadData(versionData.diff_list);
    var version_rowid = this.resultsStore.indexOfId(this.selectedVersionId);
    var sel_model = this.resultsPanel.getSelectionModel();
    sel_model.clearSelections();

Function step has 33 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    step: function(gotoEnd){
        var t = now();

        if ( gotoEnd || t >= this.options.duration + this.startTime ) {
            this.now = this.end;

Function initComponent has 33 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  initComponent : function() {
    this.setTitle('Move Topic');
    
    this.items = [];