Sign upLogin

taviroquai/duality

View on GitHub
Star

Showing 38 of 38 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    public function getInsert(Table $table, $item = array())
    {
        $sql = "INSERT INTO " . strtolower((string) $table) . " (";

        $values = array();
Severity: Major
Found in src/Duality/Service/Database/SQLite.php and 1 other location - About 4 hrs to fix
src/Duality/Service/Database/MySql.php on lines 176..198

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 171.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    public function getInsert(Table $table, $item = array())
    {
        $sql = "INSERT INTO " . strtolower((string) $table) . " (";

        $values = array();
Severity: Major
Found in src/Duality/Service/Database/MySql.php and 1 other location - About 4 hrs to fix
src/Duality/Service/Database/SQLite.php on lines 173..195

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 171.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Database has 25 functions (exceeds 20 allowed). Consider refactoring.
Open

abstract class Database
extends AbstractService
{
    /**
     * Holds the PDO handler
Severity: Minor
Found in src/Duality/Service/Database.php - About 2 hrs to fix

    App has 25 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class App 
extends Container
{
    /**
     * Holds application working directory
    Severity: Minor
    Found in src/Duality/App.php - About 2 hrs to fix

      Server has 22 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class Server
extends AbstractService
implements InterfaceServer
{
    /**
      Severity: Minor
      Found in src/Duality/Service/Server.php - About 2 hrs to fix

        Function listen has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
        Open

            public function listen()
    {
        // Set default values
        $result = false;
        $matches = array();
        Severity: Minor
        Found in src/Duality/Service/Server.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method getRequestFromGlobals has 53 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function getRequestFromGlobals($server, $params)
    {
        if (empty($server['REQUEST_METHOD'])) {
            return false;
        }
        Severity: Major
        Found in src/Duality/Service/Server.php - About 2 hrs to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              public function getSelect(
        $fields, $from, $where = '', $groupby = '', $limit = 0, $offset = 0
    ) {
        $sql = "SELECT $fields FROM ".strtolower((string) $from);
        if (!empty($where)) {
          Severity: Major
          Found in src/Duality/Service/Database/SQLite.php and 1 other location - About 1 hr to fix
          src/Duality/Service/Database/MySql.php on lines 60..72

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 118.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              public function getSelect(
        $fields, $from, $where = '', $groupby = '', $limit = 0, $offset = 0
    ) {
        $sql = "SELECT $fields FROM ".strtolower((string) $from);
        if (!empty($where)) {
          Severity: Major
          Found in src/Duality/Service/Database/MySql.php and 1 other location - About 1 hr to fix
          src/Duality/Service/Database/SQLite.php on lines 60..72

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 118.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function seedFromConfig has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
          Open

              public function seedFromConfig()
    {
        // Begin transation
        $this->pdo->beginTransaction();
          Severity: Minor
          Found in src/Duality/Service/Database.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              public function getDelete(Table $table, $item)
    {
        $sql  = "DELETE FROM " . strtolower((string) $table) . " ";
        $sql .= "WHERE ";
        $values = array();
          Severity: Major
          Found in src/Duality/Service/Database/SQLite.php and 1 other location - About 1 hr to fix
          src/Duality/Service/Database/MySql.php on lines 230..242

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 115.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              public function getDelete(Table $table, $item)
    {
        $sql  = "DELETE FROM " . strtolower((string) $table) . " ";
        $sql .= "WHERE ";
        $values = array();
          Severity: Major
          Found in src/Duality/Service/Database/MySql.php and 1 other location - About 1 hr to fix
          src/Duality/Service/Database/SQLite.php on lines 228..240

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 115.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Method send has 41 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function send(\Closure $callback)
    {
        $mail = new PHPMailer;

        // Setup SMTP
          Severity: Minor
          Found in src/Duality/Service/Mailer.php - About 1 hr to fix

            Method connect has 40 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function connect($host, $username, $password = '', $port = 22)
    {
        // Start connection
        if (!($this->connection = @ssh2_connect($host, $port))) {
            throw new DualityException(
            Severity: Minor
            Found in src/Duality/Service/SSH.php - About 1 hr to fix

              Method listen has 38 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function listen()
    {
        // Set default values
        $result = false;
        $matches = array();
              Severity: Minor
              Found in src/Duality/Service/Server.php - About 1 hr to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    public function getCreateTable(Table $table, $config)
    {
        $sql = "CREATE TABLE IF NOT EXISTS " . strtolower((string) $table) . " (";

        foreach ($config as $field => $definition) {
                Severity: Major
                Found in src/Duality/Service/Database/MySql.php and 1 other location - About 1 hr to fix
                src/Duality/Service/Database/SQLite.php on lines 82..96

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 109.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    public function getCreateTable(Table $table, $config)
    {
        $sql = "CREATE TABLE IF NOT EXISTS " . strtolower((string) $table) . " (";

        foreach ($config as $field => $definition) {
                Severity: Major
                Found in src/Duality/Service/Database/SQLite.php and 1 other location - About 1 hr to fix
                src/Duality/Service/Database/MySql.php on lines 82..95

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 109.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Method init has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function init()
    {
        if (!extension_loaded('intl')) {
            throw new DualityException(
                "Error: intl extension not loaded",
                Severity: Minor
                Found in src/Duality/Service/Localization.php - About 1 hr to fix

                  Method init has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function init()
    {
        $this->pretend = false;
        $this->current = new Storage;
        $this->smtp = new Storage;
                  Severity: Minor
                  Found in src/Duality/Service/Mailer.php - About 1 hr to fix

                    Method setLocale has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function setLocale($code, $timezone = 'Europe/Lisbon')
    {
        $this->current = \Locale::canonicalize($code);

        // Validate locale and translations directory
                    Severity: Minor
                    Found in src/Duality/Service/Localization.php - About 1 hr to fix
                      Severity
                      Category
                      Status
                      Source
                      Language