src/Catalog/CategoryBuilder.php
Method __construct
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
CategoryRepositoryInterface $categoryRepository,
CategoryResource $categoryResource,
CategoryLinkRepositoryInterface $categoryLinkRepository,
CategoryProductLinkInterfaceFactory $productLinkFactory,
Category $category,
Avoid excessively long variable names like $categoryLinkRepository. Keep variable name length under 20. Open
Open
private $categoryLinkRepository;
- Read upRead up
- Exclude checks
LongVariable
Since: 0.2
Detects when a field, formal or local variable is declared with a long name.
Example
class Something {
protected $reallyLongIntName = -3; // VIOLATION - Field
public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
$otherReallyLongName = -5; // VIOLATION - Local
for ($interestingIntIndex = 0; // VIOLATION - For
$interestingIntIndex < 10;
$interestingIntIndex++ ) {
}
}
}
Source https://phpmd.org/rules/naming.html#longvariable
Avoid excessively long variable names like $categoryLinkRepository. Keep variable name length under 20. Open
Open
CategoryLinkRepositoryInterface $categoryLinkRepository,
- Read upRead up
- Exclude checks
LongVariable
Since: 0.2
Detects when a field, formal or local variable is declared with a long name.
Example
class Something {
protected $reallyLongIntName = -3; // VIOLATION - Field
public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
$otherReallyLongName = -5; // VIOLATION - Local
for ($interestingIntIndex = 0; // VIOLATION - For
$interestingIntIndex < 10;
$interestingIntIndex++ ) {
}
}
}