Sign upLogin

tddwizard/magento2-fixtures

View on GitHub
Star
src/Sales/OrderBuilder.php

Summary

Maintainability
A
2 hrs
Test Coverage

Method build has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function build(): Order
    {
        $builder = clone $this;

        if (empty($builder->productBuilders)) {
Severity: Minor
Found in src/Sales/OrderBuilder.php - About 1 hr to fix

    Function build has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        public function build(): Order
    {
        $builder = clone $this;

        if (empty($builder->productBuilders)) {
    Severity: Minor
    Found in src/Sales/OrderBuilder.php - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid unused private fields such as '$paymentMethod'.
    Open

        private $paymentMethod;
    Severity: Minor
    Found in src/Sales/OrderBuilder.php by phpmd

    UnusedPrivateField

    Since: 0.2

    Detects when a private field is declared and/or assigned a value, but not used.

    Example

    class Something
{
    private static $FOO = 2; // Unused
    private $i = 5; // Unused
    private $j = 6;
    public function addOne()
    {
        return $this->j++;
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedprivatefield

    Avoid unused private fields such as '$customerBuilder'.
    Open

        private $customerBuilder;
    Severity: Minor
    Found in src/Sales/OrderBuilder.php by phpmd

    UnusedPrivateField

    Since: 0.2

    Detects when a private field is declared and/or assigned a value, but not used.

    Example

    class Something
{
    private static $FOO = 2; // Unused
    private $i = 5; // Unused
    private $j = 6;
    public function addOne()
    {
        return $this->j++;
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedprivatefield

    Avoid unused private fields such as '$shippingMethod'.
    Open

        private $shippingMethod;
    Severity: Minor
    Found in src/Sales/OrderBuilder.php by phpmd

    UnusedPrivateField

    Since: 0.2

    Detects when a private field is declared and/or assigned a value, but not used.

    Example

    class Something
{
    private static $FOO = 2; // Unused
    private $i = 5; // Unused
    private $j = 6;
    public function addOne()
    {
        return $this->j++;
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedprivatefield

    Avoid unused private fields such as '$productBuilders'.
    Open

        private $productBuilders;
    Severity: Minor
    Found in src/Sales/OrderBuilder.php by phpmd

    UnusedPrivateField

    Since: 0.2

    Detects when a private field is declared and/or assigned a value, but not used.

    Example

    class Something
{
    private static $FOO = 2; // Unused
    private $i = 5; // Unused
    private $j = 6;
    public function addOne()
    {
        return $this->j++;
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedprivatefield

    Avoid unused private fields such as '$cartBuilder'.
    Open

        private $cartBuilder;
    Severity: Minor
    Found in src/Sales/OrderBuilder.php by phpmd

    UnusedPrivateField

    Since: 0.2

    Detects when a private field is declared and/or assigned a value, but not used.

    Example

    class Something
{
    private static $FOO = 2; // Unused
    private $i = 5; // Unused
    private $j = 6;
    public function addOne()
    {
        return $this->j++;
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedprivatefield

    There are no issues that match your filters.

    Category
    Status