Class Referent has 21 methods (exceeds 20 allowed). Consider refactoring.

Open

class Referent < ActiveRecord::Base
  # for shortcut metadata manipulations
  include MetadataHelper
  
  has_many :requests

Class Bib has 21 methods (exceeds 20 allowed). Consider refactoring.

Open

    class Bib 
        attr_accessor :httpSession, :hip_base_url
        # should have copies or items, not both
        attr_accessor :bibNum, :copies, :items
    attr_writer :title

Method handle has 54 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  def handle(request)
    isbn = get_identifier(:urn, "isbn", request.referent)
    issn = get_identifier(:urn, "issn", request.referent)
    oclcnum = get_identifier(:info, "oclcnum", request.referent)
    

Method determine_coverage_boundaries has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.

Open

  def determine_coverage_boundaries(target)
    # machine actionable coverage elements, used for collapsing
    if (in_node = target.at_xpath("./coverage/in"))
        year = in_node.at_xpath("year").try(:text).try(:to_i)
        if year && year != 0

• Read up
  Read up

Method add_asin_service_responses has 52 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  def add_asin_service_responses(request, asin, item_url)
    # we want to highlight Amazon to link to 'search in this book', etc.
    if asin
      # Search or Look inside the book offered? We only know by trying and
      # then screen-scraping.

Function update has 50 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    this.update = function() {
      // Need to capture because we won't have 'this' inside the ajax
      // success handler. 
      var myself = this;       
      var dataType = this.is_remote_url( this.umlaut_uri ) ? "jsonp" : "json";

Method handle has 50 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  def handle(request)
    scopus_search = scopus_search(request)

    # we can't make a good query, nevermind. 
    return request.dispatched(self, true) if scopus_search.blank? 

Method included has 50 lines of code (exceeds 25 allowed). Consider refactoring.

Open

      def self.included(klass)
        klass.class_eval do
          self.table_name = 'AZ_TITLE'
          self.primary_key = 'AZ_TITLE_ID'

Method add_856_links has 48 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  def add_856_links(request, marc_records, options = {})
    options[:default_service_type] ||= "fulltext"
    options[:match_reliability] ||= ServiceResponse::MatchExact

    responses_added = Hash.new

Method excluded? has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.

Open

  def excluded?(url)    
    return false if @exclude.blank?
    
    @exclude.each do |entry|
      if ((entry[0,1] == '/') && (entry[entry.length()-1 ,1 ] == '/'))

• Read up
  Read up

Method get_identifier has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.

Open

  def get_identifier(type, sub_scheme, referent, options = {} )
    options[:multiple] ||= false
    
    raise Exception.new("type must be :urn or :info") unless type == :urn or type == :info

• Read up
  Read up

Method define_query has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.

Open

  def define_query(rft)
    oclcnum = get_identifier(:info, "oclcnum", rft)
    metadata = rft.metadata
    
    # Do we have enough info to do a query with sufficient precision?

• Read up
  Read up

Method enhance_referent has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.

Open

  def enhance_referent(request, data)
    
    entry = data["items"].first
    

• Read up
  Read up

Method handle has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.

Open

  def handle(request)
    isbn = get_identifier(:urn, "isbn", request.referent)
    issn = get_identifier(:urn, "issn", request.referent)
    oclcnum = get_identifier(:info, "oclcnum", request.referent)
    

• Read up
  Read up

Method nature_of_contents has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.

Open

  def nature_of_contents(marc)
    types = {'m'=>'dissertation','t'=>'report','j'=>'patent'}
    idx = nil
    if self.record_type(marc) == 'BKS'
      idx = 24

• Read up
  Read up

Method fetch_urls has 45 lines of code (exceeds 25 allowed). Consider refactoring.

Open

      def fetch_urls
        # Crazy crazy URLs to try to find PARSE_PARAMS in Sfx4 db that have a period in
        # them, so they look like they might be URLs. Parse params could be at target service
        # level, or at portfolio level; and could be in local overrides or in global kb. 
        # This is crazy crazy SQL to get this, sorry. Talking directly to SFX db isn't

Method enhance_referent has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.

Open

  def enhance_referent(key, value, metadata=true, private_data=false, options = {})


    ActiveRecord::Base.connection_pool.with_connection do
      return if value.nil?

• Read up
  Read up

Method find_by_title has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.

Open

    def find_by_title
      connection = sfx4_db_connection
      query_match_clause = case search_type_param
        when "contains"
          terms = title_query_param.split(" ")

• Read up
  Read up

Method handle has 43 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  def handle(request)
    ids_processed = []
    holdings_added = 0
    
    if (@identifier_search && url = blacklight_precise_search_url(request) )

Method handle has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.

Open

  def handle(request)

    bibkeys = get_bibkeys(request.referent)
    return request.dispatched(self, true) if bibkeys.nil?

• Read up
  Read up