Sign upLogin

teamdigitale/digital-citizenship-functions

View on GitHub
Star

Showing 191 of 191 total issues

Function GetMessage has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

  serviceModel: ServiceModel,
  messageModel: MessageModel,
  messageStatusModel: MessageStatusModel,
  notificationModel: NotificationModel,
  notificationStatusModel: NotificationStatusModel,
Severity: Minor
Found in lib/controllers/messages.ts - About 45 mins to fix

    Function index has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

    export async function index(
  context: ContextWithBindings,
  event: IProfileCreatedEvent | IProfileUpdatedEvent
): Promise<void> {
  const logLevel = isProduction ? "info" : "debug";
    Severity: Minor
    Found in lib/profile_events_queue_handler.ts - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function handleQueueProcessingFailure has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

      queueService: QueueService,
  queueMessageBindings: Context["bindings"],
  queueName: string,
  onTransientError: (error: RuntimeError) => Promise<Either<RuntimeError, {}>>,
  onPermanentError: (error: RuntimeError) => Promise<Either<RuntimeError, {}>>,
    Severity: Minor
    Found in lib/utils/azure_queues.ts - About 45 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      gulp.task("yarn:lint", () => {
  return gulp.src(TYPESCRIPT_SOURCE_DIR).pipe(run(`yarn run lint`));
});
      Severity: Minor
      Found in gulpfile.js and 1 other location - About 40 mins to fix
      gulpfile.js on lines 108..110

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 49.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      gulp.task("yarn:build", () => {
  return gulp.src(TYPESCRIPT_SOURCE_DIR).pipe(run(`yarn build`));
});
      Severity: Minor
      Found in gulpfile.js and 1 other location - About 40 mins to fix
      gulpfile.js on lines 115..117

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 49.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function sendWelcomeMessages has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

        apiUrl: string,
  apiKey: string,
  messages: WelcomeMessages,
  fiscalCode: FiscalCode,
  profile: ExtendedProfile
      Severity: Minor
      Found in lib/profile_events_queue_handler.ts - About 35 mins to fix

        Function createNotification has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

          lNotificationModel: NotificationModel,
  senderMetadata: CreatedMessageEventSenderMetadata,
  newMessageWithoutContent: NewMessageWithoutContent,
  newMessageContent: MessageContent,
  newNotification: NewNotification
        Severity: Minor
        Found in lib/created_message_queue_handler.ts - About 35 mins to fix

          Function GetMessageHandler has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

            messageModel: MessageModel,
  messageStatusModel: MessageStatusModel,
  notificationModel: NotificationModel,
  notificationStatusModel: NotificationStatusModel,
  blobService: BlobService
          Severity: Minor
          Found in lib/controllers/messages.ts - About 35 mins to fix

            Function handleNotification has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

              lMailerTransporter: NodeMailer.Transporter,
  lAppInsightsClient: TelemetryClient,
  lNotificationModel: NotificationModel,
  emailNotificationEvent: NotificationEvent,
  notificationDefaultParams: INotificationDefaults
            Severity: Minor
            Found in lib/emailnotifications_queue_handler.ts - About 35 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  if (isLeft(errorOrMaybeMessageStatus)) {
      return ResponseErrorInternal(
        `Error retrieving MessageStatus: ${
          errorOrMaybeMessageStatus.value.code
        }|${errorOrMaybeMessageStatus.value.body}`
              Severity: Minor
              Found in lib/controllers/messages.ts and 1 other location - About 35 mins to fix
              lib/controllers/messages.ts on lines 660..666

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 47.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  if (isLeft(errorOrNotificationStatuses)) {
      return ResponseErrorInternal(
        `Error retrieving NotificationStatus: ${
          errorOrNotificationStatuses.value.name
        }|${errorOrNotificationStatuses.value.message}`
              Severity: Minor
              Found in lib/controllers/messages.ts and 1 other location - About 35 mins to fix
              lib/controllers/messages.ts on lines 673..679

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 47.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Function getMessageNotificationStatuses has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

              async function getMessageNotificationStatuses(
  notificationModel: NotificationModel,
  notificationStatusModel: NotificationStatusModel,
  messageId: NonEmptyString
): Promise<Either<Error, Option<NotificationStatusHolder>>> {
              Severity: Minor
              Found in lib/controllers/messages.ts - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              type IGetSenderServicesHandler = (
  auth: IAzureApiAuthorization,
  clientIp: ClientIp,
  userAttributes: IAzureUserAttributes,
  fiscalCode: FiscalCode
              Severity: Minor
              Found in lib/controllers/services.ts and 1 other location - About 35 mins to fix
              lib/controllers/services.ts on lines 82..87

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 46.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              type IGetServiceHandler = (
  auth: IAzureApiAuthorization,
  clientIp: ClientIp,
  userAttributes: IAzureUserAttributes,
  serviceId: ServiceId
              Severity: Minor
              Found in lib/controllers/services.ts and 1 other location - About 35 mins to fix
              lib/controllers/services.ts on lines 93..98

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 46.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Avoid too many return statements within this function.
              Open

                    return ResponseErrorInternal("Error while updating the existing service");
              Severity: Major
              Found in lib/controllers/adm/services.ts - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                    return left<RuntimeError, OutputBindings>(
      TransientError("Cannot store message content")
    );
                Severity: Major
                Found in lib/created_message_queue_handler.ts - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                      return left<RuntimeError, NotificationEvent>(
      TransientError(
        `Error while sending email|notification=${notificationId}|message=${
          message.id
        }|error=${error.message}`
                  Severity: Major
                  Found in lib/emailnotifications_queue_handler.ts - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                        return left<RuntimeError, OutputBindings>(
      TransientError(
        `Cannot save sender service id: ${errorOrSenderService.value.body}`
      )
    );
                    Severity: Major
                    Found in lib/created_message_queue_handler.ts - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                        return right<RuntimeError, NotificationEvent>(webhookNotificationEvent);
                      Severity: Major
                      Found in lib/webhook_queue_handler.ts - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                            return ResponseSuccessRedirectToResource(
      newMessageWithoutContent,
      `/api/v1/messages/${fiscalCode}/${newMessageWithoutContent.id}`,
      { id: newMessageWithoutContent.id }
    );
                        Severity: Major
                        Found in lib/controllers/messages.ts - About 30 mins to fix
                          Severity
                          Category
                          Status
                          Source
                          Language