File created_message_queue_handler.ts
has 465 lines of code (exceeds 250 allowed). Consider refactoring. Open
/*
* This function will process events triggered by newly created messages.
* For each new input message, the delivery preferences associated to the
* recipient of the message gets retrieved and a notification gets delivered
* to each configured channel.
Function handleMessage
has 151 lines of code (exceeds 25 allowed). Consider refactoring. Open
export async function handleMessage(
lProfileModel: ProfileModel,
lMessageModel: MessageModel,
lNotificationModel: NotificationModel,
lSenderServiceModel: SenderServiceModel,
Function index
has 117 lines of code (exceeds 25 allowed). Consider refactoring. Open
export async function index(
context: ContextWithBindings
): Promise<OutputBindings | Error | void> {
const logLevel = isProduction ? "info" : "debug";
configureAzureContextTransport(context, winston, logLevel);
Function handleMessage
has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
export async function handleMessage(
lProfileModel: ProfileModel,
lMessageModel: MessageModel,
lNotificationModel: NotificationModel,
lSenderServiceModel: SenderServiceModel,
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function handleMessage
has 7 arguments (exceeds 4 allowed). Consider refactoring. Open
lProfileModel: ProfileModel,
lMessageModel: MessageModel,
lNotificationModel: NotificationModel,
lSenderServiceModel: SenderServiceModel,
lBlobService: BlobService,
Function createNotification
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
lNotificationModel: NotificationModel,
senderMetadata: CreatedMessageEventSenderMetadata,
newMessageWithoutContent: NewMessageWithoutContent,
newMessageContent: MessageContent,
newNotification: NewNotification
Avoid too many return
statements within this function. Open
return left<RuntimeError, OutputBindings>(errorOrNotificationEvent.value);
Avoid too many return
statements within this function. Open
return right<RuntimeError, OutputBindings>({});
Avoid too many return
statements within this function. Open
return left<RuntimeError, OutputBindings>(
TransientError("Cannot update message pending status")
);
Avoid too many return
statements within this function. Open
return left<RuntimeError, OutputBindings>(
TransientError("Cannot store message content")
);
Avoid too many return
statements within this function. Open
return left<RuntimeError, OutputBindings>(
TransientError(
`Cannot save sender service id: ${errorOrSenderService.value.body}`
)
);
Avoid too many return
statements within this function. Open
return right<RuntimeError, OutputBindings>(
withoutUndefinedValues(outputBindings)
);
Similar blocks of code found in 2 locations. Consider refactoring. Open
appInsightsClient.trackEvent({
measurements: {
elapsed: Date.now() - newMessageWithContent.createdAt.getTime()
},
name: eventName,
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 79.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
appInsightsClient.trackEvent({
measurements: {
elapsed: Date.now() - newMessageWithContent.createdAt.getTime()
},
name: eventName,
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 79.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
function getEmailAddressFromProfile(
profile: RetrievedProfile
): Option<NotificationChannelEmail> {
return fromNullable(profile.email).map(email => ({
addressSource: NotificationAddressSourceEnum.PROFILE_ADDRESS,
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 69.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
function getEmailAddressFromDefaultAddresses(
defaultAddresses: NewMessageDefaultAddresses
): Option<NotificationChannelEmail> {
return fromNullable(defaultAddresses.email).map(email => ({
addressSource: NotificationAddressSourceEnum.DEFAULT_ADDRESS,
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 69.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76