teamdigitale/digital-citizenship-functions

Function index has 150 lines of code (exceeds 25 allowed). Consider refactoring.

Open

export async function index(
  context: ContextWithBindings
): Promise<OutputBindings | Error | void> {
  const stopProcessing = undefined;
  const logLevel = isProduction ? "info" : "debug";

File emailnotifications_queue_handler.ts has 408 lines of code (exceeds 250 allowed). Consider refactoring.

Open

/*
 * This function will process events triggered by newly created messages.
 * For each new input message, the delivery preferences associated to the
 * recipient of the message gets retrieved and a notification gets delivered
 * to each configured channel.

Function handleNotification has 108 lines of code (exceeds 25 allowed). Consider refactoring.

Open

export async function handleNotification(
  lMailerTransporter: NodeMailer.Transporter,
  lAppInsightsClient: TelemetryClient,
  lNotificationModel: NotificationModel,
  emailNotificationEvent: NotificationEvent,

Function handleNotification has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

  lMailerTransporter: NodeMailer.Transporter,
  lAppInsightsClient: TelemetryClient,
  lNotificationModel: NotificationModel,
  emailNotificationEvent: NotificationEvent,
  notificationDefaultParams: INotificationDefaults

Avoid too many return statements within this function.

Open

    return left<RuntimeError, NotificationEvent>(
      TransientError(
        `Error while sending email|notification=${notificationId}|message=${
          message.id
        }|error=${error.message}`

Avoid too many return statements within this function.

Open

  return right<RuntimeError, NotificationEvent>(emailNotificationEvent);

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  return handleNotification(
    mailerTransporter,
    appInsightsClient,
    notificationModel,
    emailNotificationEvent,

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  const appInsightsClient = getCustomTelemetryClient(
    {
      operationId: emailNotificationEvent.notificationId,
      operationParentId: emailNotificationEvent.message.id,
      serviceId: NonEmptyString.is(serviceId) ? serviceId : undefined

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

  if (isLeft(errorOrMaybeNotification)) {
    const error = errorOrMaybeNotification.value;
    // we got an error while fetching the notification
    return left<RuntimeError, NotificationEvent>(
      TransientError(

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  if (isLeft(errorOrEmailNotification)) {
    const error = readableReport(errorOrEmailNotification.value);
    return left<RuntimeError, NotificationEvent>(
      PermanentError(
        `Wrong format for email notification|notification=${notificationId}|message=${

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

  if (isLeft(errorOrActiveMessage)) {
    // if the message is expired no more processing is necessary
    return left<RuntimeError, NotificationEvent>(
      ExpiredError(
        `Message expired|notification=${notificationId}|message=${message.id}`

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  if (isNone(maybeEmailNotification)) {
    // it may happen that the object is not yet visible to this function due to latency
    // as the notification object is retrieved from database (?)
    return left<RuntimeError, NotificationEvent>(
      TransientError(

• Read up
  Read up