teamdigitale/italia-app

View on GitHub
ts/store/reducers/payments/history.ts

Summary

Maintainability
C
1 day
Test Coverage

Function reducer has 75 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const reducer = (
  state: PaymentsHistoryState = INITIAL_STATE,
  action: Action
): PaymentsHistoryState => {
  switch (action.type) {
Severity: Major
Found in ts/store/reducers/payments/history.ts - About 3 hrs to fix

    Avoid too many return statements within this function.
    Open

          return replaceLastItem(state, updateSuccess);
    Severity: Major
    Found in ts/store/reducers/payments/history.ts - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

        return state;
      Severity: Major
      Found in ts/store/reducers/payments/history.ts - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

              return replaceLastItem(state, updateOutcome);
        Severity: Major
        Found in ts/store/reducers/payments/history.ts - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                return INITIAL_STATE;
          Severity: Major
          Found in ts/store/reducers/payments/history.ts - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                  return replaceLastItem(state, navigationUrls);
            Severity: Major
            Found in ts/store/reducers/payments/history.ts - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                    return replaceLastItem(state, updateHistoryFailure);
              Severity: Major
              Found in ts/store/reducers/payments/history.ts - About 30 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    case getType(paymentVerifica.success):
                      const successPayload = action.payload;
                      const updateHistorySuccess: PaymentHistory = {
                        ...state[state.length - 1],
                        verifiedData: successPayload
                Severity: Major
                Found in ts/store/reducers/payments/history.ts and 1 other location - About 1 hr to fix
                ts/store/reducers/payments/history.ts on lines 120..126

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 65.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    case getType(paymentVerifica.failure):
                      const failurePayload = action.payload;
                      const updateHistoryFailure: PaymentHistory = {
                        ...state[state.length - 1],
                        failure: failurePayload
                Severity: Major
                Found in ts/store/reducers/payments/history.ts and 1 other location - About 1 hr to fix
                ts/store/reducers/payments/history.ts on lines 113..119

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 65.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    case getType(paymentIdPolling.success):
                      const paymentWithPaymentId: PaymentHistory = {
                        ...state[state.length - 1],
                        paymentId: action.payload
                      };
                Severity: Minor
                Found in ts/store/reducers/payments/history.ts and 1 other location - About 35 mins to fix
                ts/store/reducers/payments/history.ts on lines 139..144

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 47.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    case getType(paymentRedirectionUrls):
                      const navigationUrls: PaymentHistory = {
                        ...state[state.length - 1],
                        payNavigationUrls: action.payload
                      };
                Severity: Minor
                Found in ts/store/reducers/payments/history.ts and 1 other location - About 35 mins to fix
                ts/store/reducers/payments/history.ts on lines 101..106

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 47.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status