techno-express/node-7z-archive

View on GitHub

Showing 16 of 16 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

export const updateArchive =
    (SevenZip.updateArchive =
    SevenZip.update =
        function (
            filepath: string,
Severity: Major
Found in src/index.ts and 1 other location - About 1 day to fix
src/index.ts on lines 414..446

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 197.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

export const renameArchive =
    (SevenZip.renameArchive =
    SevenZip.rename =
        function (
            filepath: string,
Severity: Major
Found in src/index.ts and 1 other location - About 1 day to fix
src/index.ts on lines 502..534

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 197.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function list has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
Open

        function (
            filepath: string,
            options: { files?: string[] | undefined } | undefined,
            override = false
        ) {
Severity: Minor
Found in src/index.ts - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File index.ts has 382 lines of code (exceeds 250 allowed). Consider refactoring.
Open

'use strict';

import when from 'when';
import { Files, ReplaceNativeSeparator, Run } from './utility.js';
import { createSfx } from './createSfx.js';
Severity: Minor
Found in src/index.ts - About 5 hrs to fix

    Function Switches has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
    Open

    export const Switches = function (switches: Record<string, any>) {
        // Default value for switches
        switches = switches || {};
        let a = [];
        // Set default values of boolean switches
    Severity: Minor
    Found in src/utility.ts - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function Run has 72 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export function Run(
        binary: string = '7z',
        command: string | null = null,
        switches: { files?: string[] } = {},
        override: boolean = false
    Severity: Major
    Found in src/utility.ts - About 2 hrs to fix

      Function list has 70 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              function (
                  filepath: string,
                  options: { files?: string[] | undefined } | undefined,
                  override = false
              ) {
      Severity: Major
      Found in src/index.ts - About 2 hrs to fix

        Function onprogress has 44 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                        function onprogress(data: string) {
                            type Entry = {
                                date: Date;
                                attr: string;
                                size: number;
        Severity: Minor
        Found in src/index.ts - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          export const createSfxLinux = (SevenZip.linuxSfx = function (
              name: string,
              files: string[],
              destination: string | undefined,
              options: Record<string, any> | undefined
          Severity: Major
          Found in src/index.ts and 1 other location - About 1 hr to fix
          src/index.ts on lines 637..652

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 69.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          export const createSfxMac = (SevenZip.macSfx = function (
              name: string,
              files: string[],
              destination: string | undefined,
              options: Record<string, any> | undefined
          Severity: Major
          Found in src/index.ts and 1 other location - About 1 hr to fix
          src/index.ts on lines 604..619

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 69.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function Switches has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          export const Switches = function (switches: Record<string, any>) {
              // Default value for switches
              switches = switches || {};
              let a = [];
              // Set default values of boolean switches
          Severity: Minor
          Found in src/utility.ts - About 1 hr to fix

            Function retry has 8 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                command: string | undefined,
                options: {},
                override: boolean | undefined,
                progress: (arg0: any) => void,
                onprogress: (data: any) => any[],
            Severity: Major
            Found in src/index.ts - About 1 hr to fix

              Function createSfx has 7 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  name: string,
                  files: Array<string>,
                  destination: string = '',
                  options: Record<string, any> = {
                      title: null,
              Severity: Major
              Found in src/createSfx.ts - About 50 mins to fix

                Function windowsSfx has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    name: string,
                    files: string[],
                    destination: string | undefined,
                    options: Record<string, any> | undefined,
                    type: string | undefined
                Severity: Minor
                Found in src/index.ts - About 35 mins to fix

                  Function only has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                              filepath: string,
                              dest: string,
                              files: any,
                              options = {},
                              override = false
                  Severity: Minor
                  Found in src/index.ts - About 35 mins to fix

                    Function getPath has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                    Open

                    function getPath(module: string, folder = pwd): string | null {
                        if (folder.length < 1) {
                            return null;
                        }
                    
                    
                    Severity: Minor
                    Found in src/createSfx.ts - About 35 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Severity
                    Category
                    Status
                    Source
                    Language