Sign upLogin

theforeman/foreman

View on GitHub
Star
app/controllers/concerns/api/v2/bulk_hosts_extension.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method find_bulk_hosts has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

  def find_bulk_hosts(permission, bulk_params, restrict_to = nil)
    # works on a structure of param_group bulk_params and transforms it into a list of systems
    bulk_params[:included] ||= {}
    bulk_params[:excluded] ||= {}
    search_param = bulk_params[:included][:search] || bulk_params[:search]
Severity: Minor
Found in app/controllers/concerns/api/v2/bulk_hosts_extension.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status