Sign upLogin

theforeman/foreman

View on GitHub
Star
app/models/compute_resource.rb

Summary

Maintainability
D
2 days
Test Coverage

Class ComputeResource has 84 methods (exceeds 20 allowed). Consider refactoring.
Open

class ComputeResource < ApplicationRecord
  audited :except => [:attrs]
  include Taxonomix
  include Encryptable
  include Authorizable
Severity: Major
Found in app/models/compute_resource.rb - About 1 day to fix

    File compute_resource.rb has 360 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class ComputeResource < ApplicationRecord
  audited :except => [:attrs]
  include Taxonomix
  include Encryptable
  include Authorizable
    Severity: Minor
    Found in app/models/compute_resource.rb - About 4 hrs to fix

      Method nested_attributes_for has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

        def nested_attributes_for(type, opts)
    return [] unless opts
    opts = opts.to_hash if opts.class == ActionController::Parameters

    opts = opts.dup # duplicate to prevent changing the origin opts.
      Severity: Minor
      Found in app/models/compute_resource.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method update_required? has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        def update_required?(old_attrs, new_attrs)
    old_attrs.deep_symbolize_keys.merge(new_attrs.deep_symbolize_keys) do |k, old_v, new_v|
      if old_v.is_a?(Hash) && new_v.is_a?(Hash)
        return true if update_required?(old_v, new_v)
      elsif old_v.to_s != new_v.to_s
      Severity: Minor
      Found in app/models/compute_resource.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status