Sign upLogin

theforeman/foreman

View on GitHub
Star
app/models/compute_resources/foreman/model/openstack.rb

Summary

Maintainability
D
1 day
Test Coverage

Class Openstack has 44 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Openstack < ComputeResource
    include KeyPairComputeResource
    attr_accessor :scheduler_hint_value
    delegate :flavors, :to => :client
    delegate :security_groups, :to => :client
Severity: Minor
Found in app/models/compute_resources/foreman/model/openstack.rb - About 6 hrs to fix

    File openstack.rb has 279 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    module Foreman::Model
  class Openstack < ComputeResource
    include KeyPairComputeResource
    attr_accessor :scheduler_hint_value
    delegate :flavors, :to => :client
    Severity: Minor
    Found in app/models/compute_resources/foreman/model/openstack.rb - About 2 hrs to fix

      Method create_vm has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
      Open

          def create_vm(args = {})
      boot_from_volume(args) if Foreman::Cast.to_bool(args[:boot_from_volume])
      network = args.delete(:network)
      # fix internal network format for fog.
      args[:nics].delete_if(&:blank?)
      Severity: Minor
      Found in app/models/compute_resources/foreman/model/openstack.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method fog_credentials has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

          def fog_credentials
      { :provider           => :openstack,
        :openstack_api_key  => password,
        :openstack_username => user,
        :openstack_auth_url => url_for_fog,
      Severity: Minor
      Found in app/models/compute_resources/foreman/model/openstack.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method normalize_vm_attrs has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def normalize_vm_attrs(vm_attrs)
      normalized = slice_vm_attributes(vm_attrs, ['availability_zone', 'tenant_id', 'scheduler_hint_filter'])

      normalized['flavor_id'] = vm_attrs['flavor_ref']
      normalized['flavor_name'] = flavors.detect { |t| t.id == normalized['flavor_id'] }.try(:name)
      Severity: Minor
      Found in app/models/compute_resources/foreman/model/openstack.rb - About 1 hr to fix

        Method destroy_vm has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            def destroy_vm(uuid)
      vm           = find_vm_by_uuid(uuid)
      floating_ips = vm.all_addresses
      floating_ips.each do |address|
        client.disassociate_address(uuid, address['ip']) rescue true
        Severity: Minor
        Found in app/models/compute_resources/foreman/model/openstack.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method normalize_vm_attrs has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            def normalize_vm_attrs(vm_attrs)
      normalized = slice_vm_attributes(vm_attrs, ['availability_zone', 'tenant_id', 'scheduler_hint_filter'])

      normalized['flavor_id'] = vm_attrs['flavor_ref']
      normalized['flavor_name'] = flavors.detect { |t| t.id == normalized['flavor_id'] }.try(:name)
        Severity: Minor
        Found in app/models/compute_resources/foreman/model/openstack.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              normalized['interfaces_attributes'] = nics_ids.map.with_index do |nic_id, idx|
        [idx.to_s, {
          'id' => nic_id,
          'name' => internal_networks.detect { |n| n.id == nic_id }.try(:name),
        }]
        Severity: Minor
        Found in app/models/compute_resources/foreman/model/openstack.rb and 1 other location - About 15 mins to fix
        app/models/compute_resources/foreman/model/ec2.rb on lines 167..171

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 26.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status