Class Ovirt has 79 methods (exceeds 20 allowed). Consider refactoring.

Open

  class Ovirt < ComputeResource
    ALLOWED_DISPLAY_TYPES = %w(vnc spice)

    validates :url, :format => { :with => URI::DEFAULT_PARSER.make_regexp }, :presence => true,
              :url_schema => ['http', 'https']

File ovirt.rb has 613 lines of code (exceeds 250 allowed). Consider refactoring.

Open

require 'foreman/exception'
require 'uri'

module Foreman::Model
  class Ovirt < ComputeResource

Method sanitize_inherited_vm_attributes has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.

Open

    def sanitize_inherited_vm_attributes(args, template, instance_type)
      # Override memory an cores values if template and/or instance type is/are provided.
      # Take template values if blank values for VM attributes, because oVirt will fail if empty values are present in VM definition
      # Instance type values always take precedence on templates or vm provided values
      if template

• Read up
  Read up

Method determine_os_type has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.

Open

    def determine_os_type(host)
      return nil unless host
      return host.params['ovirt_ostype'] if host.params['ovirt_ostype']
      ret = "other_linux"
      return ret unless host.operatingsystem

• Read up
  Read up

Method create_interfaces has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.

Open

    def create_interfaces(vm, attrs, cluster_id)
      # first remove all existing interfaces
      vm.interfaces&.each do |interface|
        # The blocking true is a work-around for ovirt bug, it should be removed.
        vm.destroy_interface(:id => interface.id, :blocking => true)

• Read up
  Read up

Method create_vm has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.

Open

    def create_vm(args = {})
      args[:comment] = args[:user_data] if args[:user_data]
      args[:template] = args[:image_id] if args[:image_id]
      template = template(args[:template]) if args[:template]
      instance_type = instance_type(args[:instance_type]) unless args[:instance_type].empty?

• Read up
  Read up

Method determine_os_type has 26 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    def determine_os_type(host)
      return nil unless host
      return host.params['ovirt_ostype'] if host.params['ovirt_ostype']
      ret = "other_linux"
      return ret unless host.operatingsystem

Method update_required? has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.

Open

    def update_required?(old_attrs, new_attrs)
      return true if super(old_attrs, new_attrs)

      new_attrs[:interfaces_attributes]&.each do |key, interface|
        return true if (interface[:id].blank? || interface[:_delete] == '1') && key != 'new_interfaces' # ignore the template

• Read up
  Read up

Method preallocate_and_clone_disks has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.

Open

    def preallocate_and_clone_disks(args, template)
      volumes_to_change = args[:volumes_attributes].values.select { |x| x[:id].present? }
      return unless volumes_to_change.present?

      template_disks = template.volumes

• Read up
  Read up

Method update_available_operating_systems has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.

Open

    def update_available_operating_systems
      return false if errors.any?
      ovirt_operating_systems = client.operating_systems if client.respond_to?(:operating_systems)

      attrs[:available_operating_systems] = ovirt_operating_systems.map do |os|

• Read up
  Read up

Method supports_operating_systems? has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.

Open

    def supports_operating_systems?
      if client.respond_to?(:operating_systems)
        unless attrs.key?(:available_operating_systems)
          update_available_operating_systems
          save

• Read up
  Read up

Method update_interfaces has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.

Open

    def update_interfaces(vm, attrs)
      interfaces = nested_attributes_for :interfaces, attrs
      interfaces.each do |interface|
        vm.destroy_interface(:id => interface[:id]) if interface[:_delete] == '1' && interface[:id]
        if interface[:id].blank?

• Read up
  Read up

Method client has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.

Open

    def client
      return @client if @client
      client = ::Fog::Compute.new(
        :provider         => "ovirt",
        :ovirt_username   => user,

• Read up
  Read up

Method connect has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.

Open

    def connect(options = {})
      return unless connection_properties_valid?

      update_public_key options
      datacenters && test_https_required

• Read up
  Read up

Method update_public_key has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.

Open

    def update_public_key(options = {})
      return unless public_key.blank? || options[:force]
      client
    rescue Foreman::FingerprintException => e
      self.public_key = e.fingerprint if public_key.blank?

• Read up
  Read up