Sign upLogin

theforeman/foreman

View on GitHub
Star
app/models/role.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Class Role has 37 methods (exceeds 20 allowed). Consider refactoring.
Open

class Role < ApplicationRecord
  audited
  include Authorizable
  include ScopedSearchExtensions
  extend FriendlyId
Severity: Minor
Found in app/models/role.rb - About 4 hrs to fix

    File role.rb has 268 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class Role < ApplicationRecord
  audited
  include Authorizable
  include ScopedSearchExtensions
  extend FriendlyId
    Severity: Minor
    Found in app/models/role.rb - About 2 hrs to fix

      Method add_permissions has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def add_permissions(permissions, options = {})
    permissions = Array(permissions)
    search = options.delete(:search)

    collection = permission_records permissions
      Severity: Minor
      Found in app/models/role.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status