Sign upLogin

theforeman/foreman

View on GitHub
Star
app/registries/setting_registry.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Class SettingRegistry has 22 methods (exceeds 20 allowed). Consider refactoring.
Open

class SettingRegistry
  include Singleton
  include Enumerable
  extend ScopedSearch::ClassMethods
Severity: Minor
Found in app/registries/setting_registry.rb - About 2 hrs to fix

    Method load_values has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

      def load_values(ignore_cache: false)
    # we are loading only known STIs as we load settings fairly early the first time and plugin classes might not be loaded yet.
    settings = Setting.unscoped
    settings = settings.where('updated_at >= ?', @values_loaded_at) unless ignore_cache || @values_loaded_at.nil?
    settings.each do |s|
    Severity: Minor
    Found in app/registries/setting_registry.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method complete_value_from_db has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        def complete_value_from_db(field, val)
      count = 20
      case field.field
      when :name
        results = @registry.filter_map { |set| ((set.full_name =~ /\s/) ? "\"#{set.full_name.gsub('"', '\"')}\"" : set.full_name) if set.name.include?(val) || set.full_name&.include?(val) }
    Severity: Minor
    Found in app/registries/setting_registry.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status