app/services/foreman_chef/fact_parser.rb
Method operatingsystem
has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring. Open
Open
def operatingsystem
os_name = facts['lsb::id'] || facts['platform']
release = facts['lsb::release'] || facts['platform_version']
# if we have no release information we can't assign OS properly (e.g. missing redhat-lsb)
if release.nil?
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method operatingsystem
has 35 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
def operatingsystem
os_name = facts['lsb::id'] || facts['platform']
release = facts['lsb::release'] || facts['platform_version']
# if we have no release information we can't assign OS properly (e.g. missing redhat-lsb)
if release.nil?
Method set_additional_attributes
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
Open
def set_additional_attributes(attributes, name)
if name =~ VIRTUAL_NAMES
attributes[:virtual] = true
if Regexp.last_match(1).nil? && name =~ BRIDGES
attributes[:bridge] = true
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"